Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7127411rwb; Tue, 6 Dec 2022 01:18:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf7VZY/soHui3iSpupP8cmpEUQ88k8fa8/OXQ4xIDP95VpNXasxOwAi+I+57Somx3odwS5Eh X-Received: by 2002:a17:906:6782:b0:7ad:7d50:dec2 with SMTP id q2-20020a170906678200b007ad7d50dec2mr75474476ejp.37.1670318307581; Tue, 06 Dec 2022 01:18:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670318307; cv=none; d=google.com; s=arc-20160816; b=0MUceQAWtpxDMKF0e75s6a602Abo27rhlsSQaQDvC4twpbZGEPSyTcXy9EaxBxIkhX 9m5qWPRijRQFLO7/IqE2495zh0mWvOg1OHvrdzYs6ejhAOOGq1ogycxvfIwiOcjkv6h4 TTeCb1P7I+yxx1v615BzWkPLkXptyIB8pmOQuHTjLELFKtthNd6TYf8mPWZ+QaswKaEl a2PFgyX9JZnIb1P3NOv9LAW6mJyONh50/KQWnL2lNR20qSWi57uI3vrcYojTFoJriYsn r4Ky5MWNM3nLXZ4snW0VLTQBjyFhMmA0kcZp9Jg3mBq4Ul+uH4JEl8AE/wmWGC8iujJ9 6KEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AVVv7jBfSbt3h5tg4dBpM0471svfnj/qbvcu+E5MN3U=; b=aSrensLAw97LFkI7CKYeHRV5M3zGlLvxxGufmQLpOXtzGwxKmnCDLsEsN8njGaQciz CbYTvBJ2oSbvfHq+tds++SGOSbLWodHyELxBFjeyv4iAbLqzPjFY06AlVw5qIyJU6p76 XeBCOm9F0mYYd19xHFMYbEPj6WR1pEfwvii9+NhNvFvHjtk0evqG24ymSubfiHt7tAVF 4NAd5cGzjqdsqo2Mf/GOjcXQo2/2V1LCTnQidue64Ph3ofdfOVjAtNKyb5+Gn+2SZLta LR3d5qklozhtyOcQwztURIAjhPBMniDYSYmaj9SvI/hU7wlNp4b+HGabh8LV0gC5lpEI quKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="JxAx8/GR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n4-20020aa7c784000000b00463f8aad371si1302318eds.239.2022.12.06.01.18.06; Tue, 06 Dec 2022 01:18:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="JxAx8/GR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234435AbiLFI66 (ORCPT + 79 others); Tue, 6 Dec 2022 03:58:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234428AbiLFI64 (ORCPT ); Tue, 6 Dec 2022 03:58:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D64131C436; Tue, 6 Dec 2022 00:58:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8CDB0B818CB; Tue, 6 Dec 2022 08:58:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66E59C433D6; Tue, 6 Dec 2022 08:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670317132; bh=6hC6q62YWRveam3AL7WSGJpsWyeG22u37HMG9JMaXxI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JxAx8/GRcTVX4o2aj8TMqSfS3DniSNQTXtVyyWTHnu04UZrE8lIRIkEs2zgajhb+Y /d1npkJhZpmQGMB8fzBR2pfIfmr2BRqIOc5wEFItejAUjdzxQEl8M4IE6jA+jWn6fF 6NjOZ50sauClyO96Npps56VDmWqJ1BjEpu1W0nMoPmjXxPvQSyTNqbyr0YUDeszwK1 csYOB3+dcqukLq67Tq2clIN2l+ji2Xy0FqjpOJBJhvsbUhv48B1klyrJZqSHjKeFO6 gBo7ztvCebJZrlewCuMtZ8H3PBpc13UpKAro9bg4Hl1SFT5HnaE/CjPVkx4P+CSxPC 3NoK9YbbNf7SA== Date: Tue, 6 Dec 2022 10:58:47 +0200 From: Leon Romanovsky To: Jakub Kicinski Cc: Veerasenareddy Burru , "David S. Miller" , Eric Dumazet , Paolo Abeni , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Liron Himi , Abhijit Ayarekar , Sathesh B Edara , Satananda Burla , "linux-doc@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control messages Message-ID: References: <20221129130933.25231-1-vburru@marvell.com> <20221129130933.25231-3-vburru@marvell.com> <20221205161626.088e383f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221205161626.088e383f@kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 05, 2022 at 04:16:26PM -0800, Jakub Kicinski wrote: > On Mon, 5 Dec 2022 10:10:34 +0200 Leon Romanovsky wrote: > > > These messages include periodic keep alive (heartbeat) messages > > > from FW and control messages from VFs. Every PF will be listening > > > for its own control messages. > > > > @netdev, as I said, I don't know if it is valid behaviour in netdev. > > Can you please comment? > > Polling for control messages every 100ms? Sure. > > You say "valid in netdev" so perhaps you can educate us where/why it > would not be? It doesn't seem right to me that idle device burns CPU cycles, while it supports interrupts. If it needs "listen to FW", it will be much nicer to install interrupts immediately and don't wait for netdev. Thanks