Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 09:52:54 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Aditya Garg <gargaditya08@live.com>
Cc:     Christoph Hellwig <hch@lst.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        "willy@infradead.org" <willy@infradead.org>,
        "ira.weiny@intel.com" <ira.weiny@intel.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "slava@dubeyko.com" <slava@dubeyko.com>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hfsplus: Add module parameter to enable force writes
Message-ID: <20221206085254.GA9597@lst.de>
References: <53821C76-DAFE-4505-9EC8-BE4ACBEA9DD9@live.com> <20221202125344.4254ab20d2fe0a8e784b33e8@linux-foundation.org> <20221204080752.GA26794@lst.de> <A35CC249-5F77-4B1A-B68F-8E07A38AB73B@live.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <A35CC249-5F77-4B1A-B68F-8E07A38AB73B@live.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Sun, Dec 04, 2022 at 11:01:49AM +0000, Aditya Garg wrote:
> Although, if you think its worth it, the following improvements can be made :-
> 
> 1. There is no logging showing that writes have been force enabled. We could add that.

I think this would be very useful.

> 2. We could have separate mount options for journaled and locked volumes (although I dunno in what case we get locked volumes).

We can't really retire the existing option, but if for your use case
you'd prefer to only allow one of them and want to not write to the
other case feel free to submit a patch to add that option.