Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 08:55:45 +0000
From:   Martin Habets <habetsm.xilinx@gmail.com>
To:     ye.xingchen@zte.com.cn
Cc:     leon@kernel.org, davem@davemloft.net, ecree.xilinx@gmail.com,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        petrm@nvidia.com, khalasa@piap.pl, shayagr@amazon.com,
        wsa+renesas@sang-engineering.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] sfc: use sysfs_emit() to instead of
 scnprintf()
Message-ID: <Y48DkToW/Yvvid+0@gmail.com>
Mail-Followup-To: ye.xingchen@zte.com.cn, leon@kernel.org,
        davem@davemloft.net, ecree.xilinx@gmail.com, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, petrm@nvidia.com,
        khalasa@piap.pl, shayagr@amazon.com,
        wsa+renesas@sang-engineering.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <202212051021451139126@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202212051021451139126@zte.com.cn>
Precedence: bulk

On Mon, Dec 05, 2022 at 10:21:45AM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
> 
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Acked-by: Martin Habets <habetsm.xilinx@gmail.com>

> ---
> v1 -> v2
> Fix the Subject.
>  drivers/net/ethernet/sfc/efx_common.c       | 2 +-
>  drivers/net/ethernet/sfc/siena/efx_common.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c
> index c2224e41a694..cc30524c2fe4 100644
> --- a/drivers/net/ethernet/sfc/efx_common.c
> +++ b/drivers/net/ethernet/sfc/efx_common.c
> @@ -1164,7 +1164,7 @@ static ssize_t mcdi_logging_show(struct device *dev,
>  	struct efx_nic *efx = dev_get_drvdata(dev);
>  	struct efx_mcdi_iface *mcdi = efx_mcdi(efx);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled);
> +	return sysfs_emit(buf, "%d\n", mcdi->logging_enabled);
>  }
> 
>  static ssize_t mcdi_logging_store(struct device *dev,
> diff --git a/drivers/net/ethernet/sfc/siena/efx_common.c b/drivers/net/ethernet/sfc/siena/efx_common.c
> index 1fd396b00bfb..e4b294b8e9ac 100644
> --- a/drivers/net/ethernet/sfc/siena/efx_common.c
> +++ b/drivers/net/ethernet/sfc/siena/efx_common.c
> @@ -1178,7 +1178,7 @@ static ssize_t mcdi_logging_show(struct device *dev,
>  	struct efx_nic *efx = dev_get_drvdata(dev);
>  	struct efx_mcdi_iface *mcdi = efx_mcdi(efx);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled);
> +	return sysfs_emit(buf, "%d\n", mcdi->logging_enabled);
>  }
> 
>  static ssize_t mcdi_logging_store(struct device *dev,
> -- 
> 2.25.1