Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7152683rwb; Tue, 6 Dec 2022 01:46:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf621A/nBpmJXq/T9grwLMhC0q6QD8aov+asMeE9Iz0sIr8iUAu+M8rzX07MqwSCaY7XYfES X-Received: by 2002:a63:4246:0:b0:477:98cc:3d01 with SMTP id p67-20020a634246000000b0047798cc3d01mr56111862pga.505.1670319961390; Tue, 06 Dec 2022 01:46:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670319961; cv=none; d=google.com; s=arc-20160816; b=nOpLOMQ0YA2Czf5nJ+yu4uy2oh8WPppUWBBipHYc05yBEz8zSKdN/kzNrjJSYp0dkk 4eWi8Paw/h6FfDaGl8kRNBNAAVqDz8EmvuukRTImo8AoRZGsIw+k+a0PNeAptyt/QGfu T4L9e7NsT4TLC42IbL9pFRCjNuGP6EXTsiDCH7RubwFD5GDAwmCW/WJU1bUOINJbyD6L +TE0W1jtmZqpC40o5ys0ByMLo1g8uJlYgGM7QBjgj5dNQKv5G8UqVakGF+lndyDxPEF5 byWKPYa/nxd8GroCRdQbofd5BWkIqfQeV2pzun9+NIulRtXr7pTWfoTQQr2cU5aMcggj ytJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=a8/S6ykdg/g49/FLME8o1MfbsUhOagdLOH5bnruHpgc=; b=Q/3JeVZxfKfpRVfNQkp0K+pQufBKRYZqghPqMHxxtkpw/Hynkl7w4eie0q+M/OxHLJ kbLkK+OKGQPCq72dKzHzL34gvzPFimO8A+v9i5s43tgmxnqs2bczZU97GqWZH3oUnBfy tvrZHSBEHrN5qvvgyhiSw31sNglpaKKpPDCU1ZCgValZMq/4zRaEjyHH2ato2eXrXRTf u3cChPcTOF36YEZyz1f0cBZjAdFmz832j1pr/C45oibAKzX3Lu6LetR3+Ly4GQ6xXX7t nz+cAxDzq02awI3Bxhm6sNgqA9wpYUwQ+tPCnCBoAJsz5baYN1Us5fTMgRKkTwuN9jE6 Bc0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b="tVOT/KX5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a62e70c000000b005718d10c3c3si16022518pfh.275.2022.12.06.01.45.50; Tue, 06 Dec 2022 01:46:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b="tVOT/KX5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233588AbiLFJK4 (ORCPT + 80 others); Tue, 6 Dec 2022 04:10:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234619AbiLFJKe (ORCPT ); Tue, 6 Dec 2022 04:10:34 -0500 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16C261E3F2 for ; Tue, 6 Dec 2022 01:10:07 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id a19so16544403ljk.0 for ; Tue, 06 Dec 2022 01:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a8/S6ykdg/g49/FLME8o1MfbsUhOagdLOH5bnruHpgc=; b=tVOT/KX5QXizryslSdAePiV+U23GGylwtj7MDpkRxFUOUoMhhe1p3yLmektj+AscQ2 plN8nnb4Ym6VVSr6WxMHAoLi2RaU8EGLQEjm2u5zDVrj6T77eC6cXLpKquV8Vr3lCDgc 1JGwzmHC/rCgv1xMhbqQXawa+66F3y72uXPM02vPxqGqT9yXADXZUGQOmo8MJ97zY4Gs 9fiAxVMubMdmmrXQrWBUKHvLz3sY0Bo33nq3eIWY8qYOD9929BjoKFRMuRNCOrluApiZ fgcJSFMYfGXnmaK+Wq9kcLipzTOCxrP10zVzqXcPjMVLJJLCzGTGM8R9O6nUNn29AQ8y dJcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a8/S6ykdg/g49/FLME8o1MfbsUhOagdLOH5bnruHpgc=; b=AXUpS295MQv0PBCeQQ3pPMMP7oARX1qXWldzEkyeDssC6AiQMDeNrfnjZfMt/sEh+D FE67LxzRDxXLkX6iRGiJP5b66kY3/aDWjraDWuSB6ZyopsT9/8HDdjswtmhxNA4m/QKm yxXJk/w5OQ2PguWd2iq+4Ng+fjPz+8IRlT29z0Y9hCTpI9CntQajCfmFoLv9sNhrfbWT cdqmAne55j5/FjSp2fR0UjyHn9+k2ugi/2ZRHjIuKKbb02koMgy+UttKVOEKWFcs5y5m Y7+WX+oRXALKEGR0ic99dDYL+ndWz+ugLHt9GrObpP7BTu3gZmZ/EehtXogSgtNkltAL tBKg== X-Gm-Message-State: ANoB5pka7X0dSs40fnZmgLEqa6O8Y0UERxNTKIkYZb3oKm2ARyA372Ac 17/qdqtlcjXnidn9BVotBVlZeBuwZyU0mbtHWik8XQ== X-Received: by 2002:a17:907:8b06:b0:7c0:8e3a:9a54 with SMTP id sz6-20020a1709078b0600b007c08e3a9a54mr25454851ejc.619.1670317794846; Tue, 06 Dec 2022 01:09:54 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id v6-20020a170906180600b007c0c679ca2fsm4744150eje.26.2022.12.06.01.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 01:09:54 -0800 (PST) Date: Tue, 6 Dec 2022 10:09:53 +0100 From: Jiri Pirko To: Divya Koppera Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, richardcochran@gmail.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH v5 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Message-ID: References: <20221206073511.4772-1-Divya.Koppera@microchip.com> <20221206073511.4772-2-Divya.Koppera@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206073511.4772-2-Divya.Koppera@microchip.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Dec 06, 2022 at 08:35:10AM CET, Divya.Koppera@microchip.com wrote: >Initialized return variable Not only here, but in the patch/patchset subject, you should be imperative to the codebase and tell it what to do. > >Fixes Old smatch warnings: >drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error: >uninitialized symbol 'ret'. > >Reported-by: kernel test robot >Reported-by: Dan Carpenter >Fixes: 21b688dabecb ("net: phy: micrel: Cable Diag feature for lan8814 phy") >Reviewed-by: Andrew Lunn >Signed-off-by: Divya Koppera >--- >v4 -> v5: >- No changes, added reviewed by tag. > >v3 -> v4: >- Split the patch for different warnings. > >v1 -> v3: >- No changes >--- > drivers/net/phy/micrel.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c >index 26ce0c5defcd..1bcdb828db56 100644 >--- a/drivers/net/phy/micrel.c >+++ b/drivers/net/phy/micrel.c >@@ -2088,7 +2088,8 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev, > const struct kszphy_type *type = phydev->drv->driver_data; > unsigned long pair_mask = type->pair_mask; > int retries = 20; >- int pair, ret; >+ int ret = 0; >+ int pair; > > *finished = false; > >-- >2.17.1 >