Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: 1aIBve8iRHszO/o7tn59kVff0Kh6jlwM9056JpuJ/TBqrwjpD+bj2Or47b1qZ1uXx2XGm0KJzD
 uD/CDAn/0ZYF5R/OG6se6wzLhjVXouD8JgqQafxI4rtmpBJ1OZnMsQ/SLzj7eIFzlEFO4hePOK
 pTWZ/TL+ZFLmi3c+UWPIHYIMUd4m3Z16KOF9b/eWVE5ve+xsDfglvDEe78rBj/pREAIHacwtuB
 9paxQ7RLzOBCB+Lzy5ypdogUZggBL4YzoYMKq4lWL3KU2NODUD4kR+vRXSmn+BOqG5Vv6k00Sg
 Wqk=
IronPort-SDR: b/Qq7WvwJHWKEtXMn4Gp//hhcH+p5GjPdiXI2OWmeftukdZk9IZO6/+wWar42S1nOq0Ps2vm0X
 8/RELPaK9t2tZXPcTvkWbAs6uRrI30v6ynZALzN7kyH07bYJlV6isOeNqZUKsxRr9z7Ty/rOVA
 4h7wt3OhR/BBY5Ujg6tSDfInueCDlMOvd9BZfbXTvEJCtnz7j2O3lvf/0U9GieYely8FvSY/Ql
 bxBAi62zZCTfsJQsXYjvrHhEr0GbkpDGOy5ljKQAsVRTxkLUKjGOysok7/NZCI7TR+LhlnTo/9
 Vbw=
WDCIronportException: Internal
Message-ID: <fa2bc2b9-d74a-51a3-cb5f-80d04e145b27@opensource.wdc.com>
Date:   Tue, 6 Dec 2022 18:12:48 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006
 tag
Content-Language: en-US
To:     Serge Semin <fancer.lancer@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>
Cc:     Anders Roxell <anders.roxell@linaro.org>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        Naresh Kamboju <naresh.kamboju@linaro.org>,
        Praneeth Bajjuri <praneeth@ti.com>,
        Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        open list <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "regressions@lists.linux.dev" <regressions@lists.linux.dev>,
        "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
        <linux-ide@vger.kernel.org>,
        "lkft-triage@lists.linaro.org" <lkft-triage@lists.linaro.org>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        Carlos Hernandez <ceh@ti.com>,
        Sumit Semwal <sumit.semwal@linaro.org>
References: <CADYN=9JiX-=PcKMzAcSm=p7Dh6kYT7Kbv-8kcNF0MQ4=1hFS5g@mail.gmail.com>
 <20221014140633.mlypet7skkxvt453@mobilestation>
 <CADYN=9LrKHRNMON3GA4piDvWeSWTASQ1u2=D30rXFdvo1L18bg@mail.gmail.com>
 <20221017155246.zxal2cfehjgaajcu@mobilestation>
 <CA+G9fYtYetV5sZVD14WkZxCE_tgTC4VVKm8BcBw5_NwXD6U=Sw@mail.gmail.com>
 <Y4cqcTRcni5H7UAU@x1-carbon>
 <CADYN=9KKGBXn-YkiiFxsUzsanTALbDV1c+tB0oUQPouE1idnuQ@mail.gmail.com>
 <20221205011105.4do4trbytq4bfw5b@mobilestation>
 <98670e23-6553-4788-8662-9403c480af82@app.fastmail.com>
 <f440a8ff-7657-c1be-e733-4ad69b6b7b0b@opensource.wdc.com>
 <20221206084637.olaflvqmxwoo467a@mobilestation>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20221206084637.olaflvqmxwoo467a@mobilestation>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/6/22 17:46, Serge Semin wrote:
> On Mon, Dec 05, 2022 at 10:24:22PM +0900, Damien Le Moal wrote:
>> On 12/5/22 19:08, Arnd Bergmann wrote:
>>> On Mon, Dec 5, 2022, at 02:11, Serge Semin wrote:
>>>> On Thu, Dec 01, 2022 at 12:48:32PM +0100, Anders Roxell wrote:
>>>
>>>>>
>>>>>   for (i = 0; i < hpriv->n_clks; i++) {
>>>>> - if (!strcmp(hpriv->clks[i].id, con_id))
>>>>> + if (hpriv->clks && hpriv->clks[i].id &&
>>>>> +    !strcmp(hpriv->clks[i].id, con_id))
>>>>>   return hpriv->clks[i].clk;
>>>>>   }
>>>>
>>>> Indeed I should have taken into account that devm_clk_bulk_get_all()
>>>> can get unnamed clocks too. But checking the hpriv->clks pointer for
>>>> being not null is redundant, since the ahci_platform_get_resources()
>>>> procedure makes sure that the array is always allocated. At the very
>>>> least you shouldn't check the pointer in the loop, but can make sure
>>>> that the clks array is available before it.
>>>
> 
>>> Do you think this is otherwise the correct fix then? Any chance we
>>> can still get a version of it into 6.1?
> 
> I'll think of a better solution. But at this stage it seems like the
> best choice seeing the bindings permit having unnamed clocks
> specified.
> 
>>
>> If someone sends me a proper patch to apply, I can send a last PR for 6.1
>> to Linus before week end.
> 
> I'll submit the patch today. Thanks.

Anders just posted one. Can you review it please ?

> 
> -Serge(y)
> 
>>
>>
>>>
>>>      Arnd
>>
>> -- 
>> Damien Le Moal
>> Western Digital Research
>>

-- 
Damien Le Moal
Western Digital Research