Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7181870rwb; Tue, 6 Dec 2022 02:15:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5wezPw9yprU7MBQcw7XfjMyXaeSQQdjUReNkMoPYFDrA06+N1hBqGrvT+TSYCzO6W2vjyE X-Received: by 2002:a63:5758:0:b0:477:fb27:ea7e with SMTP id h24-20020a635758000000b00477fb27ea7emr42052109pgm.551.1670321722823; Tue, 06 Dec 2022 02:15:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670321722; cv=none; d=google.com; s=arc-20160816; b=bsLP8i/yss0yB9nOAgqX0v0O6r+BanaLLko+ll1d1ffkm9uoz420w2J6zwQbwEyMXX yecoj/Sz5MA3OJlWteGIfmiyVb2OIvzGbRZ2aV20dAY4xBhh9cN5v3wXEHAJn6DxyHWj j8pFeknqPtUauOSYzpFLJFQCqkbNwtIvaZcUMH4bx1XotIQoBY6JOZ+DLypoCYRLT/ur yrJkood+uJ9kexxQpFNrTEU3JGZhvmwhHcBJm082LpDPQG6A3bTQio3sqTtgggUPasFI OZfPtgwqs45D+UJSP7/Iwu7ikEMos9HGYPYBJwg6ljFy/1QPCIZbvM0ML8HxrQtnUgEn zNbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=dLjJlW1va4VuAurqle20L/FYywnseXaeCSB8ad+MIzM=; b=K6LSFxRkLvP8Wh8FlDryiNJVQgcIemd82lU7mAlnaQaZLYHcWSXOhZb7vjXhVtBFVp qbaefau8vBISynZjGYMO+xgar4IaePPzsdKsIB47p7mrh60/i+BWxzDAwtyRN6N48qBY 3t6+JJIDml7wj7hGQeFZcDU47n3r7uTJmvaGJANuznvxvjbiCpZAK3ehb/XHP1FQd6/6 hAk66X0HmrKcmIUylb/qUxPoe9+hZBUFAFBiuDPrbmUWORY4w2iibvmr1O6fgqQ+8/CX kuAD/iHn6AfWfspGuoFIlluy1W2F9NKDUFGaDwEqY9yU5CKiZGSo+n+pPrhEckwH8Egq tpiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BJIfuLmM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i3-20020a6551c3000000b004704322da6fsi11436077pgq.273.2022.12.06.02.15.12; Tue, 06 Dec 2022 02:15:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BJIfuLmM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235221AbiLFJuR (ORCPT + 80 others); Tue, 6 Dec 2022 04:50:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233853AbiLFJt6 (ORCPT ); Tue, 6 Dec 2022 04:49:58 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72AA3C66; Tue, 6 Dec 2022 01:49:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CA8F9B818E5; Tue, 6 Dec 2022 09:49:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71067C433C1; Tue, 6 Dec 2022 09:49:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670320161; bh=6n4Bm0ycM73dP38b0rr7ZAIppKs6PXLxvgCOtqGB2aM=; h=From:To:Cc:Subject:Date:From; b=BJIfuLmMfExlNA6Sg919/ovJ4fcp5ydVxdt2kWIizE9plXBPiRX6kjCw8yNapiHW9 yOl3tVR34lBkT4KmABxsDHfPNpuVLNvF0o8fghU0MNw5YndL75beK3siRtDQnywrtF ScYjfWQPWI+moEDBTUsjHFKUocpyfphyjSbh+jpsqTYcdPO8bGInk6WN3ug38cRpmc GCu9rX2H1PHFvQPGHeb+3Ji0IWVOW0iyGsJNAiHrjniiHJyE64IkmN+YBtbYR4VWlX J4CvrMJG6Zo44U4rTvhPGSJD7MHAo8YZ/Z3jPOvbNWcAF/aCP5y1uqfFNbLUbT/418 YbiWKo4hacOdw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Shengjiu Wang , Mark Brown , Sasha Levin , shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH AUTOSEL 6.0 01/13] ASoC: fsl_micfil: explicitly clear software reset bit Date: Tue, 6 Dec 2022 04:49:04 -0500 Message-Id: <20221206094916.987259-1-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shengjiu Wang [ Upstream commit 292709b9cf3ba470af94b62c9bb60284cc581b79 ] SRES is self-cleared bit, but REG_MICFIL_CTRL1 is defined as non volatile register, it still remain in regmap cache after set, then every update of REG_MICFIL_CTRL1, software reset happens. to avoid this, clear it explicitly. Signed-off-by: Shengjiu Wang Link: https://lore.kernel.org/r/1651925654-32060-1-git-send-email-shengjiu.wang@nxp.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_micfil.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 79ef4e269bc9..8aa6871e0d42 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -194,6 +194,17 @@ static int fsl_micfil_reset(struct device *dev) if (ret) return ret; + /* + * SRES is self-cleared bit, but REG_MICFIL_CTRL1 is defined + * as non-volatile register, so SRES still remain in regmap + * cache after set, that every update of REG_MICFIL_CTRL1, + * software reset happens. so clear it explicitly. + */ + ret = regmap_clear_bits(micfil->regmap, REG_MICFIL_CTRL1, + MICFIL_CTRL1_SRES); + if (ret) + return ret; + return 0; } -- 2.35.1