Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7187545rwb; Tue, 6 Dec 2022 02:20:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf5wsQgx8t06CUlBHzYjv0BX1/uLWI60Qh5v/6m7Ah/Tcs7BEN6Xbju8+PGXriwRFg1cHNQh X-Received: by 2002:a17:90a:710b:b0:218:725:c820 with SMTP id h11-20020a17090a710b00b002180725c820mr94032710pjk.170.1670322034683; Tue, 06 Dec 2022 02:20:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670322034; cv=none; d=google.com; s=arc-20160816; b=zKI82kqyLeh9BwFMpOqa6xY+UIQ5RRqihvvhYUC5UkmbwkGY+FU/EPPptRZU+OtPWL hb+Lz4B3kKRp20JR36aMsv8xtSSBsT1MCfDQaPex4sWRu2tP+/kdf/FwTeH8ca6OX9c3 tt4zg2TzHWBEjLX5Sdwx5H0EDkI1OEE6XVjiSn7tUXuGSMneasZcbWnAO9Ro+DNAY1Y/ k3THqVE4I024BnP5jVJ6DNZs2zDcwrfXCwfKhtf+v3X26JBl2NEp1emyx3xAkmrfv0pf k10hY+JzDfvNTZ9s+ikNoEdltr54mLva7JsLSRvpwDafuR+pKf7P2RkUhcKI/ltvSoj8 AVeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=QNu8Jj7AVVudaYbX+CLTPbYHaoKOb8+SjzNWwWSo7XA=; b=GRzTc7QkyZ9+KzTKt0rWBh7N5sU5EZlr0HuVS2FjTEXEro03sWYBvZTsOKq3CJsUWu /IW6gc7ppZHhM2aRkbbE29gZI1pbevwQOPV9LYIIC+Gw/eJQOmAhHVlgRWekmtUmro65 zJ2fOa4Qg0D4hadq6+sWhdbbMEzohfr6KRhiaZ/iNaaqcvkVB4p7sNEXEk1+Nfh5qBJX 71MMNltN+WQYxNAcurkKU1Fn/AR/VEFqfYHFE8JebZs4UUk/dwGGtDT8WhtA8pSILtwL l3dtGj8QbhHYyl1mnLVIB0KZ9LG8moBwKBqCc4Mw6l04YcZ7Kmw6cXZrKcV6xYsX2V5B zw9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=DpSW7QsS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d16-20020a631d50000000b0047009247403si16964009pgm.409.2022.12.06.02.20.24; Tue, 06 Dec 2022 02:20:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=DpSW7QsS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234481AbiLFKKU (ORCPT + 79 others); Tue, 6 Dec 2022 05:10:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234483AbiLFKJz (ORCPT ); Tue, 6 Dec 2022 05:09:55 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D160C19; Tue, 6 Dec 2022 02:02:43 -0800 (PST) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B69BvaU013651; Tue, 6 Dec 2022 10:02:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=QNu8Jj7AVVudaYbX+CLTPbYHaoKOb8+SjzNWwWSo7XA=; b=DpSW7QsSjHzPUOkMFctKYTqkU68e3Z5X+BgGgX5zxMsnf/pTTVYV/30iHYF1AU8gCufd vCI/Q1IYtARi93bY0iCzxdVWipuPutoJRpDAC8al1k/IjxsCLH0TNGIoV4cabknCXqQ9 l/xe1tvUecFLDhUz2qO9epxtEUCkOHZgCkAx5+pWalyW8N29b6W++SCp5U1r7zhnBkN1 LfUs9Y+/exvH2NdMr9jNoanNOVLb5+kjCNPQNMCSq9R/xmCywCj4ilHwnZH9i+7sqnhI ccEKJq1MUHkd2YR94X2aYreqbmCKeEv/gevP4zWV+94v7na8OWeKZtdQfBLul15sDXAr 0g== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m9tqmbyrx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Dec 2022 10:02:33 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2B69bMWK030126; Tue, 6 Dec 2022 10:02:32 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m9tqmbyr6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Dec 2022 10:02:32 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.17.1.19/8.16.1.2) with ESMTP id 2B5K5OEu004999; Tue, 6 Dec 2022 10:02:30 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma01fra.de.ibm.com (PPS) with ESMTPS id 3m9pv9rpfn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 06 Dec 2022 10:02:30 +0000 Received: from d06av23.portsmouth.uk.ibm.com ([9.149.105.59]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2B6A2RUE15991256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 6 Dec 2022 10:02:27 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 11647A405B; Tue, 6 Dec 2022 10:02:27 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B2BE8A405F; Tue, 6 Dec 2022 10:02:26 +0000 (GMT) Received: from li-ce58cfcc-320b-11b2-a85c-85e19b5285e0 (unknown [9.152.224.212]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 6 Dec 2022 10:02:26 +0000 (GMT) Date: Tue, 6 Dec 2022 11:02:25 +0100 From: Halil Pasic To: Alex Williamson Cc: ruanjinjie , Tony Krowiak , Jason Herne , Kirti Wankhede , Kevin Tian , Eric Farman , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Halil Pasic Subject: Re: [PATCH] vfio/ap/ccw/samples: Fix device_register() unwind path Message-ID: <20221206110225.681a9bd6.pasic@linux.ibm.com> In-Reply-To: <166999942139.645727.12439756512449846442.stgit@omen> References: <166999942139.645727.12439756512449846442.stgit@omen> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) Content-Type: text/plain; charset=US-ASCII X-TM-AS-GCONF: 00 X-Proofpoint-GUID: T2ceiqn4SxTJEVVT7PQjC69AhBnGbf1A X-Proofpoint-ORIG-GUID: _fkZvVWHgNptlThpDeqDHDI_N-rxUbhG Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-06_05,2022-12-05_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1011 priorityscore=1501 spamscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212060078 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 02 Dec 2022 09:46:15 -0700 Alex Williamson wrote: > We always need to call put_device() if device_register() fails. > All vfio drivers calling device_register() include a similar unwind > stack via gotos, therefore split device_unregister() into its > device_del() and put_device() components in the unwind path, and > add a goto target to handle only the put_device() requirement. > > Reported-by: Ruan Jinjie > Link: https://lore.kernel.org/all/20221118032827.3725190-1-ruanjinjie@huawei.com > Fixes: d61fc96f47fd ("sample: vfio mdev display - host device") > Fixes: 9d1a546c53b4 ("docs: Sample driver to demonstrate how to use Mediated device framework.") > Fixes: a5e6e6505f38 ("sample: vfio bochs vbe display (host device for bochs-drm)") > Fixes: 9e6f07cd1eaa ("vfio/ccw: create a parent struct") > Fixes: 36360658eb5a ("s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem") > Cc: Tony Krowiak > Cc: Halil Pasic > Cc: Jason Herne > Cc: Kirti Wankhede > Reviewed-by: Kevin Tian > Reviewed-by: Eric Farman > Signed-off-by: Alex Williamson Reviewed-by: Halil Pasic