Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0f56e139-4c7f-5220-a4a2-99f87f45fd83@amd.com>
Date:   Tue, 6 Dec 2022 15:28:18 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH v2 00/11] SVM: vNMI (with my fixes)
Content-Language: en-US
To:     Maxim Levitsky <mlevitsk@redhat.com>, kvm@vger.kernel.org
Cc:     Sandipan Das <sandipan.das@amd.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Daniel Sneddon <daniel.sneddon@linux.intel.com>,
        Jiaxi Chen <jiaxi.chen@linux.intel.com>,
        Babu Moger <babu.moger@amd.com>, linux-kernel@vger.kernel.org,
        Jing Liu <jing2.liu@intel.com>,
        Wyes Karny <wyes.karny@amd.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        Sean Christopherson <seanjc@google.com>,
        Santosh Shukla <santosh.shukla@amd.com>
References: <20221129193717.513824-1-mlevitsk@redhat.com>
From:   Santosh Shukla <santosh.shukla@amd.com>
In-Reply-To: <20221129193717.513824-1-mlevitsk@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXl6MHNVYTZsM3pFY0M2cmZtSzg5ZGFsN2JlZFNXSThrcjdNSUR1Y0xKajRK?=
 =?utf-8?B?eTlaV3FYbiszNlVxUlZrTTRMeFlUT3diSjBIRzdha1RGdEYyQjZnYlJSYUtU?=
 =?utf-8?B?dVU0dUhKQlRFZzBEWWdrTEZqK3hsWnA0OU40Uk4reVVJa3JsaEtXTE5ESmNn?=
 =?utf-8?B?VXVGZGdXSUh4RGdPS1RCa25jbUdFOEdzVU1GeTMvVzk2TDJnV25uQjdUajVQ?=
 =?utf-8?B?THZTNXNnaVFpYlBEODdxZW1KWVgyZmZMOVlRS2JWczdwbkZiV3pFRExkMVJx?=
 =?utf-8?B?bXFRdGNML0NuVTRrcUVzUWJpWmx2WUVTQ3FpcDg1aUJLd0tGaFN2SllhZURH?=
 =?utf-8?B?U0F5ZDJsU0h1NDdoSjkzczdielYwYkZXUEpEZnFpKzlmUk9VTGhrang4OS9i?=
 =?utf-8?B?NFdnb0VEV3NzUG1yS000T2lDZ1pTV3d5R1dFTFRrekFJaTJyZHVmZFhyMGV3?=
 =?utf-8?B?YjNHam91KzhOMVplRnBHOGtQUG5EaWdHd0l5eHl1L2JtWXRHUGFQRWZiSXlY?=
 =?utf-8?B?S0EzeFg0Yy9MUzhHZFB1Z3k3UFpGVlQ3SEl1VCs3bzhLR2tScnBIQ05IOUZ2?=
 =?utf-8?B?OExuNVN5MmoyY3IvUlNER2FWOEZqekh5UC9lcXN5Rlc0YzhrVUhORVJYZlhR?=
 =?utf-8?B?T2FyRlJvcmhSbXVmYlFaTzhlMmxlcjhYQ2N0c1lwbGlyUG9IdzdTZ0FYS05M?=
 =?utf-8?B?KzZUWmFMTmxKeTZxM2NLdDZabGc1MmxRVUtYUUc4NEtzeEE1Mmo3YXZodnFl?=
 =?utf-8?B?ZkRoZ0xRY2YyeWhVRVovQVIxR25vYysvUE5uV3NDQnNxVU1wOUtKbTZMVFpi?=
 =?utf-8?B?emJtOU4rQ2ZtVVBzanNHdjRIQVhJOHNYbXBkdnBwbW5SaU1SakpESzBqNmdH?=
 =?utf-8?B?TEcybFJENTZEQkFvWmptb04xU0FkL21pSURzdjJXVHNJdlZTYXBYd1QrR3Vq?=
 =?utf-8?B?Vk5ib3ZtTWxZYjVyNWtRSXlkOERrUE9xR0pZalV4Y09VemU2YkI2TEhCTVU5?=
 =?utf-8?B?Y2pjQm5lcmYvQzE1MVR4MzhxeEt6MkdUS2pIbzZScWNMb0lic2JpNjJwbFFQ?=
 =?utf-8?B?ZUR0Y1puWStKc3VHNkNSaDl1Rm1ZdkozSGh1d0laK2Q2WjBmNUsxZUNDUW4y?=
 =?utf-8?B?MmNQWWFjQWY1bHBrWGcwRUhBMXh6U2MvbFBhajVGcWM1cVJTb25NREtiUGNs?=
 =?utf-8?B?V3dkQmNaeDVKS3M0YVFJRmJOcWZRUk5OMnNEWUVDSzlNNGxkTGhTSGlNanVh?=
 =?utf-8?B?eUMyYVY1WHpxekgwL1p4dVZlOWpLekZpZzNRNjFxQmprTW5wSE4wK3o3Tjds?=
 =?utf-8?B?UU9sei8wL0lXRHdqRFl5cXcvb3l1UGg4elBUZ0JrQVFBRUNzWmZvRFRZNGp0?=
 =?utf-8?B?Z1VkeWtkbFVFaHVVa3puNjBXSlR1ZDkvYVZPQmV4bWp0Z0JMV1FTcmhYMzRN?=
 =?utf-8?B?bnYyQUgwY1R2NkxjTHluTHJCSGRmTk9keE1GQnh0RlV4ZDh1N1hUd3ZXWW9W?=
 =?utf-8?B?RXRPaWRjazBxdWdYeCs2R05BQkoyN3l5R1BCZ2FONFBvOG13a1krcmxwa0tP?=
 =?utf-8?B?UU9EbVBQWmpXakF0NGtnSktjVzdLaWxaQUh6Qzh0T2RONEd5UzRtclNlWVV1?=
 =?utf-8?B?eFV4eEZNUVhER0JQeVlOV3kvL0o2VzV5d1lUM2hxd2xnQ0dUSEZSc3hIVEFQ?=
 =?utf-8?B?MXBOMnBZb0tIZG9xMk5xTElCNVlIbXpoVkc5bkxhdEdMTmd2d2dFRXI0NStu?=
 =?utf-8?B?Qk1oN3VmT3B1cFpRdjdsTU5jYXp6cVFHQkdveU9iL3F0V2p4Zk5QWk43V2Fr?=
 =?utf-8?B?OWU5NDhDOFpaTCt6VU4zRlJSWWlrL1lXcTRZV2JFYS9oU3JQcDZsa0VuZ0p6?=
 =?utf-8?B?UVJrWHFKVXRLZTNoZGQ0VXpJNjM1Tkx2dnY3eDcxcG15UitBT1NmWExlcHFF?=
 =?utf-8?B?QWUvZjFSZ2Zib2tVdnNzWXJjVWJ1QzQ0eFpHU01QVDc1RWI5VElDcmtwZ3lR?=
 =?utf-8?B?RVRLSzVDZmZSb3YwbDdZRklVbCtUbzJCazJhQXRoY09ycXhPcnNLM05ybEJl?=
 =?utf-8?B?MFJrTWdIbEs5ekg0enJvZytsY2dNMGZXMzFzcjkzZlZJOHo1ZkpYSDQ3aW5z?=
 =?utf-8?Q?/nl5L/GOrsgalg8uI0DRd9bfs?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: be71e3fa-dee5-4c0c-84c9-08dad770703d
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6323.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2022 09:58:36.1851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 82gJ2hr388U7deQUgX03aQO1RJ9dxy2TlUhDoJTpB+lDJ49Wr3Mt4jYc+BhJJuIv1zvo9Mpw5UtMF5Lw/2U/Fg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8224
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/30/2022 1:07 AM, Maxim Levitsky wrote:
> Hi!
> 
> 
> 
> This is the vNMI patch series based on Santosh Shukla's vNMI patch series.
> 
> 
> 
> In this version of this patch series I addressed most of the review feedback
> 
> added some more refactoring and also I think fixed the issue with migration.
> 
> 
> 
> I only tested this on a machine which doesn't have vNMI, so this does need
> 
> some testing to ensure that nothing is broken.
> 
> 
> 
> Best regards,
> 
>        Maxim Levitsky
> 
> 
Series tested on EPYC-v4.
Tested-By: Santosh Shukla <Santosh.Shukla@amd.com>

> 
> Maxim Levitsky (9):
> 
>   KVM: nSVM: don't sync back tlb_ctl on nested VM exit
> 
>   KVM: nSVM: clean up the copying of V_INTR bits from vmcb02 to vmcb12
> 
>   KVM: nSVM: explicitly raise KVM_REQ_EVENT on nested VM exit if L1
> 
>     doesn't intercept interrupts
> 
>   KVM: SVM: drop the SVM specific H_FLAGS
> 
>   KVM: x86: emulator: stop using raw host flags
> 
>   KVM: SVM: add wrappers to enable/disable IRET interception
> 
>   KVM: x86: add a delayed hardware NMI injection interface
> 
>   KVM: SVM: implement support for vNMI
> 
>   KVM: nSVM: implement support for nested VNMI
> 
> 
> 
> Santosh Shukla (2):
> 
>   x86/cpu: Add CPUID feature bit for VNMI
> 
>   KVM: SVM: Add VNMI bit definition
> 
> 
> 
>  arch/x86/include/asm/cpufeatures.h |   1 +
> 
>  arch/x86/include/asm/kvm-x86-ops.h |   2 +
> 
>  arch/x86/include/asm/kvm_host.h    |  24 +++--
> 
>  arch/x86/include/asm/svm.h         |   7 ++
> 
>  arch/x86/kvm/emulate.c             |  11 +--
> 
>  arch/x86/kvm/kvm_emulate.h         |   7 +-
> 
>  arch/x86/kvm/smm.c                 |   2 -
> 
>  arch/x86/kvm/svm/nested.c          | 102 ++++++++++++++++---
> 
>  arch/x86/kvm/svm/svm.c             | 154 ++++++++++++++++++++++-------
> 
>  arch/x86/kvm/svm/svm.h             |  41 +++++++-
> 
>  arch/x86/kvm/x86.c                 |  50 ++++++++--
> 
>  11 files changed, 318 insertions(+), 83 deletions(-)
> 
> 
>