Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221205163157.269335-1-nick.alcock@oracle.com> <20221205163157.269335-6-nick.alcock@oracle.com>
In-Reply-To: <20221205163157.269335-6-nick.alcock@oracle.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 6 Dec 2022 10:11:08 +0100
Message-ID: <CAMuHMdVrP1sLGRS999q=2L-5JhxXwcjBLkQREdcJhDerg70OtA@mail.gmail.com>
Subject: Re: [PATCH v10 05/13] kbuild: remove MODULE_LICENSE/AUTHOR/DESCRIPTION
 in non-modules
To:     Nick Alcock <nick.alcock@oracle.com>
Cc:     mcgrof@kernel.org, masahiroy@kernel.org,
        linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        linux-kernel@vger.kernel.org, arnd@arndb.de,
        akpm@linux-foundation.org, eugene.loh@oracle.com,
        kris.van.hees@oracle.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Nick,

Thanks for your patch!

On Mon, Dec 5, 2022 at 5:34 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations in
> non-modules will cause modprobe to misidentify their containing object
> file as a module when it is not, which might cause it to spuriously fail
> when trying to load something that is built in to the kernel.  They
> also cause misconstruction of modules.builtin.objs, leading to incorrect
> output in kallmodsyms (notating things as being in modules when they
> actually cannot be built as a module at all).
>
> Automatically identified with the new tristate checker, and purged with
> sed and a subsequent make allmodconfig to double-check.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>

I can (sort of) agree with the MODULE_LICENSE(), as it duplicates the
SPDX-License-Identifier at the top.
However, you don't explain why it is a good thing to remove the
MODULE_{AUTHOR,DESCRIPTION}, too.  This is useful information, in an
easy-to-parse format.

Moreover, many of the affected drivers might be converted into modules
in the near or far future.

If the presence of these causes issues for the tooling, perhaps the
tooling can be fixed instead?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds