Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 11:49:52 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= <uwe@kleine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Peter Senna Tschudin <peter.senna@gmail.com>,
        Krzysztof =?UTF-8?B?SGHFgmFzYQ==?= <khalasa@piap.pl>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        Uwe =?UTF-8?B?S2xlaW5l?= =?UTF-8?B?LUvDtm5pZw==?= 
        <u.kleine-koenig@pengutronix.de>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 222/606] Input: synaptics_i2c - Convert to i2c's
 .probe_new()
Message-ID: <20221206114952.0323433d@endymion.delvare>
In-Reply-To: <20221118224540.619276-223-uwe@kleine-koenig.org>
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
        <20221118224540.619276-223-uwe@kleine-koenig.org>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 18 Nov 2022 23:39:16 +0100, Uwe Kleine-K=C3=B6nig wrote:
> From: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>=20
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>=20
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/input/mouse/synaptics_i2c.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/sy=
naptics_i2c.c
> index 987ee67a1045..6487c8c60d5e 100644
> --- a/drivers/input/mouse/synaptics_i2c.c
> +++ b/drivers/input/mouse/synaptics_i2c.c
> @@ -521,8 +521,7 @@ static struct synaptics_i2c *synaptics_i2c_touch_crea=
te(struct i2c_client *clien
>  	return touch;
>  }
> =20
> -static int synaptics_i2c_probe(struct i2c_client *client,
> -			       const struct i2c_device_id *dev_id)
> +static int synaptics_i2c_probe(struct i2c_client *client)
>  {
>  	int ret;
>  	struct synaptics_i2c *touch;
> @@ -651,7 +650,7 @@ static struct i2c_driver synaptics_i2c_driver =3D {
>  		.pm	=3D &synaptics_i2c_pm,
>  	},
> =20
> -	.probe		=3D synaptics_i2c_probe,
> +	.probe_new	=3D synaptics_i2c_probe,
>  	.remove		=3D synaptics_i2c_remove,
> =20
>  	.id_table	=3D synaptics_i2c_id_table,

Reviewed-by: Jean Delvare <jdelvare@suse.de>

--=20
Jean Delvare
SUSE L3 Support