Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 11:49:29 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= <uwe@kleine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        Wolfram Sang <wsa@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= 
        <u.kleine-koenig@pengutronix.de>, linux-input@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 209/606] Input: atmel_captouch - Convert to i2c's
 .probe_new()
Message-ID: <20221206114929.085b6f09@endymion.delvare>
In-Reply-To: <20221118224540.619276-210-uwe@kleine-koenig.org>
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
        <20221118224540.619276-210-uwe@kleine-koenig.org>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 18 Nov 2022 23:39:03 +0100, Uwe Kleine-K=C3=B6nig wrote:
> From: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>=20
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>=20
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/input/misc/atmel_captouch.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/input/misc/atmel_captouch.c b/drivers/input/misc/atm=
el_captouch.c
> index 156c699a8913..d9704b174d3a 100644
> --- a/drivers/input/misc/atmel_captouch.c
> +++ b/drivers/input/misc/atmel_captouch.c
> @@ -161,8 +161,7 @@ static irqreturn_t atmel_captouch_isr(int irq, void *=
data)
>  /*
>   * Probe function to setup the device, input system and interrupt
>   */
> -static int atmel_captouch_probe(struct i2c_client *client,
> -		const struct i2c_device_id *id)
> +static int atmel_captouch_probe(struct i2c_client *client)
>  {
>  	struct atmel_captouch_device *capdev;
>  	struct device *dev =3D &client->dev;
> @@ -264,7 +263,7 @@ static const struct i2c_device_id atmel_captouch_id[]=
 =3D {
>  MODULE_DEVICE_TABLE(i2c, atmel_captouch_id);
> =20
>  static struct i2c_driver atmel_captouch_driver =3D {
> -	.probe		=3D atmel_captouch_probe,
> +	.probe_new	=3D atmel_captouch_probe,
>  	.id_table	=3D atmel_captouch_id,
>  	.driver		=3D {
>  		.name	=3D "atmel_captouch",

Reviewed-by: Jean Delvare <jdelvare@suse.de>

--=20
Jean Delvare
SUSE L3 Support