Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <208ffab6-a20b-c6f0-7ea7-cb258a7c894c@kontron.de>
Date:   Tue, 6 Dec 2022 12:37:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #
Content-Language: en-US
To:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Vlim <vlim@gigadevice.com>
Cc:     Michael Walle <michael@walle.cc>,
        Victor Lim <victorswlim@gmail.com>,
        "tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
        "p.yadav@ti.com" <p.yadav@ti.com>,
        "richard@nod.at" <richard@nod.at>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "vikhyat.goyal@amd.com" <vikhyat.goyal@amd.com>,
        "amit.kumar-mahapatra@amd.com" <amit.kumar-mahapatra@amd.com>,
        "alejandro.carmona@amd.com" <alejandro.carmona@amd.com>
References: <20221204080000.4100-1-vlim@gigadevice.com>
 <dee37d18f8de5af7d07388031fc08571@walle.cc>
 <TY0PR06MB5658B73E2F22472D0AF48BDBBB1B9@TY0PR06MB5658.apcprd06.prod.outlook.com>
 <20221206091846.02f6396f@xps-13>
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
In-Reply-To: <20221206091846.02f6396f@xps-13>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGVKMkdSYTdHSC80c3pBY0dWM3JQeFRnanhJRS9UTk40QlNXTEIrQnpVaVBv?=
 =?utf-8?B?NGJWbExiRlQ1TzdyRjZJSVhiNjFlcEtMNFhGV3lwSDhmU1ZET0NpdFVvVDhl?=
 =?utf-8?B?OFBsRmxYTHVqS3dwczF0RlMvanJDMUpRSkpuc2F5TzlvSnU1WDhGaGk1VElS?=
 =?utf-8?B?T0xhbFN0NUkxekIwQXEwL1pHVk94eVdtRDVpT3B2NjEzZG9hZnRxd3hubGNN?=
 =?utf-8?B?U2FpdTFkajZiUmV6VmdFQ2FUREYyYnBrZEFCVHR3aG1NUXZPZy9lZlJTQWJK?=
 =?utf-8?B?bVlBVG16ay95eGZhaGlwYkhUV3lxUTZrRmFTY3g4NVZOVmZuTVpBcmE4VWFq?=
 =?utf-8?B?d3BrZjBQYlBRWVRPTU5Qc2hrbEtuWjZYekZwcGNwcTlFUG4vQk5tQ3dYbEpV?=
 =?utf-8?B?bCtwS1VKWnZvRjBVRG5qWi90RVNtcVpSODNPRUc3a0tyN3ZrbTFnT285Zlhk?=
 =?utf-8?B?NlZGL2tYTjY1c1J2TkdSR00xK0pGMjdMaFdWY3IzWVVSeUVhUzNWWWlnS25k?=
 =?utf-8?B?OVgreWxSMVlkSEM2c1RKVnE1ajQxSUhla1pZOEFJZ3hJU2R0cWc4MXVJS1dX?=
 =?utf-8?B?azVnZjc2RTZMNnNNOGVNSUVVeVozTkJtRDVwVzdXQ2hDYTVadkJSUk1PaHZC?=
 =?utf-8?B?bldkaFBhZWt0YUlsNno2OUp4RFNMSzUrb1I1S2dwUDhpMTRCVm5nMVhoQTRS?=
 =?utf-8?B?MXd4UXJySmQ5c0lpVnF6YUVLOXRCMVhQNG40Um9XZERUcjRoVjA4UDVsdEcy?=
 =?utf-8?B?ckdGanFOZDhYNUltYUV2U0FvbU8xTXBTZnVXdEZ4UXdrVkxRQ2VzcmZXTzVi?=
 =?utf-8?B?dUFqS1lJRFZOZFpYcENFT2xuaWxxRHZ1M0FJSExwQ1BlUnRyTTliSjBHQmZn?=
 =?utf-8?B?UEthWW5qY0hWODBCSkpaRis4VjJWVGJJM25qYldWMXF3ZlQ1bG9XemdrL2Ir?=
 =?utf-8?B?NjMvY29UNHhIVkw5UFUrbSs2Y0ZqN0pOMVN5L01MQzRHN2IvejFMeU1Ia0Zw?=
 =?utf-8?B?NWlQdzE2ZFEzWUVqZndiM0RFTHU1U3AxRkRqYno2RHVTdzdXOGJ6Ukw1emtQ?=
 =?utf-8?B?TjBtOWR6bE5xYU5ha0x2L1NGMk5CWmw0RHNIa3J5NFhhOUFPNTZmNlFSTjZP?=
 =?utf-8?B?VGZFNERWT25CM2ZCUjJKbzEwa0QycXg1aXIrZEk4N3pxRGRuRldLV0tZS01E?=
 =?utf-8?B?ODBjYWwxV0xzemtBbzI0RUlaaFpqY3BKTXFSODVXcWkySTlGcktzUUo0bmZm?=
 =?utf-8?B?YUw2K3NKd0liOVczZDV1TUVKUWowWnN5MTg5YjJLOTdKTFFLZjRTQkpON29Q?=
 =?utf-8?B?Q1RpR1pWZEpjdmZnM3lRUjBvcmlaQUoraE1kaHJjWEdSSS9yMlY4ZG9yQTR2?=
 =?utf-8?B?VmJad0dxUnEzaWYvTWhJQnp5dEN0ekh2ZGFqUlU5aW4raEtldmhCTjFoK2NW?=
 =?utf-8?B?Q0FZcVJxQWJJaEJXMUQzV2NybTFuNmZUdGt2emNzYjZtNDVpaXJNcU5GZlpy?=
 =?utf-8?B?bHJCN0Q0OHkxVm9hTG1HT21KYTVaS2l3YUE2RzExOWVpQWl6cU1EeTk1ZEpW?=
 =?utf-8?B?R3pUdmJxQ29BcGJFT2NTNENTQ0Z0WENPTUd6UVhoVmt4bGpsT0hvbEw4R0tK?=
 =?utf-8?B?RWVTeVQxM1Q2Tmx1RzB1RlFOYzAvdHM2V1F6WEh3MGpuaGd3QWF4ZHB6UWFF?=
 =?utf-8?B?Nkc1OU9rZlNoSUZYLzEybDRyS3hLWERudDlOSGN4MTA5blBzN3lMNzM0YmhI?=
 =?utf-8?B?dzFrMlFtZjAralUzM0FKNklOQVJlb3lDcExEeVppR1U5U0pZVW1BVjBSZXhi?=
 =?utf-8?B?c3ZBRkQveUF6b3VVdnJ0ODd5RmVRMWlZQi9NbEJxaHdQdmN5UVptYXNKSjNK?=
 =?utf-8?B?ZzViQkJiMGNRY3A4VHBOTEdyZzlzMFhYekhDNHpvTVUvMXFmL2ErQTJ0bnpR?=
 =?utf-8?B?UHZWSGRxY3NBOGVsbllDelMxeldJWmhNNFN5UDNCeWUzdy9JM2pBdEhHOEpZ?=
 =?utf-8?B?cTBHQ3RHZXJPYlBBNEloWmowYkZqWGFBeFhqRmZVRm5JN094dmt0L3NkZDF6?=
 =?utf-8?B?TWhDWVplVGdnYWxTVzVxUllLdnJOZHYzcFJ0ZkxVMWR2NGlwOStGbkMyYVRk?=
 =?utf-8?B?QTVmQ2Z5TVBNUTB3SXlaR0pYWmNZOTdOWWtZRkprcUtqOWpIb2RsdkpBQmpY?=
 =?utf-8?B?elE9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fe3543e-2bee-48b2-e871-08dad77e32c0
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2022 11:37:04.4638
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nmNkZQhTLWGzf5/1kcoBdVbCPGdutkWDVylGFpf8p99oIxE83Jt28BzYHRlpLGfDsWeqXIB45sk0VUAmjRStD1RxyZV3pBrDolXG1PuZEwM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PRAPR10MB5398
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06.12.22 09:18, Miquel Raynal wrote:
> Hi Vlim,
> 
> vlim@gigadevice.com wrote on Tue, 6 Dec 2022 01:27:13 +0000:
> 
>> Hi, Michael,
>>
>> I will redo the patch following this doc.
>> At the meantime, can you point out a few mistakes that I am making so that I can correct it in the next submit.
> 
> Here are a few:
> - The title is wrong (git log --oneline <file> for hints)
> - The commit log is useless
> - Don't make unrelated changes in your commit, one change == one commit
> - Don't change how the code looks like for no reason or justification
> 
> And please avoid top posting when answering.

Here are some more:

* sending (almost) the same wrong patch again ignoring feedback from
maintainers
* not using version prefixes in your subject line (PATCH v2: ...)
* not adding a changelog to your patch
* keeping your replies off the mailing list (probably your @gigadevice
address is not subscribed!?)