Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <10714595-2edf-838a-886b-30feac07ea16@kontron.de>
Date:   Tue, 6 Dec 2022 12:44:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] Linux: SPI: add Gigadevice part #
Content-Language: en-US
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
To:     Miquel Raynal <miquel.raynal@bootlin.com>,
        Vlim <vlim@gigadevice.com>
Cc:     Michael Walle <michael@walle.cc>,
        Victor Lim <victorswlim@gmail.com>,
        "tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
        "p.yadav@ti.com" <p.yadav@ti.com>,
        "richard@nod.at" <richard@nod.at>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "vikhyat.goyal@amd.com" <vikhyat.goyal@amd.com>,
        "amit.kumar-mahapatra@amd.com" <amit.kumar-mahapatra@amd.com>,
        "alejandro.carmona@amd.com" <alejandro.carmona@amd.com>
References: <20221204080000.4100-1-vlim@gigadevice.com>
 <dee37d18f8de5af7d07388031fc08571@walle.cc>
 <TY0PR06MB5658B73E2F22472D0AF48BDBBB1B9@TY0PR06MB5658.apcprd06.prod.outlook.com>
 <20221206091846.02f6396f@xps-13>
 <208ffab6-a20b-c6f0-7ea7-cb258a7c894c@kontron.de>
In-Reply-To: <208ffab6-a20b-c6f0-7ea7-cb258a7c894c@kontron.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TU1BTkZEcUpsRGVjcGlId2JIUURFMG5QKzR4QnhwMkxUemVlQ2VyVnhCeGZ0?=
 =?utf-8?B?RjBGcFJpTm5zZWVBaE50TG5XWnphRnBob3dlZGlMTkFsY0tlekpYWEtrL25R?=
 =?utf-8?B?VlczRmJvNTBaRjNyVlZiM1N5VkttZ01zQks3UzMrRmxCQkFuNk90RnFzWXFp?=
 =?utf-8?B?NXAxS3hVQ1BORFVJK1ZtQXN5bm9vN0NxeDBnbFVnTDVSQndFLzV5aERsYnVh?=
 =?utf-8?B?MFF3UHF4TENSOFRoNGVGM0xzQUlGZjFCdHR0K1FBbTRIRHhGMnppY08wZVVw?=
 =?utf-8?B?aFhtYnlkdWhmcCtLVTBzVEMxbm5scjlzQzRVeDVKc2F4aGZrTjJ1R3I0ZGxF?=
 =?utf-8?B?b0YwTVZCNkkvOE8vdEtWNkNRZ2hBOVo0dERVTVVsVXVjSUl1SVdudEZKZDJX?=
 =?utf-8?B?L3VXYld3amtWMmU0bjFtKzFodnhXMEJxb1BDRTV3QUVTQStYK0ZZeTAvTmRC?=
 =?utf-8?B?RDVwcDdnbGY2dlVEQ0Y0Q2ZjRFhWL3ByVE9EUTQvZkphK21nNWgwRDN2SlNE?=
 =?utf-8?B?VzRLYnpBZXdoNS95aWFLc0ZxR0dOV2NuZG1DVHNmNDdpTUgycytNd1hnb3NV?=
 =?utf-8?B?Mm9jY2dMeUNxQVNDVmxXZDFWSmE0UGtvY1dRSm13T1NUWTRldHVGWGUvY2pk?=
 =?utf-8?B?VlAvY213Rk9oUGxzbVczVnhuRXlUSzZ0SUJybCthRUx2N0doRytHeFRORUU5?=
 =?utf-8?B?U1c2N1g5S0U5WFl2ZnUvcDFNclk3RHdFL21jMjF2aVl1b1VsRjh1N0s0Ymhj?=
 =?utf-8?B?T1g1NGRyL1BUdHJMVlprbWRQSlVYSWc2b2FZU2VoWmYzeHJpZUkxZlE5ZnN3?=
 =?utf-8?B?RDRDa3E3V2J0WkFqZDM1WUoyRCtPOUY4WWhGa1VsQ0kxbWRnbGxaclNaOStp?=
 =?utf-8?B?UkpNd1BwUWs1MXhFK3UvMmRQNkswTUxjd2IwaTduSUFvZ04zbFhORTJNcDNs?=
 =?utf-8?B?ZGF5ZUovajM0ZEU2Z3Y1NHliK05obVAzM3FVcE9IempSbnFOajd6Ny9XdHZr?=
 =?utf-8?B?U1dBZ2IwYVQ3MGVDZDd3Sy9kcS9mZWM4cEk0TUpTZmFFYjcwMENiUDNqMzcr?=
 =?utf-8?B?L24vR3pQTndlalJFc3RCSWJvTjJPKzBzUUtxYTZvenVyaDJHSWdNNlhVb1pF?=
 =?utf-8?B?Nkh5NHl1aTVBSGtzTitMVTExQ1MxY0pieEFSN1R1TkJUaXExZGNUc3hscnFN?=
 =?utf-8?B?TlJBbnNOb2N1dUxxcmcyMWxOd3dKRXFtVDBNTGpNUkxMN2MwOWV3SVpmRjlT?=
 =?utf-8?B?U0JDdkdEdXRrZjNrdExWbWM3SEtxbm1IV0hzdHEzM1dvdEdmdmdPU091NW5T?=
 =?utf-8?B?OHVrTHY1eEJ6MUgvOTgxZjFpWmdTNTRheXNaZE9BZ25OeFE2SUhwLzNmWXlj?=
 =?utf-8?B?bjBOTG4vbngvWEgyZ2xQWXBPWi9xSlhIZlcvN2lSNWlsSmhEOVhDMEFXS3VG?=
 =?utf-8?B?VUpBS1FoV0R1M0RmUTJCdEVibTJqcU54V2RseXNibll6NVMxNEJEV080TThT?=
 =?utf-8?B?Q2JxRFRwd0owNGNieEo4NlZ2MEx5UzNINHJPQTZuZUVvWFZGVmVrbXU1V0ls?=
 =?utf-8?B?SG95Wm1TVXBNNWNOdGpOekxSZU5UaCtsMWx2YjdPaDhtclJGMVN5cERNQitM?=
 =?utf-8?B?TG8yMG5xZW9jbytDLzlEc1hFNW9YV3pGL0lNQUlMandZSjg3WHNxZm5xQXlI?=
 =?utf-8?B?QlBkaHFIa3RQWFhRQzE3L1J6R1BrWWhpVWNrQUE2WUNDNm1qNlJTYkYxU0Qx?=
 =?utf-8?B?eFlJd0JKZVJldXo4ZWdPUitLR25uQW5uZ1JZbHFIazVmekF3bCsvQzgyb2pZ?=
 =?utf-8?B?ZlE2TDJDUFV1ajE4OGpsTTAzOHpYMWRoWkc1M1E0MldUM2dIR1dIeGVJWmxo?=
 =?utf-8?B?VVBmQjNUY0NMcVZiNk5HT2VzbUZWR05WZjFBWVQwZUhha2pHMnhPQnBPUlU0?=
 =?utf-8?B?SEpwSEZwUWJOZmJ4aVBMVENYTklJcUtlQVZScWF1N1ZVVlRHMUMwTjFqbkhJ?=
 =?utf-8?B?ak9FOWpBWEVkUlpDVDN2T1J2UGVyaUY1dEZwejljSC8zSVZTcnhaekhveHlG?=
 =?utf-8?B?NFBDY3pkYjBrZ1p3Q1ZyYjJzSWZNVTBzQ1c5YlhSbG9WTHh6VDF4K2tqRFVt?=
 =?utf-8?B?U1hOczV4a1RBLzBtVHNhZTRyZ1cvKzhqdkozU0Q2QWxjanl0eXIzMlBWVUpl?=
 =?utf-8?B?TGc9PQ==?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: a592da87-954c-40e8-911c-08dad77f2d44
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2022 11:44:04.7571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s8g/mIGDUckA083wln1iHttSiQtrsAFlQ+ddZVZA1WecnPgBjFB0vwCkoZ0cCz7IIIb3AyF4aBNJWBF+BMApzQgOFL2VAyPn/mpSbaJX8fo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB3833
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06.12.22 12:37, Frieder Schrempf wrote:
> On 06.12.22 09:18, Miquel Raynal wrote:
>> Hi Vlim,
>>
>> vlim@gigadevice.com wrote on Tue, 6 Dec 2022 01:27:13 +0000:
>>
>>> Hi, Michael,
>>>
>>> I will redo the patch following this doc.
>>> At the meantime, can you point out a few mistakes that I am making so that I can correct it in the next submit.
>>
>> Here are a few:
>> - The title is wrong (git log --oneline <file> for hints)
>> - The commit log is useless
>> - Don't make unrelated changes in your commit, one change == one commit
>> - Don't change how the code looks like for no reason or justification
>>
>> And please avoid top posting when answering.
> 
> Here are some more:
> 
> * sending (almost) the same wrong patch again ignoring feedback from
> maintainers
> * not using version prefixes in your subject line (PATCH v2: ...)

The example should be like this of course: [PATCH v2] ...

> * not adding a changelog to your patch
> * keeping your replies off the mailing list (probably your @gigadevice
> address is not subscribed!?)