Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7414653rwb; Tue, 6 Dec 2022 05:36:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf64ike4B6M69q6/Yrgnv6J2xiXX4e0xVefdQq8D/gt1EhzxkvfGbYLXg0xzLGe4pstYCHZ0 X-Received: by 2002:a17:906:6403:b0:7b2:9667:241e with SMTP id d3-20020a170906640300b007b29667241emr74133504ejm.115.1670333786543; Tue, 06 Dec 2022 05:36:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670333786; cv=none; d=google.com; s=arc-20160816; b=LqbIwFPhg4WXZQ21507ZdRh1ofzDj8PtaCqLcp0ADTtsF/suJGaDksvazFR3w+dWKR iPCKc+tOTzVrm6n+1QQNLInc1o7O87GZy+VrZG91RtvzAjHyaoXp7LF6dZQDyYQkK1hy pQ4srQN1QwPyGHiIEBGLQg76HXGJefhhgqfCC+d2tm5ZzFk6Vw2iDaq07n0ooNqx/kQt SFjzXSF1RkLRiHqes3Dvedd8y4jDQTmUDqwgwdzkVHes+2WsTgOCvM/rMACDboq81xZ3 sJNmgfPjQG460uL9UlAqQwSZZPDQ4Yu0uHkz1GYPmOTlUzH51SZ89B6OePIKqlSar74G WiUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VnpjLHo/sa2cz01oNYrd1ELG111YGtUPPSMPURQFhK4=; b=EH+yldzDNKwVEq1aTSBh0R0LwNuKM0Swwpha006SbrZB2O+xDzzRSyAIs0+mRXVG9d uy1uWBJtzohdUe1y+n6Okmaxsb9VyjY52Kdjhz+ABN7fV9oFlvLX4VylJI1F0DDRP1Qk OCcmyj3iaLs5zx71ZLLNIhEHwJEY8b2h+sTrKKn0r72FVanvXNptpQDdsRll5EArCXe2 Xt1NoVzgy4Nkr+bfR/VjmN1vC1RiUYgATOQtPRWXoM2pALPmMGW1J9Br5Mo+DWSMUIkw GUr87JPxC3+rEwQQgiUu+pmFuwwGn2L54De7wu6A499caubJVfDbqqx67cUjtAOGtYtn uyZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=eJZ9nei4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn12-20020a17090794cc00b0078d4b605b71si4288504ejc.338.2022.12.06.05.36.06; Tue, 06 Dec 2022 05:36:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=eJZ9nei4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231255AbiLFNKz (ORCPT + 79 others); Tue, 6 Dec 2022 08:10:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234790AbiLFNKb (ORCPT ); Tue, 6 Dec 2022 08:10:31 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B5981A380; Tue, 6 Dec 2022 05:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=VnpjLHo/sa2cz01oNYrd1ELG111YGtUPPSMPURQFhK4=; b=eJZ9nei4Og3IjrlvXXmkRS9MZX eB7DRiCw+bbdcFxcZTrsYXsx9JcqYAnCONBCNZzxnPbz9Ril2/aguLqXLIIun0K5tu7uTLLqFJH/q EkXw+y1GiVrjDoNmOys9cTFWvuQot3pteBfQmYxGzXWSKXgGsSH4KraKYK2zFxmOw/a8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1p2Xfw-004Wo4-3K; Tue, 06 Dec 2022 14:07:56 +0100 Date: Tue, 6 Dec 2022 14:07:56 +0100 From: Andrew Lunn To: Divya Koppera Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, richardcochran@gmail.com, UNGLinuxDriver@microchip.com Subject: Re: [PATCH v5 net-next 2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR Message-ID: References: <20221206073511.4772-1-Divya.Koppera@microchip.com> <20221206073511.4772-3-Divya.Koppera@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206073511.4772-3-Divya.Koppera@microchip.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 1bcdb828db56..650ef53fcf20 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -3017,10 +3017,6 @@ static int lan8814_ptp_probe_once(struct phy_device *phydev) > { > struct lan8814_shared_priv *shared = phydev->shared->priv; > > - if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) || > - !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING)) > - return 0; > - Why are you removing this ? Andrew