Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
In-Reply-To: <202212051703254109015@zte.com.cn>
References: <202212051703254109015@zte.com.cn>
From:   Namjae Jeon <linkinjeon@kernel.org>
Date:   Tue, 6 Dec 2022 22:47:41 +0900
Message-ID: <CAKYAXd86zq=NHC56AduDaWR6yMoM1WGeJq8ThBkDy2vXRc+SOw@mail.gmail.com>
Subject: Re: [PATCH linux-next] ksmbd: use sysfs_emit() to instead of scnprintf()
To:     ye.xingchen@zte.com.cn
Cc:     sfrench@samba.org, senozhatsky@chromium.org, tom@talpey.com,
        linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

2022-12-05 18:03 GMT+09:00, ye.xingchen@zte.com.cn <ye.xingchen@zte.com.cn>:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  fs/ksmbd/server.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ksmbd/server.c b/fs/ksmbd/server.c
> index a0d635304754..b0da15377709 100644
> --- a/fs/ksmbd/server.c
> +++ b/fs/ksmbd/server.c
> @@ -433,7 +433,7 @@ static ssize_t stats_show(struct class *class, struct
> class_attribute *attr,
>  		"shutdown"
>  	};
>
> -	ssize_t sz = scnprintf(buf, PAGE_SIZE, "%d %s %d %lu\n", stats_version,
> +	ssize_t sz = sysfs_emit(buf, "%d %s %d %lu\n", stats_version,
>  			       state[server_conf.state], server_conf.tcp_port,
>  			       server_conf.ipc_last_active / HZ);
It would be great if you remove sz variable and return it directly.

Thanks.
>  	return sz;
> --
> 2.25.1
>