Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Divya.Koppera@microchip.com>
To:     <andrew@lunn.ch>
CC:     <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <richardcochran@gmail.com>,
        <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH v5 net-next 2/2] net: phy: micrel: Fix warn: passing zero
 to PTR_ERR
Thread-Topic: [PATCH v5 net-next 2/2] net: phy: micrel: Fix warn: passing zero
 to PTR_ERR
Thread-Index: AQHZCUVX+xhZw8rF5EesOiBOrBuDqa5g1PgAgAAJjpA=
Date:   Tue, 6 Dec 2022 13:45:12 +0000
Message-ID: <CO1PR11MB47713C125F3D0E08B7A6A132E21B9@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20221206073511.4772-1-Divya.Koppera@microchip.com>
 <20221206073511.4772-3-Divya.Koppera@microchip.com>
 <Y48+rLpF7Gre/s1P@lunn.ch>
In-Reply-To: <Y48+rLpF7Gre/s1P@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jl+go87NskpPsWY5OWjuoIFwW4VGCm/mwLEYx5cJWiYkCuG1xMzxXDzW0Yl3?=
 =?us-ascii?Q?+FzeNAmd9GQqMM/a5CY7VBtWlgt0QLLeqBQ+9T1PixL/OCEdYsiZhxTzMKNv?=
 =?us-ascii?Q?t2Zp8Q4gf4nNZtAv5Lq2as5KXYL6kHXV6kUoEG31nQC7qAlcswRZKft2bthS?=
 =?us-ascii?Q?xo1O6nQYFok9pqkn03RIx8/nuKu2PJNckEHDvRrCakuVL2RxeBtqDi+bahNo?=
 =?us-ascii?Q?Erw8M/tC95pWqTJhk9W9GR0IiejPmy5VW7a4URZ84RYOwlEGaxyTAKQ2a3Lf?=
 =?us-ascii?Q?3z5KvnAJPFjt048WeIVN8wdXszxARLS+CsaduDABN4jPaPre31JWIJhKGm2r?=
 =?us-ascii?Q?LdcZlFFjugu7mZvKUE6YBMQ2s/O7YkDhmCrjcZqnLzpCK3y+co20AZGYRWRI?=
 =?us-ascii?Q?JBL2mfKOR0BHldR3BTdxdQsiQaIxIg39yroDbMohncQ7yyOPun5NkQW3jWR7?=
 =?us-ascii?Q?POR6lNip1LqUA9Ytzn7GMFXxtigRPcGrLIcIdnGcOyBrFp8LNuY11YbHbYbn?=
 =?us-ascii?Q?omYv0CYxMFUcSpLzgSKHeu2eanWGXDbyiqsd4WcRJ+6yp+tbHnnwG+wQ+vwv?=
 =?us-ascii?Q?fFh2iZvPsk14MPNrpDCBOtBtXYTuVy8JBoyIvng/WLqlSJkvisAPrZ3lG3g2?=
 =?us-ascii?Q?NHYHgpr/BHk/jJn3eq58FtZAdaHInODadUkrP5wHD/qnvLhf7y/FEQEXNlhw?=
 =?us-ascii?Q?u0i6TEndIhpOobLnvNlAb8t74kwGM7zvxk5QfIVQo88MNpOU5xOZUtJ3ETiM?=
 =?us-ascii?Q?yK+vTi4+a845Fm8MtTRMAavdNJlXYcJeI+1rYooXUzM3s+Orb8N1W1WfLv+H?=
 =?us-ascii?Q?OlhFLlFGRJGFUWalpWwiKWttTS4fLMZdiflwaANFkrL8A61y6KkjKs2jzzgS?=
 =?us-ascii?Q?oD64acOjtQvnJZG7etxDvnWH6OgpYtOrCua0RJCnbwRY3g1xaDWwj2We5vHG?=
 =?us-ascii?Q?4QFHppi7/4d8tk5zBJ14mCjCcKRa5DvfRlySE/QXUxfYuzgKk/xRY652bvaL?=
 =?us-ascii?Q?ZKH5DTl5sM04f+OvjZddmrr1y5FTcTd2MFvLTuDEOlSrkAakj7yxo/SVW5mY?=
 =?us-ascii?Q?9t93u3l1MuP8a5p5TR0N7MgQ/qleFSh2kq4QklcH8qNtWPlkoND214d5PdXO?=
 =?us-ascii?Q?658DRkoGAC7bHLQ+R0Ic7K7RrSjl2D2hOjBvaEkOwsaEx0NlXMXIJL2D9W3z?=
 =?us-ascii?Q?Hppt8aEo5+LlHBv2swRJqObbSu0MjnaWI2TavGCVMCLB+vYaIILW+Rv/A2w5?=
 =?us-ascii?Q?25iX9x2HdK2npN8x1ngZCkuwwMZYMLDwF7B7puB3PZnBW9b4nzfs9vEdhyl8?=
 =?us-ascii?Q?kmnkzlx5TlUvfTBWlhUYGvhTINPZrzu1uB/JMrASc7C6ZIrZxU+hQxZ7Y58y?=
 =?us-ascii?Q?6rVJuGF96G3DuVk45kc6rGs9nN49hHNqsqZjW2YXUh1I0JlGaTj52FDLwELT?=
 =?us-ascii?Q?EYFOC3hT+W4W4+aNDaeQYuN8FLbX8HsF+YExb9iZGQyfPxllisslJp+KbC5n?=
 =?us-ascii?Q?onrvOy7D8AMcMh9xcK2TsPLLYg3WmH5MLw4sxrwE7vFDG+6ZX2JFFCQ9JDM7?=
 =?us-ascii?Q?Yno7L+GeRxCIOUyFdcQ33Ps2bzccfgm7kwQXf/pOQwhS7m4JactYxBYShi9q?=
 =?us-ascii?Q?Gg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fe4059a-470a-43ad-ccfd-08dad7901918
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 13:45:12.2196
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tlPFHtbrKk6TWRBOg9Lo7qMzph1Mgb6yq/QRBlLxDsChOXgmSlLOf1IypUemlj99Ds6FL0EALaUwWUfO8dSSmy4CRF725B/CbN0wo5enY7I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7531
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, December 6, 2022 6:38 PM
> To: Divya Koppera - I30481 <Divya.Koppera@microchip.com>
> Cc: hkallweit1@gmail.com; linux@armlinux.org.uk; davem@davemloft.net;
> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
> richardcochran@gmail.com; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>
> Subject: Re: [PATCH v5 net-next 2/2] net: phy: micrel: Fix warn: passing =
zero
> to PTR_ERR
>=20
> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index
> > 1bcdb828db56..650ef53fcf20 100644
> > --- a/drivers/net/phy/micrel.c
> > +++ b/drivers/net/phy/micrel.c
> > @@ -3017,10 +3017,6 @@ static int lan8814_ptp_probe_once(struct
> > phy_device *phydev)  {
> >       struct lan8814_shared_priv *shared =3D phydev->shared->priv;
> >
> > -     if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) ||
> > -         !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING))
> > -             return 0;
> > -
>=20
> Why are you removing this ?
>=20

I got review comment from Richard in v2 as below, making it as consistent b=
y checking ptp_clock. So removed it in next revision.

" > static int lan8814_ptp_probe_once(struct phy_device *phydev)
> {
>         struct lan8814_shared_priv *shared =3D phydev->shared->priv;
>=20
>         if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) ||
>             !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING))
>                 return 0;

It is weird to use macros here, but not before calling ptp_clock_register.
Make it consistent by checking shared->ptp_clock instead.
That is also better form."

>     Andrew