Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 15:08:59 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Divya.Koppera@microchip.com
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        richardcochran@gmail.com, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v5 net-next 2/2] net: phy: micrel: Fix warn: passing zero
 to PTR_ERR
Message-ID: <Y49M++waEHLm0hEA@lunn.ch>
References: <20221206073511.4772-1-Divya.Koppera@microchip.com>
 <20221206073511.4772-3-Divya.Koppera@microchip.com>
 <Y48+rLpF7Gre/s1P@lunn.ch>
 <CO1PR11MB47713C125F3D0E08B7A6A132E21B9@CO1PR11MB4771.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CO1PR11MB47713C125F3D0E08B7A6A132E21B9@CO1PR11MB4771.namprd11.prod.outlook.com>
Precedence: bulk

> > > -     if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) ||
> > > -         !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING))
> > > -             return 0;
> > > -
> > 
> > Why are you removing this ?
> > 
> 
> I got review comment from Richard in v2 as below, making it as consistent by checking ptp_clock. So removed it in next revision.
> 
> " > static int lan8814_ptp_probe_once(struct phy_device *phydev)
> > {
> >         struct lan8814_shared_priv *shared = phydev->shared->priv;
> > 
> >         if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) ||
> >             !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING))
> >                 return 0;
> 
> It is weird to use macros here, but not before calling ptp_clock_register.
> Make it consistent by checking shared->ptp_clock instead.
> That is also better form."

O.K. If Richard said this fine.

Just out of interest, could you disassemble lan8814_ptp_probe_once()
when CONFIG_PTP_1588_CLOCK is disabled, with and without this check?

My guess is, when PTP is disabled, the mutex still gets initialised,
all the member of shared->ptp_clock_info are set. The optimise cannot
remove it. With the macro check, the function is empty. So you end up
with a slightly bigger text size.

       Andrew