Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7578688rwb; Tue, 6 Dec 2022 07:27:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf7X886MZQLp5fbfPBPNa5AgRjIsK5tkjaqtlHhEQ3b/MMZQjJobRajFq4z+apLCRJQMkMw3 X-Received: by 2002:a63:ec46:0:b0:456:5024:e6ae with SMTP id r6-20020a63ec46000000b004565024e6aemr61214919pgj.466.1670340433517; Tue, 06 Dec 2022 07:27:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670340433; cv=none; d=google.com; s=arc-20160816; b=UdEA/VjKgd/YvvKsXhKp68kO41svG4/m8k9p2WlEVD0ZORzzNm0aXNxVFSw/juyObg TYyyU7OIgm6i4hMoOeqCrhVYPZ2N6FIVpha5zGDIhcw1wE8uy3YUcW6Nfny+IDdLz2N2 dtKZN/57lgNoNpMbKFjdN1SjwE+7mP/gENxJ8uyA1hwWNiOfD6t/IcJaM1ln6YObI4/W 0TJ0wbxUB7njBrKo1jMnriw+NdZgNHjwM/X/YFawCNKX8vmeLs6Segy6fQ/lo7c04f1l 0kJ+DW/dRWL67HYz5mrodeZB60iOewXtj97x4b4v3hMLGsIGDixuOglT73A4qhFex6pV s/Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=sYNx+BVuKE1r95pjrng1v5C0q8o1J61qvP35cXPV5OM=; b=wR1W6RBxsGyaObIwSEWcqC3BgfEMTG2XNb82cMrIqk75/3YeSa5FFfVddKV8rumtlL 1a5ZNJcAvQ4VshuKZXBktXP28vPhOjwISiSNJkPYaYREVMcb/ccTdPEVsSF6J6GTcXzP eZbduDs1Zm8ikVMmjilqjGMH6nuhF+PTvmJq1CjG0Cvf5mcXkDQAkrH0vbctpMh4iCOS fSOgNOBGWth7mpS//sqRPzgIpKA8mHPKuQ5lCA3814JJHUrZt9SYCMgj98Rc4mPp+uuN HQG/ma2FMMAXWMDrbDSTnMZf+92pmTgd7vmK7wOcxdHAe8PFVij3Tv17G7pjbTF5G9Ww 2LTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ijN4fQwf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t6-20020a170902e84600b00186ba56bda8si19053379plg.61.2022.12.06.07.27.02; Tue, 06 Dec 2022 07:27:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ijN4fQwf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234420AbiLFPRY (ORCPT + 78 others); Tue, 6 Dec 2022 10:17:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234839AbiLFPQt (ORCPT ); Tue, 6 Dec 2022 10:16:49 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE5BAE59; Tue, 6 Dec 2022 07:12:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670339556; x=1701875556; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=UQPpoMYHgojZ0s9I/vYi4H/g6UU0D10ansdSCf8jK0c=; b=ijN4fQwf305Hp7GZB8DInTtwuofxS3O635wJ86UrZ6X36WoPvuXP0lwr B7xE2OdFwYoi3ByN4Wq98ekykg3IiO0wVQjReMFHQb1NjpuFJle7szdQ6 ezZJMZU00ti5Cvvp9TALL7W7+IrQbUBZMGT/zPxl7toGKhSPkfWAnZHmk mnAYizn98lODQ5hl/WX2jZ9zZC341lIK6Goz52xyQuIIKV/Fv7EiMxsBA W3TPit80AJH6NXf19SWRi3uzmN+2hmkZSxj9Sl3m1lYbndSndGxrkUBDm Yx9x3mwgbVC9KjV0RQYgUxeKG4+XlVQQgcMeouKloRRO3LprcHThVE4ri g==; X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="378807875" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="378807875" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2022 07:12:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10553"; a="639904605" X-IronPort-AV: E=Sophos;i="5.96,222,1665471600"; d="scan'208";a="639904605" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 06 Dec 2022 07:12:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p2ZcB-005MBU-0N; Tue, 06 Dec 2022 17:12:11 +0200 Date: Tue, 6 Dec 2022 17:12:10 +0200 From: Andy Shevchenko To: ye.xingchen@zte.com.cn Cc: jic23@kernel.org, michael.hennerich@analog.com, lars@metafoo.de, u.kleine-koenig@pengutronix.de, jk@codeconstruct.com.au, wsa@kernel.org, ddrokosov@sberdevices.ru, hdegoede@redhat.com, haibo.chen@nxp.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: accel: Convert to use sysfs_emit_at() API Message-ID: References: <202212061953201070549@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202212061953201070549@zte.com.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 06, 2022 at 07:53:20PM +0800, ye.xingchen@zte.com.cn wrote: > From: ye xingchen > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. Please split on per device driver basis (3 patches here). The code looks fine to me, thanks. -- With Best Regards, Andy Shevchenko