Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7579563rwb; Tue, 6 Dec 2022 07:27:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf7ui7lEvqocTnf71ZxTeOv5j9uVNFpvI0MNC6fIHf+JTL33tBekPf2n1Va31lp3F/i/ljTP X-Received: by 2002:a63:ef07:0:b0:476:aad3:9121 with SMTP id u7-20020a63ef07000000b00476aad39121mr61460292pgh.385.1670340472925; Tue, 06 Dec 2022 07:27:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670340472; cv=none; d=google.com; s=arc-20160816; b=PdGvqTm7Rn3bp8RoxYsSu85Q6lVJ6/YlSDaWOa3Y0xlgQ8xy20vtmIaJ/lZomZqyks sGSqWQolEzmfd2WlYnp7CxybqCHLs7UAKvWujEEYLHfJRaiHtvvcz/2OFQIqiyHyVPDV Ibp9bnu62/xM9hDFMYjHCwPrhkohzJqV8wm7uf0+GvZtfaegQCcWnvxZ4iFT4eViU9dj rU2g088sx+EXQennI0X5rNGJk0dr2HfR/Xb79Umf/fkCcrTQb6STgkBiDmnUsqTvRRSL ZQRzHFZKYCw9bpvQjqE6ylpDOa3ZmmaUImkg3tCdVM4E6QXKX0IT9b6hpx9tpHfnMbmr fwvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rUQ0Yi7h5oKAZQZsn5qDOcoTsdQyJ1MXEu0Lp2m5E1I=; b=E1h8VIuH4aW/icy2f3s7LrrYR7rb4JhiamSz5m9cOdorfQ85D4NulrohXaXSPM52FC H0dZZ+wc6V4gfl6vfg7GxB7n6/sDqLfwOW32hmDs9+0dWMkuHWsvf+tDy2+qk96GNyZ2 ZRbVa6oBUN+qOn75PtohE0yctxugEnOOuFzRhcIYw6aDG+FoMQx3lUp0ovpT0nBCnVgD uzaUYGqlFmQGsoSVR6It8QdFD3ym1rx4/hYroOMGJVenwPULYLYkbH5fE/gH4kZWy4tO pOwjHofTO2wfQ6Cu/kkBK8dBpdsv1MVJBMJyhjRraKuHgrnkNCmEHbnidZEA5nC8vIln LhZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mailserver.it header.s=mailsrv header.b=HDqTFZns; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p34-20020a635b22000000b00473c36e3b75si17592801pgb.608.2022.12.06.07.27.42; Tue, 06 Dec 2022 07:27:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mailserver.it header.s=mailsrv header.b=HDqTFZns; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235306AbiLFPNs (ORCPT + 78 others); Tue, 6 Dec 2022 10:13:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235255AbiLFPN0 (ORCPT ); Tue, 6 Dec 2022 10:13:26 -0500 Received: from smtp-out-06.comm2000.it (smtp-out-06.comm2000.it [212.97.32.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19D2025EB1; Tue, 6 Dec 2022 07:09:38 -0800 (PST) Received: from francesco-nb.int.toradex.com (31-10-206-125.static.upc.ch [31.10.206.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: francesco@dolcini.it) by smtp-out-06.comm2000.it (Postfix) with ESMTPSA id 036F1561D45; Tue, 6 Dec 2022 16:08:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailserver.it; s=mailsrv; t=1670339317; bh=blplQwq9EdejH0j4HSUbXC84gL4g/wQ7bOQGXQm2ZIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HDqTFZns+v1o07uzn0Tr81LA3IhfJtL5s+LbVA//nNWqe8lfCz/+qpqNqxIpiBLWH n6H38VUpBHYApIzgAVRtAkni8olKmTpmEecUbzPKSGxeXYGg5UI4Zc2LQZMAszlUeZ JDaaGgB4xiviTghjBdhYK68cKfkRagXUvBFXrYojQwpyYpJ5nDX5RpTJsnhiab+96L wLHe+mMBLihLpnXJRi1vfaRWYCupnXOQ4UZyIeBnxwuYMkljnacsLZWTokoRgk4Jx4 LR9IixSrz0ZHpR8yjxy5ZcJzpiRI3Pvs9594LG2SS5Ej996o8qJr14KUhqfUm+09Sd djCQD6Its67SA== Date: Tue, 6 Dec 2022 16:08:24 +0100 From: Francesco Dolcini To: Francesco Dolcini Cc: Sherry Sun , gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com, lukas@wunner.de, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, Fabio Estevam , max.krummenacher@toradex.com Subject: Re: [PATCH] Revert "serial: fsl_lpuart: Reset prior to registration" Message-ID: References: <20220929085318.5268-1-sherry.sun@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 06, 2022 at 03:52:07PM +0100, Francesco Dolcini wrote: > Hello all, > > On Thu, Sep 29, 2022 at 04:53:18PM +0800, Sherry Sun wrote: > > This reverts commit 60f361722ad2ae5ee667d0b0545d40c42f754daf. > > > > commit 60f361722ad2 ("serial: fsl_lpuart: Reset prior to registration") > > causes the lpuart console cannot work any more. Since the console is > > registered in the uart_add_one_port(), the driver cannot identify the > > console port before call uart_add_one_port(), which causes all the uart > > ports including the console port will be global reset. > > So need to revert this patch to avoid breaking the lpuart console. > > > > Signed-off-by: Sherry Sun > > What's the status/plan on this? whoops, already solved in 76bad3f88750 ("tty: serial: fsl_lpuart: don't break the on-going transfer when global reset")