Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 17:20:01 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/11] can: tcan4x5x: Specify separate read/write
 ranges
Message-ID: <20221206162001.3cgtod46h5d5j7fx@pengutronix.de>
References: <20221206115728.1056014-1-msp@baylibre.com>
 <20221206115728.1056014-12-msp@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vhdmre27vzom3pem"
Content-Disposition: inline
In-Reply-To: <20221206115728.1056014-12-msp@baylibre.com>
Precedence: bulk


--vhdmre27vzom3pem
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 06.12.2022 12:57:28, Markus Schneider-Pargmann wrote:
> Specify exactly which registers are read/writeable in the chip. This
> is supposed to help detect any violations in the future.
>=20
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
>  drivers/net/can/m_can/tcan4x5x-regmap.c | 43 +++++++++++++++++++++----
>  1 file changed, 37 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/net/can/m_can/tcan4x5x-regmap.c b/drivers/net/can/m_=
can/tcan4x5x-regmap.c
> index 33aed989e42a..2b218ce04e9f 100644
> --- a/drivers/net/can/m_can/tcan4x5x-regmap.c
> +++ b/drivers/net/can/m_can/tcan4x5x-regmap.c
> @@ -90,16 +90,47 @@ static int tcan4x5x_regmap_read(void *context,
>  	return 0;
>  }
> =20
> -static const struct regmap_range tcan4x5x_reg_table_yes_range[] =3D {
> +static const struct regmap_range tcan4x5x_reg_table_wr_range[] =3D {
> +	/* Device ID and SPI Registers */
> +	regmap_reg_range(0x000c, 0x0010),

According to "Table 8-8" 0xc is RO, but in "8.6.1.4 Status (address =3D
h000C) [reset =3D h0000000U]" it clearly says it has write 1 to clear bits
:/.

> +	/* Device configuration registers and Interrupt Flags*/
> +	regmap_reg_range(0x0800, 0x080c),
> +	regmap_reg_range(0x0814, 0x0814),

0x814 is marked as reserved in "SLLSEZ5D =E2=80=93 JANUARY 2018 =E2=80=93 R=
EVISED JUNE
2022"?

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--vhdmre27vzom3pem
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmOPa60ACgkQrX5LkNig
0112+Af7BOqOSxIaDypn/eWvKpPXDEoWBJDRw//U96c0zVlAJIAbGwHFlK07FXrJ
HERKtcMv6hvZV8qzrUyLKN7yM7APgHcCLZyhHKNLyubvODjMfDhhda5BvhEik6SK
eS2vYXnifaGtzDvgekNO17wQGxZ7WI1dm8XxjJ2+SXWXJ3lMHtp+F0zrBZW1heTr
P8Vd+RyvfMJzB1NHBFBLAaLSmCzJUCzhRhDyhiBgZ5Wc0rdVsSLJ7wGhbe6/yi4i
O8/XV+iUYWUUxryL/AzbdVlVvA5tA/fTGBw0n2LMEVNcS2u8Evead947Er4JoQD4
cuLUlD6on7FIGKdmV+c+wcEP4fSaNA==
=jsBQ
-----END PGP SIGNATURE-----

--vhdmre27vzom3pem--