Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Jerry.Ray@microchip.com>
To:     <linux@armlinux.org.uk>
CC:     <andrew@lunn.ch>, <f.fainelli@gmail.com>, <olteanv@gmail.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v2 2/2] dsa: lan9303: Move to PHYLINK
Thread-Topic: [PATCH net-next v2 2/2] dsa: lan9303: Move to PHYLINK
Thread-Index: AQHZBoLNizWF/vluhkC5EP67e3Seoa5bAs2AgAYVDfA=
Date:   Tue, 6 Dec 2022 16:48:11 +0000
Message-ID: <MWHPR11MB16936F7BBE2130CA9821B8FAEF1B9@MWHPR11MB1693.namprd11.prod.outlook.com>
References: <20221202191749.27437-1-jerry.ray@microchip.com>
 <20221202191749.27437-3-jerry.ray@microchip.com>
 <Y4pX//cG2Hq8NvbM@shell.armlinux.org.uk>
In-Reply-To: <Y4pX//cG2Hq8NvbM@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vNC9Rs1BN4i529br/YdqUjl2RgSCsIf9jAbXmnQrGWqqrP6moOge0O1i2Ieb?=
 =?us-ascii?Q?lxS9gdeO7M6L7S8LQEWMg4qjrb6XYhMCNFx3z1rCJ773mrL3G6WhMFr1Xyg/?=
 =?us-ascii?Q?D0hlPWD3cFZCQyMpB7ftHNDNWWhowiFG2xJPeLCyyJfluIkd9fXMcZuVnTvf?=
 =?us-ascii?Q?Fq40HkKIXOPP8pnGO1OUb2T9pG4qMaFDctP1ndWUzqdQI2n6xQz6kUouIa9X?=
 =?us-ascii?Q?Iot3zLBrBKsJOaZpujoEcKjmVRXumtHEq6zZKLoJDOYERU2opqC28FJ5eoLu?=
 =?us-ascii?Q?ogNU3MaxDkMYEt2MkCw6RPXib8XK1Gudr8gCN3kAEXaNoe0Zm9Mvzyk94BSo?=
 =?us-ascii?Q?gGV3DojPI/qLtEFbCBDoDYuLiu38gQSE4ce7pdl7zV3fHaZyO0GAP7XZXOou?=
 =?us-ascii?Q?Of97TE2IN9kbDZpVVKL4CziXR8F6fjxOY1dwc0DZofLp1xaFAlS/TssuNocl?=
 =?us-ascii?Q?/k2djEngrTs9ThP6jGvnUIEQ4CEuVM58KdzoqltpffKyHXQ8VT3JGeO+JMZu?=
 =?us-ascii?Q?+SWr0Pf3WTvdijZIhmGM2s4ObRMQ8Ns75qtXdWNdg1Qm7LCtMTo1D5RcsGvj?=
 =?us-ascii?Q?sFxaGpUj0+u3rpouhgqbZjZ1AIqDfBOrH9IiJEgWcD+K8cvEfJpLH3ineEAV?=
 =?us-ascii?Q?9mesljczk4xR8J3W3f9HwE4AcmPi0CLBvH4YU+9FWWeuWQO+ADAQz18RfsGa?=
 =?us-ascii?Q?KugPfUIwbSUww/Fcj5ZH3gFDZ68IDIGhvlosMEeM7oevQ8MwvHwQaAVbgvqx?=
 =?us-ascii?Q?l2KoYlK3GNhzZiY9OYmdh9MWu2Meo9k5Ab1m93VvFxCohLfWtwzw6WoDxy9a?=
 =?us-ascii?Q?LPTaTiRC4yEk8yajRowmEtZcMdGAGOsA6g7ABQn+OW5z9DVZ2qt8bemCgNov?=
 =?us-ascii?Q?ADqe77Al7twm/DCtYGoCC8q3loWvxMCZG65zg8Rvi0HeT8rMnhKMvTgl9bzY?=
 =?us-ascii?Q?E54gGVs6JwXRP+ZY3z+TOjzdJuFt0CgQx1Qu8n2BU6tVL1Tn0ZcljXaIM9tx?=
 =?us-ascii?Q?ZtLvrQLNj6ZgEb2FtxADButJ3LscIm5rCsdoWPz6VaT/p4Ir15I/jRu0jQFu?=
 =?us-ascii?Q?R+NJ/VsseLABHhO6epCMVq2i51It/l0PtTGAu8zHets+lG5u6cuFNa35Uazx?=
 =?us-ascii?Q?8tE5wwVdM3EPC7RlB7+10Xe0Wb4O8nEBGunSwZJy7pIjcjm7E0Me4rkCkxyj?=
 =?us-ascii?Q?0Ha75ZigRjuoBRAkxPhc8xHBvz3VmlTMhPZk3/qv4+t4zuqyx29AyvUuwaQk?=
 =?us-ascii?Q?+nzaB5DxNlkpxhq5proSfpLoIlfOiCYEhPbQJcbmXfeeohKk429nii3Wpp0P?=
 =?us-ascii?Q?WVNjlo4lpf8myF9VCs+RXpA2ck3Ka55sEr5TzLE7VLDTLDOcA4L7bpCdlHif?=
 =?us-ascii?Q?BkuDztvB3tkUMJXAPwUOt3U4WUoqGqhKfrvvK7EUu+cAD96vrZQGJXU9grgR?=
 =?us-ascii?Q?/wnwf/bfFrRbhRnENIrirKzmXzp1G/88I8k64PunnVJJxDpEiNg+sQaOv3gI?=
 =?us-ascii?Q?WI81ledqUnTovBcxVf8k3QQ00XJdCpNWPV+mcyWMkM56o2N79YtpdubYMV+K?=
 =?us-ascii?Q?xXMINjF40cQWKdzDKMi143olgEzsLrIvlCtyPq/O?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1693.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d819e2a6-4ab8-4b1e-a41a-08dad7a9a984
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 16:48:11.9364
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: h/6YV5AZaKgblYBbKHt8LzCZ3ZNvB1VZNe9mp4RwwePozvvUcdpjivyxjDq4PIvmCz7au+MsW5WdHYu5WKsYLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5493
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> -static void lan9303_adjust_link(struct dsa_switch *ds, int port,
>> -                             struct phy_device *phydev)
>> -{
>> -     struct lan9303 *chip =3D ds->priv;
>> -     int ctl;
>> -
>> -     if (!phy_is_pseudo_fixed_link(phydev))
>> -             return;
>> -
>> -     ctl =3D lan9303_phy_read(ds, port, MII_BMCR);
>> -
>> -     ctl &=3D ~BMCR_ANENABLE;
>> -
>> -     if (phydev->speed =3D=3D SPEED_100)
>> -             ctl |=3D BMCR_SPEED100;
>> -     else if (phydev->speed =3D=3D SPEED_10)
>> -             ctl &=3D ~BMCR_SPEED100;
>> -     else
>> -             dev_err(ds->dev, "unsupported speed: %d\n", phydev->speed)=
;
>> -
>> -     if (phydev->duplex =3D=3D DUPLEX_FULL)
>> -             ctl |=3D BMCR_FULLDPLX;
>> -     else
>> -             ctl &=3D ~BMCR_FULLDPLX;
>> -
>> -     lan9303_phy_write(ds, port, MII_BMCR, ctl);
>> -
>> -     if (port =3D=3D chip->phy_addr_base) {
>> -             /* Virtual Phy: Remove Turbo 200Mbit mode */
>> -             lan9303_read(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, &ctl=
);
>> -
>> -             ctl &=3D ~LAN9303_VIRT_SPECIAL_TURBO;
>> -             regmap_write(chip->regmap, LAN9303_VIRT_SPECIAL_CTRL, ctl)=
;
>> -     }
>> -}
>
>Is this functionality no longer necessary? For example, I don't see
>anywhere else in the driver that this turbo mode is disabled.
>
>I'm guessing the above code writing MII_BMCR is to force the
>configuration of integrated PHYs to be the fixed-link settings?
>How is that dealt with after the removal of the above code?
>

While it should be disabled by the HW config strap settings, I'll add
disabling Turbo Mode into the initialization sequence to keep the driver
operation consistent.

>> -
>>  static int lan9303_port_enable(struct dsa_switch *ds, int port,
>>                              struct phy_device *phy)
>>  {
>> @@ -1279,6 +1243,41 @@ static int lan9303_port_mdb_del(struct dsa_switch=
 *ds, int port,
>>       return 0;
>>  }
>>
>> +static void lan9303_phylink_get_caps(struct dsa_switch *ds, int port,
>> +                                  struct phylink_config *config)
>> +{
>> +     struct lan9303 *chip =3D ds->priv;
>> +
>> +     dev_dbg(chip->dev, "%s(%d) entered.", __func__, port);
>> +
>> +     config->mac_capabilities =3D MAC_10 | MAC_100 | MAC_ASYM_PAUSE |
>> +                                MAC_SYM_PAUSE;
>> +
>> +     if (dsa_port_is_cpu(dsa_to_port(ds, port))) {
>> +             /* cpu port */
>> +             phy_interface_empty(config->supported_interfaces);
>
>This should not be necessary - the supported_interfaces member should
>already be zero.
>
>Thanks.
>

Yes, I agree.  I'll remove it.

Regards,
J.