Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3c3a7b0c053c5366be4ad0c4a9a3bd205aaea731.camel@ndufresne.ca>
Subject: Re: [PATCH] media: videobuf2: add V4L2_BUF_FLAG_HEADERS_ONLY flag
From:   Nicolas Dufresne <nicolas@ndufresne.ca>
To:     Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Ming Qian <ming.qian@nxp.com>, mchehab@kernel.org
Cc:     shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Tomasz Figa <tfiga@chromium.org>
Date:   Tue, 06 Dec 2022 12:46:57 -0500
In-Reply-To: <34d5c5d7-cedd-a12c-557b-33274f62cf70@xs4all.nl>
References: <20220712093754.23370-1-ming.qian@nxp.com>
         <15ba9b9e-f3f6-7f30-c200-d7c9593a4735@xs4all.nl>
         <35256805b1ce0b2b7533f53f658c799a37255469.camel@ndufresne.ca>
         <34d5c5d7-cedd-a12c-557b-33274f62cf70@xs4all.nl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

Le mardi 06 d=C3=A9cembre 2022 =C3=A0 10:05 +0100, Hans Verkuil a =C3=A9cri=
t=C2=A0:
> > For decoders, if a a decoder is in "separate mode", it seems that sendi=
ng
> > headers must happen this way. If this uses a separate path internally, =
the
> > kernel needs also to be aware which buffers are what (and we don't pars=
e in
> > the
> > kernel). In very basic case, the driver assume that the first buffer af=
ter
> > streamon is a header, but that prevents resolution changes without a
> > drain+flush, which android and chromeos folks seems to use. (I always d=
rain
> > and
> > flush for what I'm doing).
>=20
> OK, thank you for the explanation.
>=20
> So if this is going to be added, then existing drivers that use
> V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE have to be adapted to use the new fl=
ag
> as well.
>=20
> From what I can tell those are the mediatek vcodec, venus and s5p-mfc
> encoders.
> I suspect/hope that it won't be too difficult to add this new flag there.

The exercise will also be very informative for the reviewers, so yes, I wou=
ld
ask Ming to update all the drivers, though its fine to only compile test th=
is=20
and leave it to the maintainers to verify (at least that's my opinion). I d=
on't
see this change as a break, as any existing userspace will just ignore this=
, and
maybe managed to support it by deep parsing (which will keep working).
Otherwise, existing userspace using this mode have been broken for
renegotiation, and that change will not deteriorate (nor improve) the end
result.

Nicolas

>=20
> Regards,
>=20
> 	Hans