Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 12:30:58 -0600
From:   Bjorn Andersson <andersson@kernel.org>
To:     Alex Elder <alex.elder@linaro.org>
Cc:     Alex Elder <elder@linaro.org>, sboyd@kernel.org,
        mturquette@baylibre.com, konrad.dybcio@linaro.org,
        agross@kernel.org, Luca Weiss <luca.weiss@fairphone.com>,
        dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
Message-ID: <20221206183058.rsws5ciqa2u5q7oj@builder.lan>
References: <20221202221240.225720-1-elder@linaro.org>
 <20221205225646.gtwhakd4lxh6vlfc@builder.lan>
 <39903fb5-fd28-c159-b300-47d3ec4cd0fc@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <39903fb5-fd28-c159-b300-47d3ec4cd0fc@linaro.org>
Precedence: bulk

On Mon, Dec 05, 2022 at 09:05:30PM -0600, Alex Elder wrote:
> On 12/5/22 4:56 PM, Bjorn Andersson wrote:
> > On Fri, Dec 02, 2022 at 04:12:40PM -0600, Alex Elder wrote:
> > > From: Luca Weiss <luca.weiss@fairphone.com>
> > > 
> > > The IPA core clock is required for SM6350.  Define it.
> > > 
> > > [elder@linaro.org: rebased with Dmitry's changes]
> > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> 
> Sorry about that, I knew I was supposed to sign
> off and thought I had.
> 
> You told me separately that this was sufficient:
> 
> Signed-off-by: Alex Elder <elder@linaro.org>
> 
> If you want me to send a new version with the
> signoff just let me know.  Thanks.
> 

That works fine, thank you.
Bjorn

> 					-Alex
> > 
> > Thanks for rebasing this Alex. But as you're handling the patch you need
> > to add your S-o-b; which will make sure your [] makes sense as well.
> > 
> > Regards,
> > Bjorn
> > 
> > > ---
> > > v2: This is now based on qualcomm/for-next.
> > > 
> > >   drivers/clk/qcom/clk-rpmh.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c
> > > index 2c2ef4b6d130e..586a810c682ca 100644
> > > --- a/drivers/clk/qcom/clk-rpmh.c
> > > +++ b/drivers/clk/qcom/clk-rpmh.c
> > > @@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
> > >   	[RPMH_LN_BB_CLK3_A]	= &clk_rpmh_ln_bb_clk3_g4_ao.hw,
> > >   	[RPMH_QLINK_CLK]	= &clk_rpmh_qlink_div4.hw,
> > >   	[RPMH_QLINK_CLK_A]	= &clk_rpmh_qlink_div4_ao.hw,
> > > +	[RPMH_IPA_CLK]		= &clk_rpmh_ipa.hw,
> > >   };
> > >   static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
> > > -- 
> > > 2.34.1
> > > 
>