Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nick Alcock <nick.alcock@oracle.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     mcgrof@kernel.org, masahiroy@kernel.org,
        linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        linux-kernel@vger.kernel.org, arnd@arndb.de,
        akpm@linux-foundation.org, eugene.loh@oracle.com,
        kris.van.hees@oracle.com
Subject: Re: [PATCH v10 05/13] kbuild: remove
 MODULE_LICENSE/AUTHOR/DESCRIPTION in non-modules
References: <20221205163157.269335-1-nick.alcock@oracle.com>
        <20221205163157.269335-6-nick.alcock@oracle.com>
        <CAMuHMdVrP1sLGRS999q=2L-5JhxXwcjBLkQREdcJhDerg70OtA@mail.gmail.com>
Emacs:  no job too big... no job.
Date:   Tue, 06 Dec 2022 20:03:05 +0000
In-Reply-To: <CAMuHMdVrP1sLGRS999q=2L-5JhxXwcjBLkQREdcJhDerg70OtA@mail.gmail.com>
        (Geert Uytterhoeven's message of "Tue, 6 Dec 2022 10:11:08 +0100")
Message-ID: <87mt80l2py.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NkIY+RsYla+lY1ice+W4fsXYRJutaNfZqQyxQjcd5IaacTBLpgwa2f/pDeP5?=
 =?us-ascii?Q?1zcWP7BLLV5aXDz80fWa/Si/wmtJ6FOCM+4lNabqwe/HX4Bjez57cwVvWmcP?=
 =?us-ascii?Q?ntHTfmIXhblMahXIh6u8a48Z7ID87fG6Q5rV3OOi1SVmuYlejlHJjqnVQgVs?=
 =?us-ascii?Q?r3sPKuVlZAloYdatqDO0bqjYoHRPjZUBpkhUGW692YSYWr0nuMJ4H6H0cPYh?=
 =?us-ascii?Q?Pcy4Dv1hNVIPRHLQ/xwgpi/U4D9YvQdWkcbogFtx1fW20MwsROgenJX93bqI?=
 =?us-ascii?Q?CQPd0j8kDA6a66UHtjpIM/u3Y5DYP5VWl2RsyYlJIZWFfsza/IYb0dqT7vbZ?=
 =?us-ascii?Q?pzLv8cSuGEvwGppaOoztz60wRPZxXvNB/Kq4E5HiMbpxDRC5PWgxxIJvqYGl?=
 =?us-ascii?Q?OPPJcx6FgFZfMlPKdzV/pUidqu4wAxRQ436H93PocyicSF+0wY27EuHdnM7B?=
 =?us-ascii?Q?PPOChBgo2TW0mgYSzLMjtImR8+DGGOFLaBed1TaGgo6uuhFbNBZjyVUVOLfQ?=
 =?us-ascii?Q?RGGS5d2xY76SS93gBBzcgBpB97juIxs5OfXOovSZyIvRkHPA1e9VwMwC847g?=
 =?us-ascii?Q?ct941RfsG9M1itMUDq97wy+wPLkDpfahI9yzQTbnMvmr6JpfeAuz8a+k3wKJ?=
 =?us-ascii?Q?+ZttAwx3uhzp3RvSw9O4h7HsakY4uq72wbx7eVCmQyVatBj/L17+bzxafAoV?=
 =?us-ascii?Q?WO0r+zCVOMGylnFVT/Mf/ysPNgiduVIYYZdocGjG6wqNnMu2f+0t2z6RWm20?=
 =?us-ascii?Q?eLXHYUzSGT991dy00fVSa44m79+e5+JCMSOjHlTdvvdyIl2j3okC1aGEWs+g?=
 =?us-ascii?Q?Edes8G2yBgivRuX1qjfFWjGAk0SP+dFcKTFnU5pLpk2Q2qYNhI5F43V0htFx?=
 =?us-ascii?Q?rmpHFrN/tbvzHqFQMXTLOpAIDIk1Gk8VIaEUa3p7MlC0Sys2e0/Ks4VlM61G?=
 =?us-ascii?Q?L/aFg7uxv1L7wmIwxT23A4gw0aIu6Bu3JNj7RFRROEd/dQ45qUhqZKzew/uh?=
 =?us-ascii?Q?K+vt17NQiNttxuiXhvUqsW+7wTUeJ+adNEGEZU9rjUtft7nkD7g1wnhvfZzP?=
 =?us-ascii?Q?fJ5azfQpEswftl71j2yA26rruxJW0yG8Swy9nUc9n4uCY4L5RweK+zlK73k6?=
 =?us-ascii?Q?NvFK1jyFc/GZQ0caV+Sm1sdImgkk9gAUCJuACglrIy6v+LEuiHVGsHT8jtZR?=
 =?us-ascii?Q?alNYaDOzgpecjAaIrN924xEjefjHdn0YY9mP36Vnww1VpDfKRpR5EJN7elNq?=
 =?us-ascii?Q?VZhTTEUqiPHgo8mXaSppIJK9c364soaUeRroD8zJlq94qmfPwewHQaCcySMi?=
 =?us-ascii?Q?pALWO0eW0x3bnL/SMRIOqYpkCdDMJ6piKOoSlIabdLxggpYCsgk1vG2tkTa5?=
 =?us-ascii?Q?OCoBfIZBixyvmgxhiNPPKL1zpcf3STdgeY8wOjtrhQgT7IWQ+0mJeqm6z4Tu?=
 =?us-ascii?Q?oAR2Ub1wAuBAn4OMovkRoGMGreef8MYbVcNjcRfgVovdjPMHGmfZa3Zd9FXk?=
 =?us-ascii?Q?NZVoO06wveCfrgYgW+XSf4qF8aBJukSJdMYIUkESIOgLuXsHcNiFGb9D4LIB?=
 =?us-ascii?Q?inhQ/+6HA8+Ypf9jpXR60QJsQlwvxosVl+DswkX8ocvDJExNy+n3hRgPCDlZ?=
 =?us-ascii?Q?+A=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?BxAx8yvLlnaytpsG6nTNPgHeVMXSgzuWQGLjp7eOBZp9QuvrbHlDOC7kFmlJ?=
 =?us-ascii?Q?woj8Dt0PCd+qqKWy7wtM46OqcLikrH3a0w1zwe060wp1Xtdhfwb7K8fyQpzM?=
 =?us-ascii?Q?ZEPrN6/yhihPztuS3a7ijf73oaublbFIdbOOQGUmeRXd48xWeL8mGvglPtIu?=
 =?us-ascii?Q?TwVPBDfgbJlIdMPLtI/WWccndT7FVKZNNXTn0NAIOajDTZPkDzPcQBeH0X4i?=
 =?us-ascii?Q?wMwG80a4tV/PqlbV0J71i6qwaDB1uGsen/tvTHOOEyrQa54Yj+WMrqhJqjPE?=
 =?us-ascii?Q?2TtXu46QYDEzK4AIOt9ZO6S9v3Pf0L5/dSR0hZjorvoMNMzT44m0hGDU7YXQ?=
 =?us-ascii?Q?+3hXUOiv3DuGkiZK26oIao8f5U4LZgqgs/eAtvsWn98qY0ZSVfM9wLiLIjWc?=
 =?us-ascii?Q?9rbJ5L5JJu3ajm8R6wrYzKTdTkfH/XAXSqcOztRZ6WHCo5YgOt02wPLqJ9e4?=
 =?us-ascii?Q?ZbQttuSE960Dn8ijFvawDnNUqUaBHg6FQnDF1JfVrcyVZQD6CZEVGnyqjhUY?=
 =?us-ascii?Q?p8fNBmhDFbhEdcrcraJMJgVf5ZK36wJaeHpwTQ/cJnEfsQh3efAsCj7qUw8p?=
 =?us-ascii?Q?5QxvevUMYIg3SjtST2OAGGN9qjQ7n/XiuxqH1ejydPx/DQg+I0axFzP3BBbN?=
 =?us-ascii?Q?VMHY9Afs2ZUpWLKSOBHgkh8MSmKp+in+XJi5j5ayFur2znMWu153uzO+2n5a?=
 =?us-ascii?Q?vSYkOB4SDO/1ljAhV2IEu7dJuRTg0uiDWorAU68mS5Ju80CL1xW7wIBNegYq?=
 =?us-ascii?Q?srb0eM0n4o+hoBX2Yz908QIIXNZei/HNRYVv2zKh34tHvaw8QbLqN0kkuyGo?=
 =?us-ascii?Q?IcTmEdJOQA07HA16SvVJbRUHH1HLIG9DcNXVxQc5wH/h8nIWZL7AP6rTI4US?=
 =?us-ascii?Q?u7D6ALa6orVElZlVi2M00JFXa7Dy8iRVmlPphHS4Q0Nl3ADXRASSxDZ7um+Y?=
 =?us-ascii?Q?E/7ABs3rpk7gRjp+l9I0K+v4tm9jdQucmU70gwqrgfx1eRd+xBIJl0tpihzN?=
 =?us-ascii?Q?4MLQOxyhutlQE23FrlEAmO9Fww=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc50f776-f883-47d7-2420-08dad7c4e620
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2022 20:03:10.3274
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aspjyDMWjQ1QvqX0iYDEJf8BNsJEvdpDwHfOYWwtEF/BAxpPMSrWtLTHuOKzqUHS3VDBH8uun1E8Feh3oq8jlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7271
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-06_11,2022-12-06_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2212060168
X-Proofpoint-ORIG-GUID: RG71rR1O5fYNrF05VKiiKP6tQUa-ZoU6
X-Proofpoint-GUID: RG71rR1O5fYNrF05VKiiKP6tQUa-ZoU6
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6 Dec 2022, Geert Uytterhoeven uttered the following:

> On Mon, Dec 5, 2022 at 5:34 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations in
>> non-modules will cause modprobe to misidentify their containing object
>> file as a module when it is not, which might cause it to spuriously fail
>> when trying to load something that is built in to the kernel.  They
>> also cause misconstruction of modules.builtin.objs, leading to incorrect
>> output in kallmodsyms (notating things as being in modules when they
>> actually cannot be built as a module at all).
>>
>> Automatically identified with the new tristate checker, and purged with
>> sed and a subsequent make allmodconfig to double-check.
>>
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>
> I can (sort of) agree with the MODULE_LICENSE(), as it duplicates the
> SPDX-License-Identifier at the top.
> However, you don't explain why it is a good thing to remove the
> MODULE_{AUTHOR,DESCRIPTION}, too.  This is useful information, in an
> easy-to-parse format.

I was concerned about that, but I kinda thought they went together and
it would be neater to take them out in one go -- but I'd be happy to
keep them in and only drop MODULE_LICENSE.

> Moreover, many of the affected drivers might be converted into modules
> in the near or far future.
>
> If the presence of these causes issues for the tooling, perhaps the
> tooling can be fixed instead?

Only MODULE_LICENSE invokes MODULE_FILE and thus ends up introducing a
KBUILD_MODOBJS entry that triggers things going wrong iff not a module:
so only it needs to go out (or be replaced with a variant that doesn't
invoke MODULE_FILE, if you want to keep the license in too -- but if the
thing is no longer a standalone entity at all I'm not sure what meaning
it could possibly have).

-- 
NULL && (void)