Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 21:39:47 +0100
From:   Samuel Thibault <samuel.thibault@ens-lyon.org>
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        kbd@lists.altlinux.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/3] VT: Add height parameter to con_font_get/set consw
 operations
Message-ID: <20221206203947.5yifmkntf4uy7lt6@begin>
Mail-Followup-To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        kbd@lists.altlinux.org, linux-kernel@vger.kernel.org
References: <20221205000739.583233140@ens-lyon.org>
 <20221205000807.751605665@ens-lyon.org>
 <27ade063-79df-dad9-0427-e16f1ddb43ef@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <27ade063-79df-dad9-0427-e16f1ddb43ef@kernel.org>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
Precedence: bulk

Jiri Slaby, le mar. 06 déc. 2022 07:40:30 +0100, a ecrit:
> On 05. 12. 22, 1:07, Samuel Thibault wrote:
> > --- linux-6.0.orig/drivers/usb/misc/sisusbvga/sisusb_con.c
> > +++ linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
> ...
> > @@ -1268,7 +1271,7 @@ sisusbcon_font_get(struct vc_data *c, st
> >   	}
> >   	/* Copy 256 chars only, like vgacon */
> > -	memcpy(font->data, sisusb->font_backup, 256 * 32);
> > +	memcpy(font->data, sisusb->font_backup, 256 * height);
> 
> Have you tested this?

Ah, no, I had assumed that this was for a specific arch. But actually I
wasn't getting it because it depends on BROKEN.

> What does this 'height' refer to?

It was meant to be vpitch actually, I will fix it.

Samuel