Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead
Mime-Version: 1.0
Message-Id: <5f0a5ea7-2d48-435f-aaa0-82b6ef8cfcc5@app.fastmail.com>
In-Reply-To: <87mt80l2py.fsf@esperi.org.uk>
References: <20221205163157.269335-1-nick.alcock@oracle.com>
 <20221205163157.269335-6-nick.alcock@oracle.com>
 <CAMuHMdVrP1sLGRS999q=2L-5JhxXwcjBLkQREdcJhDerg70OtA@mail.gmail.com>
 <87mt80l2py.fsf@esperi.org.uk>
Date:   Tue, 06 Dec 2022 22:02:30 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Nick Alcock" <nick.alcock@oracle.com>,
        "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc:     "Luis Chamberlain" <mcgrof@kernel.org>,
        "Masahiro Yamada" <masahiroy@kernel.org>,
        linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "Andrew Morton" <akpm@linux-foundation.org>, eugene.loh@oracle.com,
        kris.van.hees@oracle.com
Subject: Re: [PATCH v10 05/13] kbuild: remove MODULE_LICENSE/AUTHOR/DESCRIPTION in
 non-modules
Content-Type: text/plain
Precedence: bulk

On Tue, Dec 6, 2022, at 21:03, Nick Alcock wrote:
> On 6 Dec 2022, Geert Uytterhoeven uttered the following:
> Only MODULE_LICENSE invokes MODULE_FILE and thus ends up introducing a
> KBUILD_MODOBJS entry that triggers things going wrong iff not a module:
> so only it needs to go out (or be replaced with a variant that doesn't
> invoke MODULE_FILE, if you want to keep the license in too --

That sounds like a better alternative

> but if the thing is no longer a standalone entity at all I'm not sure
> what meaning it could possibly have).

As far as I can tell, the general trend is to make more things modules,
so there is a good chance that these come back eventually. If the
information in the MODULE_LICENSE field isn't wrong, I would just
leave it in there.

    Arnd