Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Jerry.Ray@microchip.com>
To:     <linux@armlinux.org.uk>, <olteanv@gmail.com>
CC:     <andrew@lunn.ch>, <f.fainelli@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next v3 2/2] dsa: lan9303: Move to PHYLINK
Thread-Topic: [PATCH net-next v3 2/2] dsa: lan9303: Move to PHYLINK
Thread-Index: AQHZCaGINo+jcYxyBkCe7T6HFT6Y065hP+WKgAAadQCAAB4zwA==
Date:   Tue, 6 Dec 2022 22:58:25 +0000
Message-ID: <MWHPR11MB1693565E49EAB189C2084C58EF1B9@MWHPR11MB1693.namprd11.prod.outlook.com>
References: <20221206183500.6898-1-jerry.ray@microchip.com>
 <20221206183500.6898-1-jerry.ray@microchip.com>
 <20221206183500.6898-3-jerry.ray@microchip.com>
 <20221206183500.6898-3-jerry.ray@microchip.com>
 <20221206193224.f3obnsjtphbxole4@skbuf>
 <Y4+vKh8EfA9vtC2B@shell.armlinux.org.uk>
In-Reply-To: <Y4+vKh8EfA9vtC2B@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/exvHGzSrxT1+ro9cN9CQ8WTSH9b7Ji13sdluWekRnAf7IUw+TWGri87okTu?=
 =?us-ascii?Q?kxqqiyoCU6bCnuUbsKQ2UTYAfg4g6ibPT2bdJMosGSDH+eHY1+1Dc0BYhS76?=
 =?us-ascii?Q?gzU2aHzd0fSGuuuNzutKFxGDGisAvvgO5015FF805ncZ0t55YEALO6H/qaOE?=
 =?us-ascii?Q?JuQI/XYm2UNvO+8l8a/dDmZYaLTkOyL2Nbyl4yVLiMqj1yqv/QGUFTw1mT05?=
 =?us-ascii?Q?2U9knck2zXQLItE1ju5e6a4YPqpRIU/8/UcbnLICVzMlNzv7rEWutJM6wwnf?=
 =?us-ascii?Q?L2hR55Kwe+9QebqVCTUfKftbjzdJlEEIpFfmSny1tUraiC66Ex8/A/xN7XY1?=
 =?us-ascii?Q?ClhlWlbm0cdMnB+bXpjGGsUcmTA+vlushWpAkOwPpz9tRQqHpqJAVzh8KOL/?=
 =?us-ascii?Q?mbtlu0Jk76uinlA4PUIC9TP3srbTBr63qOJCH7eLSRbFbYv38INEKXLcEFQT?=
 =?us-ascii?Q?okCUa5fR7OdWAvppA/1OUL+GyFyDtEWfIQZIX0qCtWctksuLPGQaZitRarLm?=
 =?us-ascii?Q?h4Yd+z7vKFfxA2wFJ1pxko8gm/Coa4Xqa3KuKKxCi3uS2d3JdM0Zub+x7Q2X?=
 =?us-ascii?Q?dYC9bJbFVZTeke8fKDZn9FNWgzKejkGWCPzZmzczJq9DZsVgQ7kJoRat64iO?=
 =?us-ascii?Q?y8NoKnDxMGBNwCrlmMp4CFERKmRCdjbL6+D8qf+0e+gRZiQh+S2SwsN1Twxo?=
 =?us-ascii?Q?IJoXQ2Z3A7ERMfCag4uqevVatZwSr4PH8nLAhS2FpCOnIaa324h5DwdUZvou?=
 =?us-ascii?Q?5N5gWVV2PXx3bAXD1cKfOOl2GBd6anvZdDtE7vD+96q0wH9ymNM/lZnz91rv?=
 =?us-ascii?Q?HpQeneeIdkLEqlJyvOAVx7Qs9iph+HQ2MHTrt2NJHNKG6Pxp2i5JDvNb6m9m?=
 =?us-ascii?Q?e+q+Uh2+FxNmV6sVnnIRU/WUzsZ+B1K7ZrnRmd5veCzR0q41VqbPvmhAGU/e?=
 =?us-ascii?Q?BS32zVl+ujhbXOV/bK0ZsinAX1nKM0R0ZMdXa2T0+rZ1s57aEbkhlYKhwelh?=
 =?us-ascii?Q?vN74f05gRfZxHl05f2AFSCMazTcioN+uwpjimLnA+DnfLLm7t0p+I2lH8Emp?=
 =?us-ascii?Q?/ObCQkgpg1ES6j9SGrhx2BYUPUtA8DM98tPltaO+1iPZqtJ1P7t+JY0aO1Bm?=
 =?us-ascii?Q?dctWEv2hnond/XbXwle6qvpB6Pg3E2j0PRi8aG92XeI1oecqeWgwXwYqsLoU?=
 =?us-ascii?Q?eB0cA+fvh3+OdtvP8UB/m7Tg8WmE7Wo+pYvSSiJgTpEBZqN6obFjqN1Ljrt+?=
 =?us-ascii?Q?x9yuX8/NiNUpS2fI3N8XFCPpEhC4GSJhoPsJyAnEvEQ6V2gPH8WG9OEc9lrv?=
 =?us-ascii?Q?TFHPUE6VjQ4c0SYSmQa8U5dGJiTlu+mBzaQsJYEvSK+e0ET5YGuUo6yrNykr?=
 =?us-ascii?Q?DmramEyo/WuRfX87ErjY5Df4ZwICiFAg2Yka04uoFgcCuOcG65xFuhNzJ483?=
 =?us-ascii?Q?y7m+ndkhMP/7OT5R/QV2a+fPkxzciog6sTxZdx+FoZ+dSDUk56xGlPsZqg9t?=
 =?us-ascii?Q?nxw5lh3UCZzdrGQvrrcQnZHasRdNwIT4QVc+SNla53B9093JiJEF4xcxE1ko?=
 =?us-ascii?Q?P3mPY4viU0JUSyNK6lWMpL+Uu3jShpCgIH/JL7Jc?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1693.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 289ed66a-e3d1-4be4-7b43-08dad7dd61a4
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 22:58:25.2103
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qbTXixxsbA55i286LQsftBuobFdm5LUemSI9sAlQHP1GGFgT3yXOB5rLQnRjZob5Tx21UYh6h/F0eGAvklqCDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5800
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > > This patch replaces the .adjust_link api with the .phylink_get_caps a=
pi.
> >
> > Am I supposed to read this commit description and understand what the
> > change does?
> >
> > You can't "replace" adjust_link with phylink_get_caps, since they don't
> > do the same thing. The equivalent set of operations are roughly
> > phylink_mac_config and phylink_mac_link_up, probably just the latter in
> > your case.
> >
> > By deleting adjust_link and not replacing with any of the above, the
> > change is telling me that nothing from adjust_link was needed?
>=20
> ...
>=20
> > > -static void lan9303_adjust_link(struct dsa_switch *ds, int port,
> > > -                           struct phy_device *phydev)
> > > -{
> > > -   struct lan9303 *chip =3D ds->priv;
> > > -   int ctl;
> > > -
> > > -   if (!phy_is_pseudo_fixed_link(phydev))
> > > -           return;
>=20
> If this is a not a fixed link, adjust_link does nothing.
>=20
> > > -
> > > -   ctl =3D lan9303_phy_read(ds, port, MII_BMCR);
> > > -
> > > -   ctl &=3D ~BMCR_ANENABLE;
> > > -
> > > -   if (phydev->speed =3D=3D SPEED_100)
> > > -           ctl |=3D BMCR_SPEED100;
> > > -   else if (phydev->speed =3D=3D SPEED_10)
> > > -           ctl &=3D ~BMCR_SPEED100;
> > > -   else
> > > -           dev_err(ds->dev, "unsupported speed: %d\n", phydev->speed=
);
> > > -
> > > -   if (phydev->duplex =3D=3D DUPLEX_FULL)
> > > -           ctl |=3D BMCR_FULLDPLX;
> > > -   else
> > > -           ctl &=3D ~BMCR_FULLDPLX;
> > > -
> > > -   lan9303_phy_write(ds, port, MII_BMCR, ctl);
> >
> > Are you going to explain why modifying this register is no longer neede=
d?
>=20
> ... otherwise it is a fixed link, so the PHY is configured for the fixed
> link setting - which I think would end up writing to the an emulation of
> the PHY, and would end up writing the same settings back to the PHY as
> the PHY was already configured.
>=20
> So, I don't think adjust_link does anything useful, and I think this is
> an entirely appropriate change.
>=20
>=20

I, too, thought I would need phylink_mac_config and phylink_mac_link_up to
completely migrate away from PHYLIB to PHYLINK.  But it seems as though the
phylink layer is now taking care of the speed / duplex / etc settings of th=
e
phy registers.  There is no DSA driver housecleaning needed at these other
phylink_ api hook functions.  At least, that's my current level of
understanding...