Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Jerry.Ray@microchip.com>
To:     <olteanv@gmail.com>
CC:     <andrew@lunn.ch>, <f.fainelli@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux@armlinux.org.uk>
Subject: RE: [PATCH net-next v3 1/2] dsa: lan9303: Add port_max_mtu API
Thread-Topic: [PATCH net-next v3 1/2] dsa: lan9303: Add port_max_mtu API
Thread-Index: AQHZCaGGUS2s+i6LNUmfdfFZp/Wl6a5hNZMAgABQdTA=
Date:   Tue, 6 Dec 2022 23:44:58 +0000
Message-ID: <MWHPR11MB16930878ED42D3F4CC95A015EF1B9@MWHPR11MB1693.namprd11.prod.outlook.com>
References: <20221206183500.6898-1-jerry.ray@microchip.com>
 <20221206183500.6898-2-jerry.ray@microchip.com>
 <20221206185616.2ksuvlcmgelsfvw5@skbuf>
In-Reply-To: <20221206185616.2ksuvlcmgelsfvw5@skbuf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jArNnY7wGNOTQcQ6lD23JJAJjjo+j77Jk939ZNUgGVqwhZ4AoiJvK46kVH5H?=
 =?us-ascii?Q?uCJyoWyXo9Gv13d1OWdYoE9aGzOW9bxuK1cLGU1yika/emDe+iYFbSfbmZ8r?=
 =?us-ascii?Q?M2mQXsewbZSPFL7Jg2dkXWUNMAquroJjfF0rnN55OkOeCv7MxNAkcSBgn4bf?=
 =?us-ascii?Q?/pGnJoGXgjJvWQ/YDqDSi06Jpk1T/stJ3bAppOfp/GbRLcArsWIhh7pUFnrp?=
 =?us-ascii?Q?WBy13bk2z9Vd2ePuhWbPVMJltewvywlP1c80dwGGiq/OMScgcPR42akSWecE?=
 =?us-ascii?Q?zBzgOHuIPREMD8AaWrb2KE9rjOEBTBsPo36OAlUi6U2j9AsZROLITsEvoCN1?=
 =?us-ascii?Q?6y00VBCQIQSso3Sfq7scc3U23Fb3r6Rv0Of7lZqI0yFuCdFAQDh99m3SbBZ/?=
 =?us-ascii?Q?NTJrlRDAq5v8Wm9R65MvHlZzAISDPeg02Qh92kFTaCqHvQ1Px4CbrQb5SgA3?=
 =?us-ascii?Q?xKqjN1VNka6moz47i2xVyCt6ETNB1ee3w4nKojtVUYDwxRSynuEN0wUNaVwM?=
 =?us-ascii?Q?J6w0dc4Va0+2CClhksBLxwukGqO1QoRC3MwEWpaD9LlqT5db8TIRVpNHftFP?=
 =?us-ascii?Q?qruBSo4xzbLULb+Tr1BGKJ0CpBTtiCw+byQd6C227e5Sha0qsBjCRUjnKmW2?=
 =?us-ascii?Q?S5qClPxHHmR568ycT1p0nVn38ZXvlInbwenKNYDECvWXvUctAKAptZoHowVm?=
 =?us-ascii?Q?1wr9BKKu4Khph0RAIfihxsXeiSl8akcOX0Myvu01J5f91A7LwaUUsML3HgEZ?=
 =?us-ascii?Q?hsR2bBX6ec0FiwTseFyRQtr6y5w8FSMkzlCEU/Z9p2m7CJlJQ9e0439q3YJV?=
 =?us-ascii?Q?bWZLvwsLFpI2g+HsLYY1/poFFgR+fjV+gae1xxDHJbP9LYUU5BzlDCkvLfzK?=
 =?us-ascii?Q?3RDbef5IPGz/9BoX/N7iBB9X+hM4lO/mHvbKiIiRquqkncezoo5JT6B7pSYm?=
 =?us-ascii?Q?tqrPloEv+mUONdiZt8WBw006T78f6d4H0G/8pJcVlHnNbb8naSGRBGx+JZsd?=
 =?us-ascii?Q?u9GC9xv8PO25BNtL5SKm+dw4VzFSvUDGKh69vQZCP1FiWm1fWpfWWDH65GAQ?=
 =?us-ascii?Q?Ik3AuXxacXKAWBfBN8xCGW62SF366l1M8Ac2aGtyIAvcN+NAmS4Ep10+0L9Q?=
 =?us-ascii?Q?hTK0a5HfqeO5OB1ueh2cJuxFRg0RBCJnmxBSiNDWQbA3/4ZBZdfipPjS/fV9?=
 =?us-ascii?Q?g5OhZmGflJwfFoE6mJ5mKAMaj4rkn6fe3IP/N8lPtFkzR1cElmfAP+DOqFVe?=
 =?us-ascii?Q?Hpa4LU/Sh/YbhFK1xYvU03TtA3SkkniTYTEeRKXa4yf/emf/EFMo1Wce+2NN?=
 =?us-ascii?Q?vgGWAIlYvBJoTy03i0XbO4KscKlKN/HImzeITxPOvRftrQyq1yHI9lB9hGap?=
 =?us-ascii?Q?IA2mLXSrfCC6xLxcQj5V/7AW7sg2jiQKJcxweEWhD7Z/A95k3O8+h5slhNNf?=
 =?us-ascii?Q?yUDm0Z1D9c8S5o/DYLGYPOLhfevC0EPr6daj6wZ1cpF/JdwY2WDi/iDhkS0d?=
 =?us-ascii?Q?TzFJ5EznfFF9J3vNaNDOKMfnK5zfiUUTh6wdp6p+f69d79vyv5tptenZnGad?=
 =?us-ascii?Q?xvPKj7ZOcDflNc92kRDPkJMovXahkXgaDG1FRu1R?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1693.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62ecb261-8a46-4c4b-ab34-08dad7e3e274
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 23:44:58.2878
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: TAHeiVlk4oOgSAs/Rx7UJ0F9oAPOW9p5xfsNao9kEMWAyG20HUqNHX7VV4d6qF5ors9+1eOOxkSYBK+1Alp/rA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5868
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +/* For non-cpu ports, the max frame size is 1518.
> > + * The CPU port supports a max frame size of 1522.
> > + * There is a JUMBO flag to make the max size 2048, but this driver
> > + * presently does not support using it.
> > + */
> > +static int lan9303_port_max_mtu(struct dsa_switch *ds, int port)
> > +{
> > +     struct net_device *p =3D dsa_port_to_master(dsa_to_port(ds, port)=
);
>=20
> You can put debugging prints in the code, but please, in the code that
> you submit, do remove gratuitous poking in the master net_device.
>=20
> > +     struct lan9303 *chip =3D ds->priv;
> > +
> > +     dev_dbg(chip->dev, "%s(%d) entered. NET max_mtu is %d",
> > +             __func__, port, p->max_mtu);
> > +
> > +     if (dsa_port_is_cpu(dsa_to_port(ds, port)))
>=20
> The ds->ops->port_max_mtu() function is never called for the CPU port.
> You must know this, you put a debugging print right above. If this would
> have been called for anything other than user ports, dsa_port_to_master()
> would have triggered a NULL pointer dereference (dp->cpu_dp is set to
> NULL for CPU ports).
>=20
> So please remove dead code.
>=20

I've written the function to handle being called with any port.  While I
couldn't directly exercise calling the port_max_mtu with the cpu port, I di=
d
simulate it to verify it would work.

I'm using the dsa_to_port() rather than the dsa_port_to_master() function.

I'd rather include support for calling the api with the cpu port. I didn't
want to assume otherwise.  That's why I don't consider this dead code.

> > +             return 1522 - ETH_HLEN - ETH_FCS_LEN;
> > +     else
> > +             return 1518 - ETH_HLEN - ETH_FCS_LEN;
>=20
> Please replace "1518 - ETH_HLEN - ETH_FCS_LEN" with "ETH_DATA_LEN".
>=20
> Which brings me to a more serious question. If you say that the max_mtu
> is equal to the default interface MTU (1500), and you provide no means
> for the user to change the MTU to a different value, then why write the
> patch? What behaves differently with and without it?
>=20

I began adding the port_max_mtu api to attempt to get rid of the following
error message:
"macb f802c000.ethernet eth0: error -22 setting MTU to 1504 to include DSA =
overhead"

If someone were to check the max_mtu supported on the CPU port of the LAN93=
03,
they would see that 1504 is okay.

> > +}
> > +
> >  static const struct dsa_switch_ops lan9303_switch_ops =3D {
> >       .get_tag_protocol =3D lan9303_get_tag_protocol,
> >       .setup =3D lan9303_setup,
> > @@ -1299,6 +1318,7 @@ static const struct dsa_switch_ops lan9303_switch=
_ops =3D {
> >       .port_fdb_dump          =3D lan9303_port_fdb_dump,
> >       .port_mdb_add           =3D lan9303_port_mdb_add,
> >       .port_mdb_del           =3D lan9303_port_mdb_del,
> > +     .port_max_mtu           =3D lan9303_port_max_mtu,
> >  };
>=20

Regards,
Jerry.