Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 16:18:40 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        willy@infradead.org, almasrymina@google.com, linmiaohe@huawei.com,
        hughd@google.com, tsahu@linux.ibm.com, jhubbard@nvidia.com,
        david@redhat.com
Subject: Re: [PATCH mm-unstable v5 01/10] mm: add folio dtor and order setter
 functions
Message-ID: <Y4/b4DNO6dWDMXZ/@monkey>
References: <20221129225039.82257-1-sidhartha.kumar@oracle.com>
 <20221129225039.82257-2-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221129225039.82257-2-sidhartha.kumar@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NWOxx6juRO2Nv1/kTRE8MmKzGXH1EF2FvFdQzhENrTb+lGfwxQKB6hBRKoaY?=
 =?us-ascii?Q?SDTz3RCsvWpK69XNsesVNDVCUDZ4koop0QHITt3qYYZPwCwxkZUTCla+prtB?=
 =?us-ascii?Q?rxlqUyxzcJjoyHe4Vuv9p6Vhwo+Kgj+3aTiFTdicarledudN6a7mTzW3j9CP?=
 =?us-ascii?Q?IClehfbSUxro9VcsJbgLzn95/oZLKl+wQkeOUU3DMq/0A8izOpeD8lEPObGR?=
 =?us-ascii?Q?mwXo368flNTAJOj/eMtr3GRPl/Kpu7uemruHOuoST536/W9BEnEt66SxSjSN?=
 =?us-ascii?Q?ElYVF8tk/9mbRvL8vqkZNP8r6nwHFX7KZ9LGxqu3jG/mgen6t4mF++cYUHsU?=
 =?us-ascii?Q?5SVKgQKPq9qBwjUMm+3qfa5SdKZWqUdvDXhCzSDTUCWCzKEC9Q7R3xgXlhl3?=
 =?us-ascii?Q?oUUweFDEA5lPHw/D56qSBmzH6JPprCinE31chEzHqo2ZfvtsPEl/K+SWSqTE?=
 =?us-ascii?Q?01c6lWWFjwHY0feVXpb/kU3bKGdWeZPj1MbrPV4z8y/gHwenF7ssDWYtRvYv?=
 =?us-ascii?Q?WiCpZbwe9pDua9L8P2zOuKBZX0Mg2pu5TgzSb69axy6XGr1YvNr3BPCUTiGH?=
 =?us-ascii?Q?7oqNby5qsvGUvf1OTOH5wNyjf1UnanXPYl/6XBLD2TEK0DjBO4Yib85RUf2i?=
 =?us-ascii?Q?TEyrPppN7cZcDxKabKrvsspmGWcNBJCIzXCYP6bPK67dj/aNhF72cVxvKoeV?=
 =?us-ascii?Q?kp8m1Gl75sjJpWB3KVIU6+87ZRTaDZsX2SXd7o2a4CJDlP4kn0EyvWgJYL04?=
 =?us-ascii?Q?yoiGHVSTGuRiOYSULo9MHau7EYlxa9ttrxCquH0OvwQvT+Hob8rI4KAloOXV?=
 =?us-ascii?Q?hCbgNUh7TeXs3XEuEujSllQu7ixeNYm2zNaKmagDnclEjSu8HfmFH71p8Hgq?=
 =?us-ascii?Q?XTTMEuapjINpipAnCPVk+Fw7vICv/n9YM1CH73ufWS0VVWnhvtU+/IxlTfs7?=
 =?us-ascii?Q?5tRiWuf4ATFCo+4tTHxeSaHGYb7VoNQiPRZvPGCFWELSL/swBt6Vu9QspY4V?=
 =?us-ascii?Q?badrfoCbCFAdq5HIz+USv5xXDCWhdWdk4z8CSMy2ougu1CUF8dq8JwtGYKz6?=
 =?us-ascii?Q?t8WOd6C1OYxDLWOAetZhicxf7nDoCOP/5f0KwGIWN1xFKAj9u5/2vPoT4OFe?=
 =?us-ascii?Q?5u0z+zbsfGEhelS1KSvVrepaBhAMJOl3pECJJb7oq8EjOnactTgfRO/ucv+m?=
 =?us-ascii?Q?7IJkySjRnuYGorSVOncP9U+C8gEd0lJzbytXEK8P5lvPJe2I02nL1aK03DjM?=
 =?us-ascii?Q?RyZ/mMxDqyGHnhsq2yHDjZKJTfSj7J5Yjoui08LpT7rLUDRj2Wsny3d9oBIo?=
 =?us-ascii?Q?e+diaug/SOgTPypUG9LA1xAk5W8m9MShv4MraTlIZK+YSU5jtXQ4nodW/j13?=
 =?us-ascii?Q?rXbkz77nw9QIOZ76OGb819bZjCg9g3dlEHVTyLjPsSLRpIU3mX1CWUOwMmks?=
 =?us-ascii?Q?DUD2vpYddKjC1E4nkg7719Iv2kItsTxpvK93UMGtEHlJ1vtp6wz166O6Yu/e?=
 =?us-ascii?Q?neXtyTs6qXtBXGaQO0dHpLc/nN4hp3F4IlazR2I3vuj11jXAjUo4adu63IkC?=
 =?us-ascii?Q?WfPIfPhevTS38qeA+HPxkioO2lXwanGJcL5K0NnpAaYo8NZrVWZJS9QTY7/t?=
 =?us-ascii?Q?lw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?AlZvgeMTy0UglynMXhoQtcQkvwQI5lXBmFtJ21i8a+W8vLyVU95o6uQHo9It?=
 =?us-ascii?Q?1lpfR1fmir6MdwgSAxIxnDZ2Ptib7T9rgicORpZnmfw6kHNEbtp5iXIlS07y?=
 =?us-ascii?Q?bq7b4MtEaMHNAPzGG5M2iucKzMQfqTnUfDjsrZyHlBfyXLcLjhQ+xhzYJByJ?=
 =?us-ascii?Q?2s0K5rPH3cKyWD/IZkJLLd++52nKJfSna7L+Z7Qy5K8Il5YamslztTGFgyct?=
 =?us-ascii?Q?bOhhf9gj6OjVL/6UCfvZWBty+PSC4ZGZjqo4+HHD2FoMQyLXmCG5r51vw3gM?=
 =?us-ascii?Q?jJC9g2IFj+0yPod5CItBYRGRA/UgJcB7dn5kKJHjREETJSPEEITrNSHy2gAW?=
 =?us-ascii?Q?YohTgtY87ZMf9NnftPI0bjb92Qo/o5Rhb9Sz1X+k0P4MMkHPgUBeuxTAqvMz?=
 =?us-ascii?Q?WkDxT1GIvegXEkhsSc/bBp3vmWtK1oRLh8Y19mghe7L21u8wc+CxIC7GSf83?=
 =?us-ascii?Q?Rn430ttUweHFL1oVK1KGWG6cR7I1192TvSIhwdcHmt5LVaGI0h0zE2ud5LWY?=
 =?us-ascii?Q?UlFRDNxiF/DYj7tAUFFn1M2Krg8QuJBCEZ9m2Saiho8gp0/f9ciZM6Pf2sfR?=
 =?us-ascii?Q?B/kkShL2XXjhZ0XrM5Mm8mp3Q/b+jH8b7bgH7GKLB8GY3jSz6Kb/u8EwsEg4?=
 =?us-ascii?Q?ZLSAYe06Mb7BvfMslNrRmSz4C2evVIuspLDP2MnkuYJ1BZ7R4Hm+nZGVzH6q?=
 =?us-ascii?Q?Qiznj7dvij42+6ShbsdEFyPfckpQOU8XnueT71bfE74cSbJw5OJE7k7BfhnF?=
 =?us-ascii?Q?79YRXFCKrxdMJCC3YeiJcYMev+cOc6hKmwJY+uAmm4nt4ag5xAJSwguJjNAu?=
 =?us-ascii?Q?d8r9wAJlfRFl3iEEo4XJ3z2jb52vBD2TUrhLUvkL7sm0gSLH7axgzekhuzHg?=
 =?us-ascii?Q?8Ix8licxxWXPH/LhYfY3mtsPQzmEbmfLeFMiYq2vfVEthixQF5/Ye4E6Ymg0?=
 =?us-ascii?Q?eaAD9BGLkwrHECcXQhsTu+22x8y1jUb+FUsVfGzARHUTDdzkszYSF82mk2L5?=
 =?us-ascii?Q?S9A4l73W1wO2sBSKlf5tl5XyadQejQ2/mXyA2S92PpsjSrqbFNRBZoRCxfYN?=
 =?us-ascii?Q?WhPRI/ldxDR0xvRzHsX61NzUGjR/7wQWqmmKNk+trJpsZc8wVqM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6980aa3b-33d8-451e-fe49-08dad7e89989
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 00:18:43.6094
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9ypIJzF7QCjLLaGyfukp1iJ2RnYn6nmjr+ADTdpvuLfonal4rX1jC2E5GZGiER+EKVIWinE3K91CJX196ojk5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5853
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-06_12,2022-12-06_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0
 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2212070001
X-Proofpoint-ORIG-GUID: bCCUH8YwyOf1ZOYQMyEqNwIADZQzs6Pp
X-Proofpoint-GUID: bCCUH8YwyOf1ZOYQMyEqNwIADZQzs6Pp
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/22 14:50, Sidhartha Kumar wrote:
> Add folio equivalents for set_compound_order() and set_compound_page_dtor().
> 
> Also remove extra new-lines introduced by mm/hugetlb: convert
> move_hugetlb_state() to folios and mm/hugetlb_cgroup: convert
> hugetlb_cgroup_uncharge_page() to folios.
> 
> Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
> Suggested-by: Muchun Song <songmuchun@bytedance.com>
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>  include/linux/mm.h | 16 ++++++++++++++++
>  mm/hugetlb.c       |  4 +---
>  2 files changed, 17 insertions(+), 3 deletions(-)

Sorry, for the delay,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz