Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221207002158.418789-3-vishal.moola@gmail.com> <20221207005624.146281-1-sj@kernel.org>
In-Reply-To: <20221207005624.146281-1-sj@kernel.org>
From:   Vishal Moola <vishal.moola@gmail.com>
Date:   Tue, 6 Dec 2022 18:43:57 -0800
Message-ID: <CAOzc2pwexH7Phhg_Dx0_9dg5_3n=uKSwbpWDKBbNQdY0N97U-Q@mail.gmail.com>
Subject: Re: [PATCH 2/3] damon: Convert damon_pa_mark_accessed_or_deactivate()
 to use folios
To:     SeongJae Park <sj@kernel.org>
Cc:     linux-mm@kvack.org, damon@lists.linux.dev,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 6, 2022 at 4:56 PM SeongJae Park <sj@kernel.org> wrote:
>
> Hi Vishal,
>
>
> Thank you for this patch.
>
> Nit pick.  Could we please replace 'damon:' on the subject with 'mm/damon:' to
> look more consistent with other DAMON patches?

Thanks for looking over this patch! I'll make the subject mm/damon in a v2.

> On Tue, 6 Dec 2022 16:21:57 -0800 "Vishal Moola (Oracle)" <vishal.moola@gmail.com> wrote:
>
> > This change replaces 2 calls to compound_head() with one.
>
> I guess you mean _compound_head() calls in page_folio() that called from
> mark_page_accessed() and folio_mark_accessed().  However, deactivate_page()
> calls page_folio() anyway, so this patch doesn't reduce the number of calls to
> one but keep the number, correct?  Am I missing something?  If I'm not, I'd
> like to clean up the wording.

The 2 calls I was referring to were from mark_page_accessed() and put_page().
As you've noticed, deactivate_page() still calls page_folio() here :).

> > This is in preparation for the conversion of deactivate_page() to
> > deactivate_folio().
>
> I think folio_deactivate() might be a more consistent naming.  What do you
> think?

I do like the name folio_deactivate() better than deactivate_folio(), I'll
change that in v2 as well.