Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 6 Dec 2022 18:53:29 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Alex Elder <elder@ieee.org>
Cc:     ye.xingchen@zte.com.cn, davem@davemloft.net, elder@kernel.org,
        edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipa: use sysfs_emit() to instead of scnprintf()
Message-ID: <20221206185329.092e37da@kernel.org>
In-Reply-To: <ff01f296-f3bb-4fdf-d57f-8dd14f1b61d2@ieee.org>
References: <202212021642142044742@zte.com.cn>
        <ff01f296-f3bb-4fdf-d57f-8dd14f1b61d2@ieee.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2 Dec 2022 16:20:16 -0600 Alex Elder wrote:
> On 12/2/22 2:42 AM, ye.xingchen@zte.com.cn wrote:
> > From: ye xingchen <ye.xingchen@zte.com.cn>
> > 
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the
> > value to be returned to user space.  
> 
> The buffer passed is non-null and the existing code properly
> limits the buffer to PAGE_SIZE.
> 
> But... OK.
> 
> Reviewed-by: Alex Elder <elder@linaro.org>
> 

Thanks! 38db82e2940 in net-next.