Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 07:14:09 +0100
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Woojung Huh <woojung.huh@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>, Arun.Ramadoss@microchip.com,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, kernel@pengutronix.de,
        Jakub Kicinski <kuba@kernel.org>, UNGLinuxDriver@microchip.com,
        "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v1 1/1] net: dsa: microchip: add stats64 support
 for ksz8 series of switches
Message-ID: <20221207061409.GB19179@pengutronix.de>
References: <20221205052904.2834962-1-o.rempel@pengutronix.de>
 <20221205052904.2834962-1-o.rempel@pengutronix.de>
 <20221206170801.othuifyrm3qrz7ub@skbuf>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221206170801.othuifyrm3qrz7ub@skbuf>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Dec 06, 2022 at 07:08:01PM +0200, Vladimir Oltean wrote:
> On Mon, Dec 05, 2022 at 06:29:04AM +0100, Oleksij Rempel wrote:
> > +void ksz88xx_r_mib_stats64(struct ksz_device *dev, int port)
> > +{
> > +	struct ethtool_pause_stats *pstats;
> > +	struct rtnl_link_stats64 *stats;
> > +	struct ksz88xx_stats_raw *raw;
> > +	struct ksz_port_mib *mib;
> > +
> > +	mib = &dev->ports[port].mib;
> > +	stats = &mib->stats64;
> > +	pstats = &mib->pause_stats;
> > +	raw = (struct ksz88xx_stats_raw *)mib->counters;
> > +
> > +	spin_lock(&mib->stats64_lock);
> > +
> > +	stats->rx_packets = raw->rx_bcast + raw->rx_mcast + raw->rx_ucast +
> > +		raw->rx_pause;
> > +	stats->tx_packets = raw->tx_bcast + raw->tx_mcast + raw->tx_ucast +
> > +		raw->tx_pause;
> > +
> > +	/* HW counters are counting bytes + FCS which is not acceptable
> > +	 * for rtnl_link_stats64 interface
> > +	 */
> > +	stats->rx_bytes = raw->rx + raw->rx_hi - stats->rx_packets * ETH_FCS_LEN;
> > +	stats->tx_bytes = raw->tx + raw->tx_hi - stats->tx_packets * ETH_FCS_LEN;
> 
> What are rx_hi, tx_hi compared to rx, tx?

rx, tx are packets with normal priority and rx_hi, tx_hi are packets
with high prio.

> > +
> > +	stats->rx_length_errors = raw->rx_undersize + raw->rx_fragments +
> > +		raw->rx_oversize;
> > +
> > +	stats->rx_crc_errors = raw->rx_crc_err;
> > +	stats->rx_frame_errors = raw->rx_align_err;
> > +	stats->rx_dropped = raw->rx_discards;
> > +	stats->rx_errors = stats->rx_length_errors + stats->rx_crc_errors +
> > +		stats->rx_frame_errors  + stats->rx_dropped;
> > +
> > +	stats->tx_window_errors = raw->tx_late_col;
> > +	stats->tx_fifo_errors = raw->tx_discards;
> > +	stats->tx_aborted_errors = raw->tx_exc_col;
> > +	stats->tx_errors = stats->tx_window_errors + stats->tx_fifo_errors +
> > +		stats->tx_aborted_errors;
> > +
> > +	stats->multicast = raw->rx_mcast;
> > +	stats->collisions = raw->tx_total_col;
> > +
> > +	pstats->tx_pause_frames = raw->tx_pause;
> > +	pstats->rx_pause_frames = raw->rx_pause;
> 
> FWIW, ksz_get_pause_stats() can sleep, just ksz_get_stats64() can't. So
> the pause stats don't need to be periodically read (unless you want to
> do that to prevent 32-bit overflows).

KSZ driver is using worker to read stats periodically. Since all needed
locks are already taken, I copy pause stats as well.

Otherwise it will need some different locking, which will make things
look different but do not reduce CPU load. 

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |