Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6675c596-eeb4-3347-ec85-2bd67b970973@amd.com>
Date:   Wed, 7 Dec 2022 12:28:02 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH 4/4] perf vendor events amd: Add Zen 4 metrics
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>
Cc:     linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
        mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
        jolsa@kernel.org, namhyung@kernel.org, eranian@google.com,
        jhladky@redhat.com, ravi.bangoria@amd.com, ananth.narayan@amd.com
References: <20221207053007.336806-1-sandipan.das@amd.com>
 <20221207053007.336806-5-sandipan.das@amd.com>
 <CAP-5=fUS37Xqi1x2ZDj48saFu-g5dCvwqg8Vm0DF1V0vuq4tXw@mail.gmail.com>
From:   Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <CAP-5=fUS37Xqi1x2ZDj48saFu-g5dCvwqg8Vm0DF1V0vuq4tXw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlBNNHJ6ZTdUR0lmOGhSNWN3R09nMUlWVnZ6NDBnKzNhRlczT1h0Zmhlb0VJ?=
 =?utf-8?B?TEwzbStOQnR3b1Z2bXZjSkhNb1h6Rk5NMmZoL21oYVBTQlNHL1ZwQlptZTB5?=
 =?utf-8?B?S2hkUmZiOXlnY1ErVU1LdXJINnpycUdkcWJPZWE5WldLeW9WRUV1UW01cEhS?=
 =?utf-8?B?bWxLWmI3b25KT1liNVkrSHRzQVZkcitsbS8zc2F0bzVtbHB1KzhTTTZBd2Vw?=
 =?utf-8?B?S2dFclBzM0QzUEl3RkFSMmh6NVdFQVRIU2JEM2JCVEFiRnBLdmJia2VkMENn?=
 =?utf-8?B?YzRISHg4eFZBajdpV2tVKytaY0lOUDJNYnh0VndMNm53Z1J4OGVvQVlMaUlR?=
 =?utf-8?B?Nm5EWm1kUzVXbW1wWDdZclI1eHJYc0lIOEhRdVV6Y2g3cWxraFhubEorbXYz?=
 =?utf-8?B?UVBPZDNHUnZRZndBN0YxNnc2eGd3ZGpiWVZzWWNvZDlEMldCZ2g1c2ZaTXUr?=
 =?utf-8?B?NkJudzBPYTd2Rmw1aTI4K2htakcvQTBKeHByWk5jUnpXQ2dUK2crN0RlQ2lF?=
 =?utf-8?B?U3N0d3hYRElQc2ZWbmdyRWVld0ozUWRqdjk2MjZqbmZoNCtjOERRMmE0VXJM?=
 =?utf-8?B?Ym5VT2xMYmM4KzFNcmNyM081MmE3VUlQMHJSenNKZ3BKMnZOQlU3anRObm01?=
 =?utf-8?B?cmpOL1ZnSkRwcXA4cG9CMUg1VWZlWE80dlh6YVhoaXNSUVcvcVZUclU4eWRH?=
 =?utf-8?B?R1FCTXE0MEZleVJwWGtSRmFIUkpWMjAwTkRBRm1kTExiNEVmRGhIUkh1STQ2?=
 =?utf-8?B?aEFXYzJEVGNKdllERjZBb1p5b3BSQWhFVzBNVWpVQzk0ajBPWXROaDhEYkw3?=
 =?utf-8?B?ZVBNTDltWUpwNzF3S1M0d04vOTVPcDd5UkcyUUp4Q2Vsc2RtOWEyNTJHUURp?=
 =?utf-8?B?TnpYdjhMMzZudmNCeERodW9PVXpUeGJQNFdENEVUc0xVMGVSUVJ6QzFTRXZ6?=
 =?utf-8?B?RHhocDJHR0pNSllSekR4WUM2dExvU3pQL0JrL0l4SUIwTk9rYTJyc2NLUFdu?=
 =?utf-8?B?emNnaHRjVXdnOGhTeFZwRXVJNWl2ME9SbitvaHR4TzZRRmRVY0hPU3g5OFFW?=
 =?utf-8?B?WmJzNjQrWVR3cGtHZk5nOFh2ejJoVWJVUmozV1IrNjJtK3lPdDUyeXNBdFRB?=
 =?utf-8?B?ZFY2MDczekpQRER5WWNyM3Q0QlJONmNFS0NlNUlRb2w1MWRVTU1JaTJ5UW04?=
 =?utf-8?B?NjFsckFaTmFxNm9ETkcxNlBhV2RxMTk5OHJPZDlqWXRMcmRTeHo0TDM2M1pq?=
 =?utf-8?B?UGJRWmFVeUhFVDF1KythcDlwR1pFekZPK005TVNWeWJvdVhGWmsyNXk5RGdC?=
 =?utf-8?B?OFNRTFZKczU0ckg3ak16YVhXUUY2L1FOWUpqdkxtSEZQdExwNk45T0psSnFs?=
 =?utf-8?B?cW1lalRXMm41Nlo0THVVNnBJVDJSait0bnlmMENHTGhKdURsV1B3cS9oQyti?=
 =?utf-8?B?bFkxRHZDai9GZFNDNDI4RmxQeGlIajZ6YkVXVlVnbDByT09FU3N6WHpxQmdv?=
 =?utf-8?B?YXhqSmV2WCtCcFg4cStReCtCQ21OaDFyazlYd3ZoZWZjZDdEUWM3VDNjYUV6?=
 =?utf-8?B?S0t3b0xrd1NMelkvKzEvc1RaMWY5UlZsY2JsUmkxT0JSdDdHUkdPTnNTbS83?=
 =?utf-8?B?ZzV4OFFvdWtiSXdQVGNrUG9nblQvTU05T1NsQUlUTkxjbVJzT09ZTFB3YTgr?=
 =?utf-8?B?bkhjaERuVkdoSmc0ZnphM2hab1lBbSs1dHNXZ2s0Yy9FTXdMN1Z4OFdCV3l1?=
 =?utf-8?B?VmZTNm9oT2RCdE5sdkFBeGZRVHI3bU94c0sxelJhM1RsdEVYcXNjQ1QxalRK?=
 =?utf-8?B?TEc3N0ZNYzIyRE5EbnlzRDhZaEZJUnhqM3Z2RS9CRlU4VjJqMWxEblBSTkVt?=
 =?utf-8?B?YkRGY3ZPa2JWems0eDFUcGtaQ3pFQmJKbFN3QzlWcUt3czgrSk4vd0gxckpv?=
 =?utf-8?B?ZXF6dTZUaWR0UkN3UGV6bWtnSWZZVU9hSEFSaWN2MHlOTW55V2szRHZjZmxy?=
 =?utf-8?B?QjNraXU4WllaZjl4MC9yMS9jdlNyc1JIaFFRZWlYQ2NXaWVDbmtXOWJXZm9T?=
 =?utf-8?B?c0JJYWIwMElCTzk4OVVkUHhybEtZSnR3KzY1UForejF1SGY2NmxETVNCUGMy?=
 =?utf-8?Q?lg8ITmTtYeIGA0crkI6GIqnrk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b84b891-fada-44c1-975c-08dad8206abe
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 06:58:16.9024
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9gfM3T54MD8crHV/yqmH8BCah8UYv8FDazaRBEDiJrA7muYnlwgZSETOL3JMYSDjX5fIgUI1RMCeH96SeN3Xpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6434
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/7/2022 11:35 AM, Ian Rogers wrote:
> On Tue, Dec 6, 2022 at 9:32 PM Sandipan Das <sandipan.das@amd.com> wrote:
>>
>> Add metrics taken from Section 2.1.15.2 "Performance Measurement" in
>> the Processor Programming Reference (PPR) for AMD Family 19h Model 11h
>> Revision B1 processors.
>>
>> The recommended metrics are sourced from Table 27 "Guidance for Common
>> Performance Statistics with Complex Event Selects".
>>
>> The pipeline utilization metrics are sourced from Table 28 "Guidance
>> for Pipeline Utilization Analysis Statistics". These are new to Zen 4
>> processors and useful for finding performance bottlenecks by analyzing
>> activity at different stages of the pipeline. Metric groups have been
>> added for Level 1 and Level 2 analysis.
>>
>> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
>> ---
>>  .../pmu-events/arch/x86/amdzen4/pipeline.json |  98 +++++
>>  .../arch/x86/amdzen4/recommended.json         | 334 ++++++++++++++++++
>>  2 files changed, 432 insertions(+)
>>  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/pipeline.json
>>  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/recommended.json
>>
<snip>
>> +  {
>> +    "MetricName": "dram_read_data_bytes_for_local_processor",
> 
> nit: Is "bytes" redundant in the name here? It may even be confusing
> given the units.
> 

Agreed. I can replace "bytes" with "mbytes" or "megabytes" for these bandwidth metrics.

- Sandipan

>> +    "BriefDescription": "DRAM read data bytes for local processor.",
>> +    "MetricExpr": "local_processor_read_data_beats_cs0 + local_processor_read_data_beats_cs1 + local_processor_read_data_beats_cs2 + local_processor_read_data_beats_cs3 + local_processor_read_data_beats_cs4 + local_processor_read_data_beats_cs5 + local_processor_read_data_beats_cs6 + local_processor_read_data_beats_cs7 + local_processor_read_data_beats_cs8 + local_processor_read_data_beats_cs9 + local_processor_read_data_beats_cs10 + local_processor_read_data_beats_cs11",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "dram_write_data_bytes_for_local_processor",
>> +    "BriefDescription": "DRAM write data bytes for local processor.",
>> +    "MetricExpr": "local_processor_write_data_beats_cs0 + local_processor_write_data_beats_cs1 + local_processor_write_data_beats_cs2 + local_processor_write_data_beats_cs3 + local_processor_write_data_beats_cs4 + local_processor_write_data_beats_cs5 + local_processor_write_data_beats_cs6 + local_processor_write_data_beats_cs7 + local_processor_write_data_beats_cs8 + local_processor_write_data_beats_cs9 + local_processor_write_data_beats_cs10 + local_processor_write_data_beats_cs11",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "dram_read_data_bytes_for_remote_processor",
>> +    "BriefDescription": "DRAM read data bytes for remote processor.",
>> +    "MetricExpr": "remote_processor_read_data_beats_cs0 + remote_processor_read_data_beats_cs1 + remote_processor_read_data_beats_cs2 + remote_processor_read_data_beats_cs3 + remote_processor_read_data_beats_cs4 + remote_processor_read_data_beats_cs5 + remote_processor_read_data_beats_cs6 + remote_processor_read_data_beats_cs7 + remote_processor_read_data_beats_cs8 + remote_processor_read_data_beats_cs9 + remote_processor_read_data_beats_cs10 + remote_processor_read_data_beats_cs11",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "dram_write_data_bytes_for_remote_processor",
>> +    "BriefDescription": "DRAM write data bytes for remote processor.",
>> +    "MetricExpr": "remote_processor_write_data_beats_cs0 + remote_processor_write_data_beats_cs1 + remote_processor_write_data_beats_cs2 + remote_processor_write_data_beats_cs3 + remote_processor_write_data_beats_cs4 + remote_processor_write_data_beats_cs5 + remote_processor_write_data_beats_cs6 + remote_processor_write_data_beats_cs7 + remote_processor_write_data_beats_cs8 + remote_processor_write_data_beats_cs9 + remote_processor_write_data_beats_cs10 + remote_processor_write_data_beats_cs11",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "local_socket_upstream_dma_read_data_bytes",
>> +    "BriefDescription": "Local socket upstream DMA read data bytes.",
>> +    "MetricExpr": "local_socket_upstream_read_beats_iom0 + local_socket_upstream_read_beats_iom1 + local_socket_upstream_read_beats_iom2 + local_socket_upstream_read_beats_iom3",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "local_socket_upstream_dma_write_data_bytes",
>> +    "BriefDescription": "Local socket upstream DMA write data bytes.",
>> +    "MetricExpr": "local_socket_upstream_write_beats_iom0 + local_socket_upstream_write_beats_iom1 + local_socket_upstream_write_beats_iom2 + local_socket_upstream_write_beats_iom3",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "remote_socket_upstream_dma_read_data_bytes",
>> +    "BriefDescription": "Remote socket upstream DMA read data bytes.",
>> +    "MetricExpr": "remote_socket_upstream_read_beats_iom0 + remote_socket_upstream_read_beats_iom1 + remote_socket_upstream_read_beats_iom2 + remote_socket_upstream_read_beats_iom3",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "remote_socket_upstream_dma_write_data_bytes",
>> +    "BriefDescription": "Remote socket upstream DMA write data bytes.",
>> +    "MetricExpr": "remote_socket_upstream_write_beats_iom0 + remote_socket_upstream_write_beats_iom1 + remote_socket_upstream_write_beats_iom2 + remote_socket_upstream_write_beats_iom3",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "local_socket_inbound_data_bytes_to_cpu",
>> +    "BriefDescription": "Local socket inbound data bytes to the CPU (e.g. read data).",
>> +    "MetricExpr": "local_socket_inf0_inbound_data_beats_ccm0 + local_socket_inf1_inbound_data_beats_ccm0 + local_socket_inf0_inbound_data_beats_ccm1 + local_socket_inf1_inbound_data_beats_ccm1 + local_socket_inf0_inbound_data_beats_ccm2 + local_socket_inf1_inbound_data_beats_ccm2 + local_socket_inf0_inbound_data_beats_ccm3 + local_socket_inf1_inbound_data_beats_ccm3 + local_socket_inf0_inbound_data_beats_ccm4 + local_socket_inf1_inbound_data_beats_ccm4 + local_socket_inf0_inbound_data_beats_ccm5 + local_socket_inf1_inbound_data_beats_ccm5 + local_socket_inf0_inbound_data_beats_ccm6 + local_socket_inf1_inbound_data_beats_ccm6 + local_socket_inf0_inbound_data_beats_ccm7 + local_socket_inf1_inbound_data_beats_ccm7",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "3.0517578125e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "local_socket_outbound_data_bytes_from_cpu",
>> +    "BriefDescription": "Local socket outbound data bytes from the CPU (e.g. write data).",
>> +    "MetricExpr": "local_socket_inf0_outbound_data_beats_ccm0 + local_socket_inf1_outbound_data_beats_ccm0 + local_socket_inf0_outbound_data_beats_ccm1 + local_socket_inf1_outbound_data_beats_ccm1 + local_socket_inf0_outbound_data_beats_ccm2 + local_socket_inf1_outbound_data_beats_ccm2 + local_socket_inf0_outbound_data_beats_ccm3 + local_socket_inf1_outbound_data_beats_ccm3 + local_socket_inf0_outbound_data_beats_ccm4 + local_socket_inf1_outbound_data_beats_ccm4 + local_socket_inf0_outbound_data_beats_ccm5 + local_socket_inf1_outbound_data_beats_ccm5 + local_socket_inf0_outbound_data_beats_ccm6 + local_socket_inf1_outbound_data_beats_ccm6 + local_socket_inf0_outbound_data_beats_ccm7 + local_socket_inf1_outbound_data_beats_ccm7",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "remote_socket_inbound_data_bytes_to_cpu",
>> +    "BriefDescription": "Remote socket inbound data bytes to the CPU (e.g. read data).",
>> +    "MetricExpr": "remote_socket_inf0_inbound_data_beats_ccm0 + remote_socket_inf1_inbound_data_beats_ccm0 + remote_socket_inf0_inbound_data_beats_ccm1 + remote_socket_inf1_inbound_data_beats_ccm1 + remote_socket_inf0_inbound_data_beats_ccm2 + remote_socket_inf1_inbound_data_beats_ccm2 + remote_socket_inf0_inbound_data_beats_ccm3 + remote_socket_inf1_inbound_data_beats_ccm3 + remote_socket_inf0_inbound_data_beats_ccm4 + remote_socket_inf1_inbound_data_beats_ccm4 + remote_socket_inf0_inbound_data_beats_ccm5 + remote_socket_inf1_inbound_data_beats_ccm5 + remote_socket_inf0_inbound_data_beats_ccm6 + remote_socket_inf1_inbound_data_beats_ccm6 + remote_socket_inf0_inbound_data_beats_ccm7 + remote_socket_inf1_inbound_data_beats_ccm7",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "3.0517578125e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "remote_socket_outbound_data_bytes_from_cpu",
>> +    "BriefDescription": "Remote socket outbound data bytes from the CPU (e.g. write data).",
>> +    "MetricExpr": "remote_socket_inf0_outbound_data_beats_ccm0 + remote_socket_inf1_outbound_data_beats_ccm0 + remote_socket_inf0_outbound_data_beats_ccm1 + remote_socket_inf1_outbound_data_beats_ccm1 + remote_socket_inf0_outbound_data_beats_ccm2 + remote_socket_inf1_outbound_data_beats_ccm2 + remote_socket_inf0_outbound_data_beats_ccm3 + remote_socket_inf1_outbound_data_beats_ccm3 + remote_socket_inf0_outbound_data_beats_ccm4 + remote_socket_inf1_outbound_data_beats_ccm4 + remote_socket_inf0_outbound_data_beats_ccm5 + remote_socket_inf1_outbound_data_beats_ccm5 + remote_socket_inf0_outbound_data_beats_ccm6 + remote_socket_inf1_outbound_data_beats_ccm6 + remote_socket_inf0_outbound_data_beats_ccm7 + remote_socket_inf1_outbound_data_beats_ccm7",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  },
>> +  {
>> +    "MetricName": "local_socket_outbound_data_bytes_from_all_links",
>> +    "BriefDescription": "Outbound data bytes from all links (local socket).",
>> +    "MetricExpr": "local_socket_outbound_data_beats_link0 + local_socket_outbound_data_beats_link1 + local_socket_outbound_data_beats_link2 + local_socket_outbound_data_beats_link3 + local_socket_outbound_data_beats_link4 + local_socket_outbound_data_beats_link5 + local_socket_outbound_data_beats_link6 + local_socket_outbound_data_beats_link7",
>> +    "MetricGroup": "data_fabric",
>> +    "PerPkg": "1",
>> +    "ScaleUnit": "6.103515625e-5MiB"
>> +  }
>> +]
>> --
>> 2.34.1
>>