Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa5d6cbc-8f83-9e41-0513-adcb32422d2f@kernel.org>
Date:   Wed, 7 Dec 2022 08:39:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Content-Language: en-US
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        kbd@lists.altlinux.org, linux-kernel@vger.kernel.org
References: <20221205000739.583233140@ens-lyon.org>
 <20221205000807.751605665@ens-lyon.org>
 <27ade063-79df-dad9-0427-e16f1ddb43ef@kernel.org>
 <20221206203947.5yifmkntf4uy7lt6@begin>
From:   Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [patch 1/3] VT: Add height parameter to con_font_get/set consw
 operations
In-Reply-To: <20221206203947.5yifmkntf4uy7lt6@begin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06. 12. 22, 21:39, Samuel Thibault wrote:
> Jiri Slaby, le mar. 06 déc. 2022 07:40:30 +0100, a ecrit:
>> On 05. 12. 22, 1:07, Samuel Thibault wrote:
>>> --- linux-6.0.orig/drivers/usb/misc/sisusbvga/sisusb_con.c
>>> +++ linux-6.0/drivers/usb/misc/sisusbvga/sisusb_con.c
>> ...
>>> @@ -1268,7 +1271,7 @@ sisusbcon_font_get(struct vc_data *c, st
>>>    	}
>>>    	/* Copy 256 chars only, like vgacon */
>>> -	memcpy(font->data, sisusb->font_backup, 256 * 32);
>>> +	memcpy(font->data, sisusb->font_backup, 256 * height);
>>
>> Have you tested this?
> 
> Ah, no, I had assumed that this was for a specific arch. But actually I
> wasn't getting it because it depends on BROKEN.

Hmm, for two years... I will remove the con support completely next week 
if noone beats me to it.

thanks,
-- 
js
suse labs