Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 15:37:40 +0800 (CST)
Message-ID: <202212071537405832465@zte.com.cn>
Mime-Version: 1.0
From:   <ye.xingchen@zte.com.cn>
To:     <jic23@kernel.org>
Cc:     <lars@metafoo.de>, <andriy.shevchenko@linux.intel.com>,
        <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: =?UTF-8?B?W1BBVENIXSBpaW86IGhlYWx0aDogYWZlNDQweDogQ29udmVydCB0byB1c2Ugc3lzZnNfZW1pdF9hdCgpIEFQSQ==?=
Content-Type: text/plain;
        charset="UTF-8"
Precedence: bulk

From: ye xingchen <ye.xingchen@zte.com.cn>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/iio/health/afe440x.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/iio/health/afe440x.h b/drivers/iio/health/afe440x.h
index 0adea0047eba..7750b1adc423 100644
--- a/drivers/iio/health/afe440x.h
+++ b/drivers/iio/health/afe440x.h
@@ -122,9 +122,7 @@ static ssize_t _name ## _show(struct device *dev,			\
 	int i;								\
 									\
 	for (i = 0; i < ARRAY_SIZE(_table); i++)			\
-		len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%06u ", \
-				 _table[i].integer,			\
-				 _table[i].fract);			\
+		len += sysfs_emit_at(buf, len, "%d.%06u ", _table[i].integer, _table[i].fract); \
 									\
 	buf[len - 1] = '\n';						\
 									\
-- 
2.25.1