Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 15:42:47 +0800 (CST)
Message-ID: <202212071542472012621@zte.com.cn>
Mime-Version: 1.0
From:   <ye.xingchen@zte.com.cn>
To:     <jic23@kernel.org>
Cc:     <ktsai@capellamicro.com>, <andriy.shevchenko@linux.intel.com>,
        <lars@metafoo.de>, <linux-iio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: =?UTF-8?B?W1BBVENIXSBpaW86IGxpZ2h0OiBjbTMyMzI6IENvbnZlcnQgdG8gdXNlIHN5c2ZzX2VtaXRfYXQoKSBBUEk=?=
Content-Type: text/plain;
        charset="UTF-8"
Precedence: bulk

From: ye xingchen <ye.xingchen@zte.com.cn>

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/iio/light/cm3232.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/light/cm3232.c b/drivers/iio/light/cm3232.c
index 43e492f5051d..e5ff14a825bf 100644
--- a/drivers/iio/light/cm3232.c
+++ b/drivers/iio/light/cm3232.c
@@ -291,10 +291,10 @@ static ssize_t cm3232_get_it_available(struct device *dev,
 	int i, len;

 	for (i = 0, len = 0; i < ARRAY_SIZE(cm3232_als_it_scales); i++)
-		len += scnprintf(buf + len, PAGE_SIZE - len, "%u.%06u ",
-			cm3232_als_it_scales[i].val,
-			cm3232_als_it_scales[i].val2);
-	return len + scnprintf(buf + len, PAGE_SIZE - len, "\n");
+		len += sysfs_emit_at(buf, len, "%u.%06u ",
+				     cm3232_als_it_scales[i].val,
+				     cm3232_als_it_scales[i].val2);
+	return len + sysfs_emit_at(buf, len, "\n");
 }

 static const struct iio_chan_spec cm3232_channels[] = {
-- 
2.25.1