Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7225e76c09c7ff68937e37ee041fefdd6ccac1c8.camel@huaweicloud.com>
Subject: Re: [PATCH v2 2/2] lsm: Add/fix return values in lsm_hooks.h and
 fix formatting
From:   Roberto Sassu <roberto.sassu@huaweicloud.com>
To:     Paul Moore <paul@paul-moore.com>
Cc:     casey@schaufler-ca.com, omosnace@redhat.com,
        john.johansen@canonical.com, kpsingh@kernel.org,
        bpf@vger.kernel.org, linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Roberto Sassu <roberto.sassu@huawei.com>
Date:   Wed, 07 Dec 2022 08:58:42 +0100
In-Reply-To: <CAHC9VhRx=pCcAHMAX+51rpFT+efW7HH=X37YOwUG1tTLxyg=SA@mail.gmail.com>
References: <20221128144240.210110-1-roberto.sassu@huaweicloud.com>
         <20221128144240.210110-3-roberto.sassu@huaweicloud.com>
         <CAHC9VhRx=pCcAHMAX+51rpFT+efW7HH=X37YOwUG1tTLxyg=SA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2022-12-06 at 19:21 -0500, Paul Moore wrote:
> On Mon, Nov 28, 2022 at 9:43 AM Roberto Sassu
> <roberto.sassu@huaweicloud.com> wrote:
> > From: Roberto Sassu <roberto.sassu@huawei.com>
> > 
> > Ensure that for non-void LSM hooks there is a description of the return
> > values.
> > 
> > Also, replace spaces with tab for indentation, remove empty lines between
> > the hook description and the list of parameters, adjust semicolons and add
> > the period at the end of the parameter description.
> > 
> > Finally, move the description of gfp parameter of the
> > xfrm_policy_alloc_security hook together with the others.
> > 
> > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> > ---
> >  include/linux/lsm_hooks.h | 221 ++++++++++++++++++++++++--------------
> >  1 file changed, 138 insertions(+), 83 deletions(-)
> 
> Thanks Roberto, I've merged this into lsm/next with one small tweak (below).
> 
> > diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> > index c35e260efd8c..6502a1bea93a 100644
> > --- a/include/linux/lsm_hooks.h
> > +++ b/include/linux/lsm_hooks.h
> > @@ -677,7 +695,7 @@
> >   *     indicates which of the set*uid system calls invoked this hook.  If
> >   *     @new is the set of credentials that will be installed.  Modifications
> >   *     should be made to this rather than to @current->cred.
> > - *     @old is the set of credentials that are being replaces
> > + *     @old is the set of credentials that are being replaces.
> 
> Might as well change "replaces" to "replaced".  I'll go ahead and fix
> that up during the merge.

Thanks a lot!

Roberto