Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 16:17:32 +0800 (CST)
Message-ID: <202212071617323068233@zte.com.cn>
In-Reply-To: <CANn89iKqb64sLT2r+2YrpDyMfZ8T6z2Ygtby-ruVNNYvniaV0g@mail.gmail.com>
References: 20221205184742.0952fc75@kernel.org,202212071527223155626@zte.com.cn,CANn89iKqb64sLT2r+2YrpDyMfZ8T6z2Ygtby-ruVNNYvniaV0g@mail.gmail.com
Mime-Version: 1.0
From:   <yang.yang29@zte.com.cn>
To:     <edumazet@google.com>
Cc:     <kuba@kernel.org>, <davem@davemloft.net>, <pabeni@redhat.com>,
        <bigeasy@linutronix.de>, <imagedong@tencent.com>,
        <kuniyu@amazon.com>, <petrm@nvidia.com>, <liu3101@purdue.edu>,
        <wujianguo@chinatelecom.cn>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <tedheadster@gmail.com>
Subject: =?UTF-8?B?UmU6IFtQQVRDSCBsaW51eC1uZXh0XSBuZXQ6IHJlY29yZCB0aW1lcyBvZiBuZXRkZXZfYnVkZ2V0IGV4aGF1c3RlZA==?=
Content-Type: text/plain;
        charset="UTF-8"
Precedence: bulk

> Sure, but netdev_budget set to 1 is extreme, don't you think ???

Yes of course, that is just a test to show the difference.

> We prefer not changing /proc file format as much as we can, they are
> deprecated/legacy.

Should we add some explain of the deprecation in code or doc?
As it's deprecated, I think it's NAK for this patch.

> Presumably, modern tracing techniques can let you do what you want
> without adding new counters.

Totally agree.