Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <DU0P192MB1547BAB562FED0D6401DF5B1D61A9@DU0P192MB1547.EURP192.PROD.OUTLOOK.COM>
Date:   Wed, 7 Dec 2022 19:47:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH bpf-next v2] bpf: Upgrade bpf_{g,s}etsockopt return values
Content-Language: en-US
To:     Martin KaFai Lau <martin.lau@linux.dev>
Cc:     daniel@iogearbox.net, john.fastabend@gmail.com, ast@kernel.org,
        andrii@kernel.org, song@kernel.org, yhs@fb.com, kpsingh@kernel.org,
        sdf@google.com, haoluo@google.com, jolsa@kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, bpf@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <DU0P192MB1547FE6F35CC1A3EEA1AFDECD6179@DU0P192MB1547.EURP192.PROD.OUTLOOK.COM>
 <DU0P192MB154719A31758750149418C73D61B9@DU0P192MB1547.EURP192.PROD.OUTLOOK.COM>
 <2118324c-a6e6-775d-77c2-75587e69e7ff@linux.dev>
From:   Ji Rongfeng <SikoJobs@outlook.com>
In-Reply-To: <2118324c-a6e6-775d-77c2-75587e69e7ff@linux.dev>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DU0P192MB1547:EE_|PR3P192MB0668:EE_
X-MS-Office365-Filtering-Correlation-Id: 848f6368-db80-4d5a-702a-08dad848d08a
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: JykCh2teTsuK89jBGKFsOOamQIqq7qb+mtG7Jhq+JtZeor+tb+XWcTvgz07A4XFz18esX2At1wYkygMNfMW5JV8lcmudpYK0DE/5PqHgyxNK+AkCll1JcmbqluSwb0GnMElMLYx+7MIJinjGiqwOYF0FubB8+V137vuinvueb9C0RbKLrAzZN3acBAcIhj91c23bTJ0MLIzLBTHad0KKQzNs+pt0dCeyTSvU54IQKY5njRoW4EXb0MZeFdBXrcva3sGMxFj7E7ATAPa4gB/BPxBGzj6HhxXSartsmxIGHhBgy0WRlfXbXnCf3Pnk2KeCm4kk2+LXua5XNE4bnhKClreJwpYv7b9zYki+pPt6WT7fPubeCm+NzBnqkvvjKqVAg4OW4bnXShvADCctQCC2Khc9Dsx/oTD0J6tcRXv87WxNWKMMhbGu2Vna17+eH/s7bqFIwGAkgqXD0JIeJ85mrSvP3KX6qYUAGjgQ6OikyYcruz9B3bcmUIAaqGVf91nLh12W8THbQfkYdD8+1x5Zk41fSzByrxd08cX4BiDHjLSCXG0D2pFMyAVF2dOQqBDEfXjQ5E3DLLsndTEa6MTFfV1kvzB97gcGYtdh5JZr3ItpFcEE/6tpEFGRHNGgreVV8nl8A52E7zfewVUpfkWs3A==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ymg3allpV2k5WFk3Ymp5aU05TlNGNXAyRWtqL3dveXpJL0U1QUdWTElYdXBH?=
 =?utf-8?B?eUwremRMdVM4U1J4NlFHamYvMVFSeUFjeGNNOFpTdHdZUzZtNHhwVW85Q2ov?=
 =?utf-8?B?cnBuT1BFUkxxSHFqQ2JRRk1JbXdoYUpqMlJXdncvOWJKbW1YYkJqWTZpSWgv?=
 =?utf-8?B?aUw0YVRGdkF6ZVA5bHJ1MEd2Uzl3YjdVcG1LNUszVXVMbk1FVW04WDRnYlpj?=
 =?utf-8?B?bk5KZDJNVWk0Q2g1S0hOZEZLMGdqbEJ5N0NEb2xiVzBIRWszeFQ3dkZZSmp5?=
 =?utf-8?B?NzZUdTluV2N3Q2RUSFlzOEZWNy9WVVl1UWdla1grcjV5ZC9yQk5zd1MrdkNB?=
 =?utf-8?B?Q1ovdTNFMyt5QlczR1N2UnlmZEFBU2NzWVV3L2VhZFRwZTk2ZUttWTVEK1ps?=
 =?utf-8?B?dGtMeitNcXA4NmtLeGpDbHpBbTlLOHgydWxHR2tsMUQxVWg3em5vbFU5eCtW?=
 =?utf-8?B?UktvUW1xVVFzYmVUTUs5WXF5clZuODR0ZnNZNGRwMWlCYW40NHhVcnk0MHVt?=
 =?utf-8?B?WFFRRzNzc0w2MlJVQVRIR0todkExY2ZTK3pWYWFiNk96Y3A1TGN0VU56TWx1?=
 =?utf-8?B?Q3JvVzI2aDRuMTVSaWxRek04SlJSYVN0dEcrWVFkd1NNY1dxQUUzWW9ONWg1?=
 =?utf-8?B?ck93NEZmTUozcU05aVVBMVNNbnByWmhwK2JXa0pmazJFdkwvd1BFWlVTNE9S?=
 =?utf-8?B?TEk3ZDZrd28ySVl2WHUva3RNR1k3VjRuRjhUTjNURzk3MjZOalJ6WmdJQ0x5?=
 =?utf-8?B?UHRsMEZ5Q2UvYXBqUVZiSFVBZGhtUUk4UndxeURqbXptUWFXSnh1ZUVEbVBV?=
 =?utf-8?B?UmZTZTFvajJMY2RwckMvR2RaYlBXZDErK1pnZC9FUUNMMnVqbGtuNkVSWUlX?=
 =?utf-8?B?T3BZL2RXaEpxY1E1SkJ0eHMrbzdoazQzWGkxdDl5aHM1ZUdwRVJONXVRcmVP?=
 =?utf-8?B?Z0xScEJuQm15VDBxeTF4ekNtTWJ5andndlBpSGV1d1Z0bDBnY2Fmc2NzOXVn?=
 =?utf-8?B?aFlWQjl5SXRpb3JUaVo5V0pIZit4Y1RvQ3BxNTdhUnlmSThqZTdmY1Y0dFk5?=
 =?utf-8?B?VWg1V0F1RkhDWU9pamtteDU0QjBpL1Noc1o5NC92VGdrbXpSTG5rRzBHdWps?=
 =?utf-8?B?S1M1YkxEUGhkQWZ4b2U4Z1M5Y2pqdXlWd0dTSjZjeGo3VWN1WjRVSkVVTkE4?=
 =?utf-8?B?MUREeVgwUzBuOGZHQmY1d3lFUUM1aHA1SjVaMC8yT1JYOTJSVkIzNGxtMGRR?=
 =?utf-8?B?TURXZlI5dXRpYWZGa3ozODFxbXIrVDJ5VEJ6cE9QQVE1bzBLYXorU3JXdloy?=
 =?utf-8?B?eGpBb1Q2TGdpSXMrdFN6d0MvU3lHMkwvNmkxUEZXTEtNMkZBUDFQZ3poK0pj?=
 =?utf-8?B?VFlXc3RhV1ZmVnA5cXloamxIcEFUT0xPaE83SDZ3b3FWVDhVY1RXWEk1Wnd3?=
 =?utf-8?B?RjVlSTBZQmZRbUgyUXRMckNUc0xqcmw3ZXlmZTJDbjVNcFJEK1l5TUgreWhE?=
 =?utf-8?B?K2p1SkU1TVV0YjQ2VFRlREpxOVVVd1VqRnRRUmZLa0IrOEc1MVA3RmtrQm56?=
 =?utf-8?B?elVWbGx1aUx2VEx1bXlnb3ZhaWJjbzArTnlWRzMyYzgxcGdtSUFidVgxdVVO?=
 =?utf-8?B?ME5mSzh1dUlQWUpsVDV0anN2SURDNk4vak0rOWFuRHBJZzBrL3hxZ0w4Q1JY?=
 =?utf-8?B?TVZsVG1KRmFNUG1OeVU4aGVOdjZsazVlTlB3andpbDY4UkJmeHg2SW9RPT0=?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 848f6368-db80-4d5a-702a-08dad848d08a
X-MS-Exchange-CrossTenant-AuthSource: DU0P192MB1547.EURP192.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 11:47:27.6668
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P192MB0668
X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_MUA_MOZILLA,
        FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022/12/7 2:37, Martin KaFai Lau wrote:
> On 12/6/22 8:35 AM, Ji Rongfeng wrote:
>> I have noticed that this patch has been marked as "Changes Requested" 
>> for a few days, but there's no comment so far, which is abnormal and 
>> confusing.
> 
> It is obvious that a test is needed for this change.
> 

Sure. These unique return values will be written into documentation and 
widely used in production environment. So I will add some tests, to make 
sure that they won't be changed accidentally in the future.