Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kumaravel.Thiagarajan@microchip.com>
To:     <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <andriy.shevchenko@linux.intel.com>, <macro@orcam.me.uk>,
        <jay.dolan@accesio.com>, <cang1@live.co.uk>,
        <u.kleine-koenig@pengutronix.de>, <wander@redhat.com>,
        <etremblay@distech-controls.com>, <jk@ozlabs.org>,
        <biju.das.jz@bp.renesas.com>, <geert+renesas@glider.be>,
        <phil.edworthy@renesas.com>, <lukas@wunner.de>,
        <UNGLinuxDriver@microchip.com>, <colin.i.king@gmail.com>,
        <Tharunkumar.Pasumarthi@microchip.com>
Subject: RE: [PATCH v6 tty-next 3/4] serial: 8250_pci1xxxx: Add RS485 support
 to quad-uart driver
Thread-Topic: [PATCH v6 tty-next 3/4] serial: 8250_pci1xxxx: Add RS485 support
 to quad-uart driver
Thread-Index: AQHZBUCyVI8Jzgj/vEqV1N6a80ZqLK5YyUOAgAmO8FA=
Date:   Wed, 7 Dec 2022 11:51:31 +0000
Message-ID: <BN8PR11MB36688D417F015D5DB19FA3FFE91A9@BN8PR11MB3668.namprd11.prod.outlook.com>
References: <20221201045146.1055913-1-kumaravel.thiagarajan@microchip.com>
 <20221201045146.1055913-4-kumaravel.thiagarajan@microchip.com>
 <b9d2c851-7b16-b0a0-3475-c5ab17a563e@linux.intel.com>
In-Reply-To: <b9d2c851-7b16-b0a0-3475-c5ab17a563e@linux.intel.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Nm0YoMhMkkRHNXBp9zulcCMWTkVzrRcHa7WkLdEiFZiA/v0RNJCg1LkJHg?=
 =?iso-8859-1?Q?cfdcH1wlkYHRoUToZdtsDFMFpNYw9Qbs3fTjpM1A+Op4QgjVunuC8T/8Be?=
 =?iso-8859-1?Q?eef2m8FfqgoVpeBWIP9dU3tExBubqpgkOJ36CJyLyLFrqDdSjcjEp3kgYz?=
 =?iso-8859-1?Q?T4YS4H7nSJBMK9ToXs8rxGbaDIrTozX8Ooi2M+xVu0ec41Tkd/9SE6p9UV?=
 =?iso-8859-1?Q?RJPAsFHCUmmciyABUxxk11swNOob66T2C6oySwxfuBVRpB6RvLOkqXSYO9?=
 =?iso-8859-1?Q?gm/ET9sOOFNLJJOTAVYAcRQXpzr5uHps7O3wHPeELfs+lruDZ6z5WucEEt?=
 =?iso-8859-1?Q?R+vE0nvzGrv803brK6wL5fDVSqHO91G08cKUmH2mSpbMecKJaeFMAoikC4?=
 =?iso-8859-1?Q?UCA4zLqK6zhin9ovFEYVSudnwPtHmIoy6Dd1jitPI9Kqewh3aLNP5YEP1z?=
 =?iso-8859-1?Q?ocfzKExbvQCDblWGNzmf6B8YCfUCP5gkhMcAglv9We2UqCiOQOgt7Ym34E?=
 =?iso-8859-1?Q?o/dcNC2X9jd+lK7PAU9MZYDKdexs/sZ1RN4lW3n66jpU/Tq5UjW6A62DnA?=
 =?iso-8859-1?Q?rrhH1xjbKTf72ZNAT5WUb4YgClG1nnH3JyakvVNnK06c9W60/isnh+lcyb?=
 =?iso-8859-1?Q?BDD7tSEDcgNHj4pnUFSMM4xKccRYmsKoI+y8XODDvCR0qWhxjpQYGXrF5O?=
 =?iso-8859-1?Q?2vlyQkR3jhneiJQXf8mOViD0pHnkBNqyC1Forwmq9FthybQM7/ZsBHKlCN?=
 =?iso-8859-1?Q?VLGASvdd87duEbUEGLiFNvyfoTtdbr2iTRgZVYn6QF3t/Nm+jWI+kBVy6J?=
 =?iso-8859-1?Q?GXVoZbvjdPIUgh1/z5gxA2zAVu5E/2SnD0rvBFAWMAQ9VcBxJzd+JEz3vS?=
 =?iso-8859-1?Q?ojmZQaUbIRSYYw8JvNh2YaiTN1PvuSZGm1upEQ7NKgRHqXwU1DFlrOO+2c?=
 =?iso-8859-1?Q?AG+w2OYqRspHKx/7RIALhwdqwvzccwMgDejt3ZCsdC1P++UJuHe9ycrzw+?=
 =?iso-8859-1?Q?W2PqtHthmHC9v3MGy6+v/zz4uew5NQBz/XWY5C7S9dvAuGSbCkJMUQAkgd?=
 =?iso-8859-1?Q?vZ5uhgYTsixy7mZa7/JzerkRWVw9CleLYBfTuwjeBFzp7v10T1qtgOUpU9?=
 =?iso-8859-1?Q?+okl4H5qbfdtiQt0/L+e6p+P7+X00X3WikGN0gcTSScPR3QQO8H+ErO3dY?=
 =?iso-8859-1?Q?Ufyj/pxC6AaGD2iuCvL3U7ix8aatJaIfIN9JTZfRkilGyhSqpIm7LDXxTC?=
 =?iso-8859-1?Q?xHzk+Av/KhPEagJjhdeYfEfJG+uQQtyhTxl8Ds8Q2iOxbqYrSoNwhKokJ8?=
 =?iso-8859-1?Q?uiRu8D0qJEC91QgBtbSROTJTFTNqjpYTmITRFa4km1fFb1tzbBUNv/OSUN?=
 =?iso-8859-1?Q?parpAss/ieE13jGo0Rsw7LqWHDovQknhC25M0mWh9WzXBFSnoFWRoThv2V?=
 =?iso-8859-1?Q?GTHBD1n2A+orktZiAEHZYBQATRhMgpOcp0nrrVGiRu2MebTW3k84fv8CHU?=
 =?iso-8859-1?Q?bV1Tf0DlnUQOcZP4RvngwdQFA1F+aUuTPrM5xubGek89dDBfRwmtgvUm1d?=
 =?iso-8859-1?Q?dSbOujZWGwuVgYUDYPpeQFedRNLH8A3dVFNt9+yUGuGkq1VUGYMaZCaNzP?=
 =?iso-8859-1?Q?Rriv/8r8rZj+Rssx8vCJ711nPOpux3cY5zKKvsrPQdQCtpUeoFldLbP9Vj?=
 =?iso-8859-1?Q?yQ01oYAsvKzWfhy/jfs=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3668.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62befd3b-085b-4d20-1540-08dad849625c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2022 11:51:32.0448
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: R9l1JS97UG9+iLrcSHdL6BAAg5akoGJK2krVsxYw6DCb51YHAh+8UbUmX7GyEXrOE6EHJ38IiSkiZh6YGmticW9DXzCBzeDAtyRPVhRocjcaUS7daZqyzrmhzzlrafmT
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5231
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>
> Sent: Thursday, December 1, 2022 3:17 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@microchip.com>
> Subject: Re: [PATCH v6 tty-next 3/4] serial: 8250_pci1xxxx: Add RS485
> support to quad-uart driver
>=20
> On Thu, 1 Dec 2022, Kumaravel Thiagarajan wrote:
>=20
> > pci1xxxx uart supports RS485 mode of operation in the hardware with
> > auto-direction control with configurable delay for releasing RTS after
> > the transmission. This patch adds support for the RS485 mode.
> >
> >
> > +static int pci1xxxx_rs485_config(struct uart_port *port,
> > +                              struct ktermios *termios,
> > +                              struct serial_rs485 *rs485) {
> > +     u32 clock_div =3D readl(port->membase +
> > +UART_BAUD_CLK_DIVISOR_REG);
>=20
> Maybe move this into the block where it's needed?
>=20
> > +     u64 delay_in_baud_periods;
> > +     u32 baud_period_in_ns;
> > +     u32 data =3D 0;
>=20
> data seems a bit too generic name for a variable? At minimum I'd suggest
> using cfg or mode_cfg (I couldn't guess where ADCL comes from, perhaps it
> has some component which would make the variable name better).

Hi Ilpo,

We just noticed after submitting v7 that this email of yours got forwarded =
to spam folder by our IT infrastructure automatically and we missed it.
We will take care of this in v8.

Thank You.

Regards,
Kumar