Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp749414rwb; Wed, 7 Dec 2022 04:41:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf6TUg/8ns6jlUuLqOVwqglW/my2lZ4CXTi3nYiw5Rz107gRzPZEFQ7Z7bQ4lGMOet105Dq/ X-Received: by 2002:a17:906:1797:b0:7c0:c805:42a with SMTP id t23-20020a170906179700b007c0c805042amr18199891eje.324.1670416917740; Wed, 07 Dec 2022 04:41:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670416917; cv=none; d=google.com; s=arc-20160816; b=iO6939pC2AgvEQtNFMNvYmRHsSKcfYUxXfEI26X2EnAofnVNg+vIcYp3llU9O7AT1O CzdGbmk3EhX1McYvWA2i52uLHd3uQlc4ZhnaU4YSx5BjPSEwsa7YF0766PkTdsG/5KOu L4G9rv33uSl9HTmjFCPXbBKl0Igj0yA/nOQMhxqkQIorX4UnqD/7bfWvTpH+BK+Q5pXt p70TnOwRC6kGsL1k2GEzUdPGA5U8Ud+nuI0chXMLBUNbTMKIJ0HXhYlU7OT0qg8+beOn puZJx3zgHeXt8tddt5EuHB4v/v8+zuk1H4yhmnLHTEVNU76ekb+j5zPP1osMnLwg+XWG AjpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9atWu9JU4Cx+ETdJlBYNzYOikPveUu+xlZLV8W2MIpw=; b=YcHYrjcqEatuLG9YcizlCiVDew97+4CWZKk6Ek9/CLUJ6Dy/GDtqiYA75hc7iSmrp9 5bSIXjbNIw88v5IXx5h71dRt74vJECKWwb6WPvG61/Vs4dD0B4ySNVq9qkvi4/MsO9RF lMy9FwH6z4qAO3E4lpv2NpWjOgw7yeSlUI3StGSjL6qSWo569ySssB7WSzoiE2cPy65w XiRRWMpFa5xg1F+j8c6DIJG40lkdIRvwr4dTkBCIwr+z0qKp63rzd+DZOKyNNtgWuGQw KPoCPQpd/ButsWVDDyKJcHnsXQCy1rs/th4QcWqSy521Oz92U4a1zrKT+KaVZ/NL6Jl9 +tYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bi8xuoGA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f16-20020a056402355000b004674c93ecb8si4742250edd.326.2022.12.07.04.41.38; Wed, 07 Dec 2022 04:41:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bi8xuoGA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229640AbiLGMhb (ORCPT + 77 others); Wed, 7 Dec 2022 07:37:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbiLGMha (ORCPT ); Wed, 7 Dec 2022 07:37:30 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04D2A532F1 for ; Wed, 7 Dec 2022 04:36:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670416588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9atWu9JU4Cx+ETdJlBYNzYOikPveUu+xlZLV8W2MIpw=; b=bi8xuoGAoBBorLpbBdbO3inGXM9si7s/wwi9wlFczWv6a73aTrzYffi+Nz6Yb2Mb0GODuc 7qtPwJKHUsq/vQyZqY2OTCuHNUoe37LGtFZWi/E0cWdczWcvvZ9yy7AhfB6SKCIcvECMNp QZLI5t6EDpt2gVh0l5XNGxfJc8KroT8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-KQv1VQ-TPnmsF6_VZrQsNw-1; Wed, 07 Dec 2022 07:36:24 -0500 X-MC-Unique: KQv1VQ-TPnmsF6_VZrQsNw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5D86A380450D; Wed, 7 Dec 2022 12:36:23 +0000 (UTC) Received: from localhost (ovpn-13-181.pek2.redhat.com [10.72.13.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 378A620FD3AA; Wed, 7 Dec 2022 12:36:22 +0000 (UTC) Date: Wed, 7 Dec 2022 20:36:13 +0800 From: Baoquan He To: Borislav Petkov Cc: Eric DeVolder , linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com, sourabhjain@linux.ibm.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support Message-ID: References: <20221116214643.6384-1-eric.devolder@oracle.com> <20221116214643.6384-4-eric.devolder@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/22 at 11:00am, Borislav Petkov wrote: > On Fri, Nov 25, 2022 at 11:26:53AM +0800, Baoquan He wrote: > > This kernel config CRASH_HOTPLUG is added in patch 7, but we have used > > it in the previous patch, not sure if this is acceptable. > > Why would it not be acceptable? Below is my last reply to Eric about my thinking on this. That would be great if it's a normal situation when adding Kconfig item, I am happy to learn this if it's confirmed normal. ===== Hmm, since it's bisect-able, seems doesn't break rule. I could be too sensitive. Do we have a precendent like this, to strengthen our confidence? If no concern from other people, it's also fine to me. ===== Thanks Baoquan