Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221205160353.1.I5fa28f1045f17fb9285d507accf139f8b2a8f4b5@changeid>
In-Reply-To: <20221205160353.1.I5fa28f1045f17fb9285d507accf139f8b2a8f4b5@changeid>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Wed, 7 Dec 2022 13:37:48 +0100
Message-ID: <CAPDyKFp_hq1-kvd4s=573vU=2AkfteSuCiDxcGK0-UHMW-mh7g@mail.gmail.com>
Subject: Re: [PATCH] mmc: sdhci-brcmstb: Resolve "unused" warnings with CONFIG_OF=n
To:     Brian Norris <briannorris@chromium.org>
Cc:     linux-mmc@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 6 Dec 2022 at 01:04, Brian Norris <briannorris@chromium.org> wrote:
>
> With W=3D1, we can see this gcc warning:
>
> drivers/mmc/host/sdhci-brcmstb.c:182:34: warning: =E2=80=98sdhci_brcm_of_=
match=E2=80=99 defined but not used [-Wunused-const-variable=3D]
>   182 | static const struct of_device_id sdhci_brcm_of_match[] =3D {
>       |                                  ^~~~~~~~~~~~~~~~~~~
>
> Rather than play around more with #ifdef's, the simplest solution is to
> just mark this __maybe_unused.
>
> Fixes: 1fad8422c989 ("mmc: sdhci-brcmstb: Allow building with COMPILE_TES=
T")
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202212060700.NjMecjxS-lkp@intel.com/
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>
>  drivers/mmc/host/sdhci-brcmstb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-br=
cmstb.c
> index 55d8bd232695..f2cf3d70db79 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -179,7 +179,7 @@ static const struct brcmstb_match_priv match_priv_721=
6 =3D {
>         .ops =3D &sdhci_brcmstb_ops_7216,
>  };
>
> -static const struct of_device_id sdhci_brcm_of_match[] =3D {
> +static const struct of_device_id __maybe_unused sdhci_brcm_of_match[] =
=3D {
>         { .compatible =3D "brcm,bcm7425-sdhci", .data =3D &match_priv_742=
5 },
>         { .compatible =3D "brcm,bcm7445-sdhci", .data =3D &match_priv_744=
5 },
>         { .compatible =3D "brcm,bcm7216-sdhci", .data =3D &match_priv_721=
6 },
> --
> 2.39.0.rc0.267.gcb52ba06e7-goog
>