Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp759260rwb; Wed, 7 Dec 2022 04:50:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf4uQJuFu2dN5a9rL8GrxLfHdo/pJnWbv3OdYjFJwDwve3ymlYt2qDv2C8C0Bnlf+luw/A0e X-Received: by 2002:a17:906:c250:b0:7c0:9bc2:a7f0 with SMTP id bl16-20020a170906c25000b007c09bc2a7f0mr27506046ejb.59.1670417403935; Wed, 07 Dec 2022 04:50:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670417403; cv=none; d=google.com; s=arc-20160816; b=o8ExU/BV+dhpMHPVcOTz6wZza1AXG5ZhWOqDmZdgFsvIP0PtxO9qgi2Gfw/Ls+B0/H BDFfslrs1EvhYvuiBdYJCfPU7C/FyjxtoMzpZHr0LdvhD20enPH59GVmhkh7MpoHDfIt vYy8WrpxBTg5FXlegTnfcDzdhrPQfODnp/x4MYDMbyojUraRsS6AR6p2QtV4XdU9Vxha 1E94fz7u+RgwtV0B+oClkcsfSEKrciwYJv3tOJNYypMFvuW2MwjfAUG57iMOiE5xIp8e wyvdXt9A7VxA2eLbCZG40oUyLmiMhv+m0Mtgyc9iqz7gcSBGpOt7LxocqpDXho7tMWk1 4Ncg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3MvFYIyTeLFFW1d9iStpsuAgJDEJsf13+oilEAecoj4=; b=mu0628Q7AbsPPO4HRTey15sRXG4SPrJ0+0BXGiEpbzj69BqMcvqyk7I/5MZzYrSYI1 5/BuEZcAfrq0WiCYXTPpsVr629I6cPDuCRND3RqaUQWQhNtMG6IuUj2i2SBcQUF0Q77u JmeJ4sHj6M095DYN5xVZoGDH30hzL2jxbVuefiy6xjAVMvTwTaHG7teS7IAKl+eqwWt7 1HCzR+NWLgeqJbiBqeDtdx7jhW7Su0u2eTLfViU5dtGx0HlccDkUrLQIjbOcuwrCSy6J 8C90DSCloeOcluXdPxm4v897pghZhszYuZmqrsvCHjynB6KHhrmDoP91cEMs2JpxjIGw 0sFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=qdGXzwGh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jt13-20020a170906dfcd00b007c1031ebabasi3629336ejc.49.2022.12.07.04.49.44; Wed, 07 Dec 2022 04:50:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=qdGXzwGh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbiLGMmr (ORCPT + 77 others); Wed, 7 Dec 2022 07:42:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229909AbiLGMml (ORCPT ); Wed, 7 Dec 2022 07:42:41 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 197B125D6 for ; Wed, 7 Dec 2022 04:42:36 -0800 (PST) Received: from zn.tnic (p200300ea9733e711329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e711:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 02A7D1EC0513; Wed, 7 Dec 2022 13:42:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1670416955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=3MvFYIyTeLFFW1d9iStpsuAgJDEJsf13+oilEAecoj4=; b=qdGXzwGhCFmhATB0qA/rtQacIGbPToV2f6g/ANDYFpfJy0fns+dU/7xcn3c9pVXiTS0lfq arzPw3oc+ooWALh7wA5C2RO/ZDuUXV28h0NzXaI4HMtgoSUpyagYwVe59nKgY9eK2WGuOd le0+RTEY5tJOCR/plq+ipYrV6RC8wZc= Date: Wed, 7 Dec 2022 13:42:30 +0100 From: Borislav Petkov To: Baoquan He Cc: Eric DeVolder , linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com, sourabhjain@linux.ibm.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support Message-ID: References: <20221116214643.6384-1-eric.devolder@oracle.com> <20221116214643.6384-4-eric.devolder@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 07, 2022 at 08:36:13PM +0800, Baoquan He wrote: > Below is my last reply to Eric about my thinking on this. Yes, I saw that. So think about it: if a CONFIG_ item is not present, what does that mean for the code which is enclosed around it? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette