Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp856245rwb; Wed, 7 Dec 2022 05:58:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf60kEhJo+hFYhC+HY/SrFmcV7ZR56FvJK50t+IfLHdB49ZEniMBG2KIQ48i5MZvs0fuavMc X-Received: by 2002:a17:90a:394d:b0:219:c8f9:b286 with SMTP id n13-20020a17090a394d00b00219c8f9b286mr17013953pjf.5.1670421531324; Wed, 07 Dec 2022 05:58:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670421531; cv=none; d=google.com; s=arc-20160816; b=gYIuzuWIaQ2g5ZuR/aDsqs6Nia4WgIkz/5de0wyJAA4gBnDUOy/YR9x34iJfdxclsQ PwO2MNncbOK38q3Mt5hzw1B8b4/1d9pYmCxOW4LfHBtwX/vlwHItXmd+4KjB/KOGO+oO f4gtiz0njLpdM8Tm5zT8yXpKusI+rldCIVbvgA8IXCkFWEzQUPHkd9Z8iN7FkQQdScmc /NV3+ch/mTnZQKqoWkHiGuZ1wiPUcuFb4wI/XhJIMMiharStj7ZZGzosbF3+jGUeG1WI sIadULCgpEWhx4GW6m7fOU7/AC3l5+UAPgpa4cXnf2jNbxDDAUNdeJWSBpN03Tr7Xz/E HvWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=U26f+M4wlDqheSbigFCS6ZSCHSIQRyS1mH7MNJFq3Q0=; b=QfSLetEr+fctl4sgDtAt8uF97TuMA34DIAyR9ONEMw3/AKIeQ3CD5gsoWzMm3yXE3v 8xNUgn8S82rglqlZTPrypOrmMdAKN7KxakCgNTWoyt0P62x3v/IpWHvIeJQY5rs1dtoZ nsHIZsNRFWbo/kC2pSojrOgCm6ALRMsINPwlc+D3UooF9eNG0rPvP7lqLdpmppGg4FR1 DlIAlPh24fe7g3//lj3Z3ShHBZhoczaCUsWXgFzUJml1hHtqXubH8Qm5U8PLSn/N9zpW 8+U3JoVazgFj3hz2+Y9rG8NLFRFEzcwowDHvth+ov49aG9Xbu3SUoNXYuHHFpBydVVLC 7JfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i1-20020a63d441000000b00476f3facb4csi20628016pgj.221.2022.12.07.05.58.41; Wed, 07 Dec 2022 05:58:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbiLGNT4 (ORCPT + 75 others); Wed, 7 Dec 2022 08:19:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbiLGNTu (ORCPT ); Wed, 7 Dec 2022 08:19:50 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A870140F7; Wed, 7 Dec 2022 05:19:49 -0800 (PST) Received: (Authenticated sender: foss@0leil.net) by mail.gandi.net (Postfix) with ESMTPSA id 72C2B24000F; Wed, 7 Dec 2022 13:19:44 +0000 (UTC) From: Quentin Schulz To: Minas Harutyunyan , Greg Kroah-Hartman Cc: Quentin Schulz , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, William Wu , Bin Yang , Frank Wang Subject: [PATCH 3/3] usb: dwc2: prevent core phy initialisation Date: Wed, 7 Dec 2022 14:19:18 +0100 Message-Id: <20221206-dwc2-gadget-dual-role-v1-3-36515e1092cd@theobroma-systems.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221206-dwc2-gadget-dual-role-v1-0-36515e1092cd@theobroma-systems.com> References: <20221206-dwc2-gadget-dual-role-v1-0-36515e1092cd@theobroma-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.10.1 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Quentin Schulz From: Bin Yang The usb phys need to be controlled dynamically on some Rockchip SoCs. So set the new HCD flag which prevents USB core from trying to manage our phys. Signed-off-by: Bin Yang Signed-off-by: Frank Wang Signed-off-by: Quentin Schulz --- drivers/usb/dwc2/hcd.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 657f1f659ffaf..757a66fa32fa8 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -5315,6 +5315,13 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg) if (!IS_ERR_OR_NULL(hsotg->uphy)) otg_set_host(hsotg->uphy->otg, &hcd->self); + /* + * do not manage the PHY state in the HCD core, instead let the driver + * handle this (for example if the PHY can only be turned on after a + * specific event) + */ + hcd->skip_phy_initialization = 1; + /* * Finish generic HCD initialization and start the HCD. This function * allocates the DMA buffer pool, registers the USB bus, requests the -- b4 0.10.1