Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: yXczMUtKlfbLNOpC9QHY+oXT/FGHc88hAZrrIxRyQWiXcqWOSzriekzjZY1xe7Is2JvJbvYrb7
 4LooAvBU5a5jvjFqzDkpHBVhtZSX8mwZ7doeQ4OtNrlFyG0GE9RBu5vYNG54veqKS06LvDlDf2
 Tfa4REoSJrNI0baAnKYdoFrEpo3OKOBBA0wjITda6Rl00TcTlYHmTIL3HKGGcCKPogPTAtK9pN
 YcYlOWmpVcnj1t2JV4G2+OyQO+/f05zeiEHFbEs6zbEqDFM2oBAA7JUd9FUmPhgvHKMksph3Cd
 dlI=
IronPort-SDR: Wg+xI+Ux+u84RXpqgNs8iTdm6P+l0cyt8Qg0mcopcUQiKV9E7Wzf5p0PaRLMa3GOEnAf2BA01O
 yXo3RfzuIEPYdN2PdF+o7CXLT8b0tRSCCTFkzekfmbJfuUfscQaUTiWVs25TgxUK3tX5pUP5NZ
 CVsd+7OiCQyMDYyK4pj2U8/RKsT8+y7jMVy96C3l+y3HMMOllb6skdlfxwQBjZKG1m78550g3p
 /oSMxFiOaS4RJ74LDs2seO1ROaK4fgxYyyGDAnbOTqkC5+ozZoP8vH6DUdcQ6d8PYQL1hFpMTv
 tYg=
WDCIronportException: Internal
Message-ID: <4d105e81-7f99-a17a-2a84-5eb70c74cc91@opensource.wdc.com>
Date:   Wed, 7 Dec 2022 22:22:32 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] libata: Sort Pioneer model in blacklist names
 lexicographically
Content-Language: en-US
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Niklas Cassel <niklas.cassel@wdc.com>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221207102656.12486-1-pmenzel@molgen.mpg.de>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20221207102656.12486-1-pmenzel@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/7/22 19:26, Paul Menzel wrote:
> Fixes: commit ea08aec7e77b ("libata: add ATA_HORKAGE_NOLPM for Pioneer BDR-207M and BDR-205")
> Cc: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>  drivers/ata/libata-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index d3ce5c383f3a..c08c534b7fc7 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -3990,8 +3990,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  	{ "PIONEER DVD-RW  DVR-216D",	NULL,	ATA_HORKAGE_NOSETXFER },
>  
>  	/* These specific Pioneer models have LPM issues */
> -	{ "PIONEER BD-RW   BDR-207M",	NULL,	ATA_HORKAGE_NOLPM },
>  	{ "PIONEER BD-RW   BDR-205",	NULL,	ATA_HORKAGE_NOLPM },
> +	{ "PIONEER BD-RW   BDR-207M",	NULL,	ATA_HORKAGE_NOLPM },

Nah... Not worse the trouble. If anything, I would rather have the entire
ata_device_blacklist array entries sorted alphabetically by vendor and models.

>  
>  	/* Crucial BX100 SSD 500GB has broken LPM support */
>  	{ "CT500BX100SSD1",		NULL,	ATA_HORKAGE_NOLPM },

-- 
Damien Le Moal
Western Digital Research