Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp894225rwb; Wed, 7 Dec 2022 06:20:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf6/Z5yFDJJEG58z73lbB7kI3HHwBU2Ib7wkgyU6/L3bAE/kVb02O4uya9NXECR3qDtMhaiQ X-Received: by 2002:a17:907:a0ca:b0:7c0:b4bc:eed3 with SMTP id hw10-20020a170907a0ca00b007c0b4bceed3mr22196902ejc.735.1670422833711; Wed, 07 Dec 2022 06:20:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670422833; cv=none; d=google.com; s=arc-20160816; b=1LbljMLAXF4TQ6J7NacvPag1pK1JF6Y/2N7KONAVlzbjxb65JD7bKnb00j0IB5VF+1 6VdPDLQ9LYZwUWfmDzAKSk7OELLolwCet7hsiSjMcSEbF6nkC2J7e3VED/THjD3L1mFQ FlVExX3w3E21JyyI4VwM2OPT64SaCZzcGcVNF8B7DFa/HB8eIbEv0055XWcqrq36ehyw iFVGU0xAXcdNRC+ysfohFyky0o/2kbvEdXnkCFGL0jZc+zoZpTgf2AoX3CKuvJFGQ5HP AecVI4Agd8auEvKCsXkKTju02Lj8hpSoRSYcmfGeFRMsY+DgjwZtbwRUS2l0p4Pq+9Mg dodQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tosjZfZODydjUbuqrfEIBGsRjeHYQJ8iIC4GtSX4HdI=; b=wgwf6whJhYaXPszYx0DA5d+xC1yn/GQV9acFv907MH/ToEvIwGGcOTF8kO7DK8udL7 hROLwDLWbwDBa0DF3yCEK5ZJyu0NchIQOgyN09zg1ys83wlv2K3f7C/tfR//77n4D38J Z8tP6Yb6g0uxL9F3Q/PpbnVlZmZcc7RJ01EWSfka7jjijrmmLGGHWumN1LBhW3pMYcMp SH6OUPKLypkPUdJjpgahX03E/KThFFjd/Sf4wfQWtEPG6Muw4AqrP9TG3tu0cEkveUBO wxDwv5rVvnBxOCKLthX4+AzsC88FvflimpN9F//hg+QziULTZkdxDYlIhxQ6zTKQx9ZT DHGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=Dzp6vahb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v8-20020a056402348800b0046a0331778dsi5273798edc.118.2022.12.07.06.20.15; Wed, 07 Dec 2022 06:20:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=Dzp6vahb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbiLGOHx (ORCPT + 75 others); Wed, 7 Dec 2022 09:07:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbiLGOHV (ORCPT ); Wed, 7 Dec 2022 09:07:21 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F22162F5; Wed, 7 Dec 2022 06:07:20 -0800 (PST) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CDAC921D6F; Wed, 7 Dec 2022 14:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1670422038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tosjZfZODydjUbuqrfEIBGsRjeHYQJ8iIC4GtSX4HdI=; b=Dzp6vahbk3af6y9m0wtHT4j/LM+TyWTrbJIuLUyzPAbc24XF/CBB1eIm3UDK4IGhqwI+mj YIpJgQTcYIhAkzTYqDboGt/kD5Qs0wi5JejZgTgYXEQGBipL0FKzPZWbIw15KxDOL4Pufn QLs/PPjzoH1pMZyBiKRFSJZzF1m3LC4= Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id AAAC6136B4; Wed, 7 Dec 2022 14:07:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id D00+JxaekGOvBwAAGKfGzw (envelope-from ); Wed, 07 Dec 2022 14:07:18 +0000 Date: Wed, 7 Dec 2022 15:07:18 +0100 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , Linus Torvalds , Hugh Dickins , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] mm: push down lock_page_memcg() Message-ID: References: <20221206171340.139790-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206171340.139790-1-hannes@cmpxchg.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 06-12-22 18:13:38, Johannes Weiner wrote: > New series based on the discussion in the previous thread around > getting lock_page_memcg() out of rmap. > > I beat on this with concurrent high-frequency moving of tasks that > partially share a swapped out shmem file. I didn't spot anything > problematic. That said, it is quite subtle, and Hugh, I'd feel better > if you could also subject it to your torture suite ;) For the whole series Acked-by: Michal Hocko Thanks! > > Thanks! > > Against yesterday's mm-unstable. > > Documentation/admin-guide/cgroup-v1/memory.rst | 11 ++++- > mm/memcontrol.c | 56 ++++++++++++++++++------ > mm/rmap.c | 26 ++++------- > 3 files changed, 60 insertions(+), 33 deletions(-) > -- Michal Hocko SUSE Labs