Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 13:44:16 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Dhruva Gole <d-gole@ti.com>
Cc:     Han Xu <han.xu@nxp.com>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org
Subject: Re: [PATCH 1/2] spi: spi-fsl-lpspi: support multiple cs for lpspi
Message-ID: <Y5CYsDFdAEduswvm@sirena.org.uk>
References: <20221206225410.604482-1-han.xu@nxp.com>
 <4ed39c8f-3736-30d6-8d8c-92a4882b72e7@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="FHJ0wrEYDAahKs6C"
Content-Disposition: inline
In-Reply-To: <4ed39c8f-3736-30d6-8d8c-92a4882b72e7@ti.com>
Precedence: bulk


--FHJ0wrEYDAahKs6C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Dec 07, 2022 at 12:08:43PM +0530, Dhruva Gole wrote:
> On 07/12/22 04:24, Han Xu wrote:
> > support to get chip select number from DT file.

> > +		fsl_lpspi->num_cs = 1;
> I am not sure I understand why you are setting this to 1 here?
> I am assuming it is because you want num_cs to default to 1 if
> it is not specified in DT.

> Please can you also add a dev_err and be sure to warn about this?

The binding says that this property is optional with a default of 1 so
it should be totally fine for a system to not specify anything.

--FHJ0wrEYDAahKs6C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOQmK8ACgkQJNaLcl1U
h9DQmQf/dQmK1zhfWMV21+4MZi7jWAQPkVACX1YRD9SdP5J7ibe5UCdIXWgVK7Bd
lwYspDicnRBZIDaXfvADRgPQLSup2v+exb+xKbRGjuCC/O7ksuy4o+5l8XDfGpU3
S1AdnIyj30a5glmYiFHqLSxE1bLAlcA4dT6sZ00aWv7lsiPH8HyRhtPWH4W2TgMv
Ud76wPUbLFwz9tAF9tUUgRqlOPIRK+O51e4g1g6ErgruBvm0HrFgyUpYEqXS/Lwj
McNBNljYHdAejLfh9BPnC0xvfg1WRYR+2+PfP9IRso8PMud4eAwMn/1ir0KVtcyJ
czYfh9SX61D2s1KQ7alWZYQPfSxa4A==
=pwb/
-----END PGP SIGNATURE-----

--FHJ0wrEYDAahKs6C--