Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp899122rwb; Wed, 7 Dec 2022 06:24:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf42AO0SkiDo7Ac3fZ6H/qKVOxlii8obL1TcXFx2OyCly6Dl0rQRjUNDJ4uEdSjPX0bYh21D X-Received: by 2002:a17:906:49c2:b0:7aa:23ac:608e with SMTP id w2-20020a17090649c200b007aa23ac608emr59682472ejv.450.1670423042920; Wed, 07 Dec 2022 06:24:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670423042; cv=none; d=google.com; s=arc-20160816; b=E+akvnMTdAkAeeK4xIVzG1SJIUDgnvUvHSR+ulsy6LSsRAADp7jUbq2EHj6uUEp22P huLmhzJm3tZcfGa1zjRu/KU06MBgRGs4i3xksxXOUDElUnvthv7ZHnN6ksEzv1Sms6PY HPl365Yrfe40lJokyHTs2u7kUuPn1CBKI4SsONfS++ohiUvm/slog7RQSNM/yqFnP5c/ 2rzC+wYFOKy/2TM3fzqV8jeXGdVBhb4337L99S81lhyEl07hJmy4NOS1KVqmi+AXY4n4 0XmZYKseE9mH5mD+SoR6cmgZmfGxxMFtwBDjanrbwueTAvKi9wsA/RdNXXo88RiZZKdD Q5jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6R6RPhEMnDDwr3AtfavGsulA8T0smLmthgPNwTxk7do=; b=r4gOaIX7i1GDll14mvr61KqCNxCpRZAllTUHWzpvUkyPnnMmifTi+dVporMDHczrye 6tJRPxvtdyKv6++y8yzxJxXlL78sJ6sQe7QOzJdB+W9d2WtHgjHSbwBDtDOHoZT0OwZO E4hO9VCyTfOm8R7HqLGrcv7w/a6mkvKtzMefRpBTP8BHyO89PVRgZSZ1lQyJ1GB44JTu gMyUOar5rlpFQzIdHunxiOzVP9IZuHRakizk0NUxuebj8assGmGK8lOfrqUdhw+zSuak 7FaZu5U5/yugH0UNY8douNjUOrUue+4LllzpMcp4SEX1pNtArx5HFUTpnjO0sHMiUVx4 UfYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=rFZLKzux; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7-20020a05640227c700b00458d1c48708si4817740ede.303.2022.12.07.06.23.44; Wed, 07 Dec 2022 06:24:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=rFZLKzux; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbiLGN6L (ORCPT + 75 others); Wed, 7 Dec 2022 08:58:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbiLGN54 (ORCPT ); Wed, 7 Dec 2022 08:57:56 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9B2856545 for ; Wed, 7 Dec 2022 05:57:55 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id vv4so14224218ejc.2 for ; Wed, 07 Dec 2022 05:57:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6R6RPhEMnDDwr3AtfavGsulA8T0smLmthgPNwTxk7do=; b=rFZLKzuxSCXL0/RVKoW+2JN4Rhlu7jPPPMgyWfU8TeLIsLHk1bujos1jkakP3oAw7p 0bemsdoifiqJFY069nVhiehDpd+hhgQPnV4RaSLdEJiEQ6Hgudm4NKoOxgoHWPoHHK8G PjCHChNsPqqdvW2kF1dWmNzrQSPGOq7lqcy6+rqFOdRZ3SwMQqQLDNwbSMQ9qIoaHQJo 3dHSKfM4LAu81L+MBAw0oYiw7jaAHNuxK5AByyHBQMv9BND8lpLe76R24GF22PrRt6Uh MagZbcVq7S0RWa9EFh2wA7A/G2kBOtOhlV5pg0THEOpcqV/EO001P1iFCFWfrHedZ7yr UEyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6R6RPhEMnDDwr3AtfavGsulA8T0smLmthgPNwTxk7do=; b=uNy70SUrMHdHXF5fM/hqFsAggX3RYLcy3EBoew7UFhdGdepDqlr1XEBGjuaZZxG4g/ OalQVY91sYe0bK68FlunbcgoBkbeAY00bdjrPUdsTA32Xd2e0FVLt4LxQnbaiS1FSLKv ML4C+2EQaAIHnxZ7aD497VjhpCnZIRHBV0W6oa0eVkcFVbWa5IVodR6BBKGQfVCcIsGJ cBUJvzn+5S1FNccfM/Clrn3NBvZZ0xHwzJmWkwhvx25ZxkNtVGnGW4fNZIow5wvrhmVG ZSn89RqAtvSDYg4q9ryavXLK/FqfgaDVt5d+aTDCaNkzVXVbvTArtSUxYvuagZ8hTmmP 4cOA== X-Gm-Message-State: ANoB5plkO3MbWJvQmFH/6Avr+TeUpar+xxC8FlMPx9KFtYaiYvJV5bgz Qo2BpWXphzq0rLNxI6CCQQmtcQ== X-Received: by 2002:a17:906:ef1:b0:78d:260d:a6e4 with SMTP id x17-20020a1709060ef100b0078d260da6e4mr75140483eji.93.1670421474344; Wed, 07 Dec 2022 05:57:54 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id b7-20020a17090630c700b007b790c18264sm8500628ejb.159.2022.12.07.05.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 05:57:53 -0800 (PST) Date: Wed, 7 Dec 2022 14:57:52 +0100 From: Jiri Pirko To: Yongqiang Liu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, macro@orcam.me.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ralf@linux-mips.org, jeff@garzik.org, akpm@linux-foundation.org, zhangxiaoxu5@huawei.com Subject: Re: [PATCH net] net: defxx: Fix missing err handling in dfx_init() Message-ID: References: <20221207072045.604872-1-liuyongqiang13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207072045.604872-1-liuyongqiang13@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wed, Dec 07, 2022 at 08:20:45AM CET, liuyongqiang13@huawei.com wrote: >When eisa_driver_register() or tc_register_driver() failed, >the modprobe defxx would fail with some err log as follows: > > Error: Driver 'defxx' is already registered, aborting... > >Fix this issue by adding err hanling in dfx_init(). > >Fixes: e89a2cfb7d7b5 ("[TC] defxx: TURBOchannel support") >Signed-off-by: Yongqiang Liu Reviewed-by: Jiri Pirko