Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9316beaf-2e7c-3a9f-a804-a1bda5a40241@molgen.mpg.de>
Date:   Wed, 7 Dec 2022 16:30:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] libata: Sort Pioneer model in blacklist names
 lexicographically
Content-Language: en-US
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc:     Niklas Cassel <niklas.cassel@wdc.com>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221207102656.12486-1-pmenzel@molgen.mpg.de>
 <4d105e81-7f99-a17a-2a84-5eb70c74cc91@opensource.wdc.com>
 <5ba31f2c-89b0-c059-dda0-674db08e7466@molgen.mpg.de>
 <7ee6b490-baa7-44f5-733d-528755f37d81@opensource.wdc.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <7ee6b490-baa7-44f5-733d-528755f37d81@opensource.wdc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Damien,


Am 07.12.22 um 16:15 schrieb Damien Le Moal:
> On 12/7/22 22:26, Paul Menzel wrote:

>> Am 07.12.22 um 14:22 schrieb Damien Le Moal:
>>> On 12/7/22 19:26, Paul Menzel wrote:
>>>> Fixes: commit ea08aec7e77b ("libata: add ATA_HORKAGE_NOLPM for Pioneer BDR-207M and BDR-205")
>>>> Cc: Niklas Cassel <niklas.cassel@wdc.com>
>>>> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>>>> ---
>>>>    drivers/ata/libata-core.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
>>>> index d3ce5c383f3a..c08c534b7fc7 100644
>>>> --- a/drivers/ata/libata-core.c
>>>> +++ b/drivers/ata/libata-core.c
>>>> @@ -3990,8 +3990,8 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>>>>    	{ "PIONEER DVD-RW  DVR-216D",	NULL,	ATA_HORKAGE_NOSETXFER },
>>>>    
>>>>    	/* These specific Pioneer models have LPM issues */
>>>> -	{ "PIONEER BD-RW   BDR-207M",	NULL,	ATA_HORKAGE_NOLPM },
>>>>    	{ "PIONEER BD-RW   BDR-205",	NULL,	ATA_HORKAGE_NOLPM },
>>>> +	{ "PIONEER BD-RW   BDR-207M",	NULL,	ATA_HORKAGE_NOLPM },
>>>
>>> Nah... Not worse the trouble. If anything, I would rather have the entire
>>> ata_device_blacklist array entries sorted alphabetically by vendor and models.
>>
>> What trouble?
> 
> Manner of speaking. I meant the patch value is not worth the time to
> process it.
> As suggested, sorting the entire array would be a more valuable change.

Understood. (I guess perfect is the enemy of the good – also as seen 
with my other patch from which other users can’t benefit.) :/

>>>>    	/* Crucial BX100 SSD 500GB has broken LPM support */
>>>>    	{ "CT500BX100SSD1",		NULL,	ATA_HORKAGE_NOLPM },


Kind regards,

Paul