Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "larry.lai" <larry.lai@yunjingtech.com>
To:     lee@kernel.org, andriy.shevchenko@linux.intel.com,
        linus.walleij@linaro.org, pavel@ucw.cz
Cc:     linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-leds@vger.kernel.org, GaryWang@aaeon.com.tw,
        musa.lin@yunjingtech.com, jack.chang@yunjingtech.com,
        noah.hung@yunjingtech.com, "larry.lai" <larry.lai@yunjingtech.com>
Subject: [RFC 3/3] leds: Add support for UP board CPLD onboard LEDS
Date:   Thu,  8 Dec 2022 00:33:59 +0800
Message-Id: <20221207163359.26564-4-larry.lai@yunjingtech.com>
In-Reply-To: <20221207163359.26564-1-larry.lai@yunjingtech.com>
References: <20221207163359.26564-1-larry.lai@yunjingtech.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0Ij3G0iE1E7RAI5sTiY2Pr34lGAoMw+5hDMsMWH3lEP+qfWHHgKEgjgCiFrX?=
 =?us-ascii?Q?RBGjfQVLw8wDglJSk0ssmFoMQGucSfYrdqBKQEsgHVbqAZ2N9i0uUmi9COEj?=
 =?us-ascii?Q?mcUFF7j85M1lJF4D63pLzwig3Hu+aB03fOhuw21AxPfiKgcvVjWdbOtHuHdg?=
 =?us-ascii?Q?LSw30RpS9IE6IpslYuZHHnYhwwQ37TO4VAtbXIm5vXatjPzTaP/GDCN4QItB?=
 =?us-ascii?Q?8rlokmB5rDjym1sLGiE8z59wN5GRxlI+xztRcyWhnmv1qqJdRWzgjK+gDrBB?=
 =?us-ascii?Q?glwMAzJkJunrdUUkp9rrJXnjMXmF4NMWIXU6tSH76aVSJCwoThBUUtt7ZFEM?=
 =?us-ascii?Q?drpdwgMDKr9DOwOPXybcqC7XyNjjGkbdMVH1+oGqXSRtbbS0auXzS7XGBz1c?=
 =?us-ascii?Q?Yo1Dj7GlqWwA5u463yvMq1Fz3aKA3PUxszLRxUkOFQQdkz+8aTDu77LtWVVq?=
 =?us-ascii?Q?+uYhoDDxiPHzGC+Nz6eAZn1EooFdl0MsZ21Ew+7FSh5OW2eSYpMRMRhQ6Yyw?=
 =?us-ascii?Q?brGewxAXTdQMD/e5xEti7yDAYkg+nG2YTRg+ktDf7WGwPgeWO9MBq3l49wl7?=
 =?us-ascii?Q?3uhKPFzSgkTQY6OMEopwkRbNzc6hhUQFrtPs3tyssMgftJB/L6jDu3gGJ2rO?=
 =?us-ascii?Q?4lRYmnK9Q+bhOWAEM60kpwZxMaovr0S9e7GJ9Bao0oUgIHnoGQW2BgVOOmRJ?=
 =?us-ascii?Q?S3abQBT4KASrfEmoUA/MIF+hGr7srJZY6ODbe2JxohByOMcjndnxT3KexqAo?=
 =?us-ascii?Q?eBa0P6OV00ysA8ib/QLLgj3SLIlWqalLoLbTooheiZfDTmFKGD/hwzdfP1M2?=
 =?us-ascii?Q?m86QyPaqoWE0Hut7ueVhmjLhagBmCCJ1LPHbjWWsLGtDRibTo8/a/lI4sX1P?=
 =?us-ascii?Q?2ot4NnOCkGGtQYUw/Bomen26JeKkExba4YjlaGa045dro1rU7kjQ04G3g27D?=
 =?us-ascii?Q?1syevncGRWFCX6dX2jggFYvdbBGf8TlDdpaeBytTex/0SZpPh6+6NwQzhKx4?=
 =?us-ascii?Q?pK/lvCDsfgxo6SYmHfenEepP+HedndCA7jJ/BtcRC5RGn3bIZn1NcMJUQzzb?=
 =?us-ascii?Q?irbhXXgCJkxKTQOVRf43QaZTMk9HU754vnjFW/c0Tal3an6OcqRAnLcniSL8?=
 =?us-ascii?Q?X5dMkj6NbfMAaznwuyK82aYlreqJZw6vZ8wUXHa03L/BXsu73l220TzIQwbJ?=
 =?us-ascii?Q?xHtwOGNNO/TaHO46q43PO96PMpxr69FJzvKDSUtFqBQw3ol5IvJa0cl4dyT/?=
 =?us-ascii?Q?S2/dV1gIcAixC0tdfYJSm3RZgduGXbxl+kh84hOuCCia7soB137vKCzQc74e?=
 =?us-ascii?Q?FSdgHjX8NIkWIFaZZRKL7X2vuL5SJUqFU8dibTlWCSBM+OW42AZDSstABEBX?=
 =?us-ascii?Q?FhIDenGgwWEI74w+5tmDF1geM/6E/Cz4n4zlFleyMUC2Uf14XgOYc5EWve5D?=
 =?us-ascii?Q?HIIB9xREsjJrB7dfGEIhuGH++KvMfJjQH6p6B1OAcdIxqJnELbmBMJIE39dL?=
 =?us-ascii?Q?wnN928EVsI8luu7h69gv2pOjanQZ4HtKSD5aOZ9FV8L1vrgC5amPOso+GUIJ?=
 =?us-ascii?Q?9FGzwdpNo/70oSXM6iBZucLocP4o9uy0whz7OyoVPeMdpfhyGLu1qk64K3js?=
 =?us-ascii?Q?HA=3D=3D?=
X-OriginatorOrg: yunjingtech.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ac75888-299e-48af-5cd9-08dad8712d26
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3742.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 16:36:22.8770
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: be2d5505-f7e6-4600-bbe2-b3201c91b344
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Lss+xANaoQzOfq5uh51nLaghyLpvJyPrVydLjM5ExNIkvYLi1WGumxM03Ss9QO7xOLmM0sjr6uCWp5E30uDtET5bbGHy6KkNLoNXC5QsWSQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4278
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The UP boards come with a few FPGA-controlled onboard LEDs:
* UP Board: yellow, green, red
* UP Squared: blue, yellow, green, red

This patch depends on patch "mfd: Add support for UP board CPLD/FPGA".

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: larry.lai <larry.lai@yunjingtech.com>
---
PATCH V3 -> RFC 2022/11/23: Update the changes Copyright.
PATCH V1 -> V3: There is no change.
PATCH --> PATCH V1: Refer 2022/10/03 Andy Shevchenko review, cleaned up
coding style.
---
 drivers/leds/Kconfig        | 10 +++++
 drivers/leds/Makefile       |  1 +
 drivers/leds/leds-upboard.c | 79 +++++++++++++++++++++++++++++++++++++
 3 files changed, 90 insertions(+)
 create mode 100644 drivers/leds/leds-upboard.c

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 499d0f215a8b..d9d533cb38ca 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -872,6 +872,16 @@ source "drivers/leds/flash/Kconfig"
 comment "RGB LED drivers"
 source "drivers/leds/rgb/Kconfig"
 
+config LEDS_UPBOARD
+	tristate "LED support for the UP board"
+	depends on LEDS_CLASS
+	depends on MFD_INTEL_UPBOARD_FPGA
+	help
+	  This option enables support for the UP board LEDs.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called leds-upboard.
+
 comment "LED Triggers"
 source "drivers/leds/trigger/Kconfig"
 
diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
index 4fd2f92cd198..e72956645646 100644
--- a/drivers/leds/Makefile
+++ b/drivers/leds/Makefile
@@ -83,6 +83,7 @@ obj-$(CONFIG_LEDS_TI_LMU_COMMON)	+= leds-ti-lmu-common.o
 obj-$(CONFIG_LEDS_TLC591XX)		+= leds-tlc591xx.o
 obj-$(CONFIG_LEDS_TPS6105X)		+= leds-tps6105x.o
 obj-$(CONFIG_LEDS_TURRIS_OMNIA)		+= leds-turris-omnia.o
+obj-$(CONFIG_LEDS_UPBOARD)		+= leds-upboard.o
 obj-$(CONFIG_LEDS_WM831X_STATUS)	+= leds-wm831x-status.o
 obj-$(CONFIG_LEDS_WM8350)		+= leds-wm8350.o
 obj-$(CONFIG_LEDS_WRAP)			+= leds-wrap.o
diff --git a/drivers/leds/leds-upboard.c b/drivers/leds/leds-upboard.c
new file mode 100644
index 000000000000..7a597fdad43c
--- /dev/null
+++ b/drivers/leds/leds-upboard.c
@@ -0,0 +1,79 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * UP Board FPGA-based LED driver
+ *
+ * Copyright (c) 2017, Emutex Ltd. All rights reserved.
+ * Copyright (c) 2022, YunJingTech Ltd.
+ *
+ * Author: Javier Arteaga <javier@emutex.com>
+ */
+
+#include <linux/kernel.h>
+#include <linux/leds.h>
+#include <linux/mfd/upboard-fpga.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+
+struct upboard_led {
+	struct led_classdev cdev;
+	struct regmap_field *field;
+};
+
+static enum led_brightness upboard_led_brightness_get(struct led_classdev *cdev)
+{
+	struct upboard_led *led = container_of(cdev, struct upboard_led, cdev);
+	int brightness = 0;
+
+	regmap_field_read(led->field, &brightness);
+
+	return brightness;
+};
+
+static void upboard_led_brightness_set(struct led_classdev *cdev, enum led_brightness brightness)
+{
+	struct upboard_led *led = container_of(cdev, struct upboard_led, cdev);
+
+	regmap_field_write(led->field, brightness != LED_OFF);
+};
+
+static int __init upboard_led_probe(struct platform_device *pdev)
+{
+	struct upboard_fpga * const up_fpga = dev_get_drvdata(pdev->dev.parent);
+	struct reg_field fldconf = {
+		.reg = UPFPGA_REG_FUNC_EN0,
+	};
+	struct upboard_led_data * const pdata = pdev->dev.platform_data;
+	struct upboard_led *led;
+
+	led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL);
+	if (!led)
+		return -ENOMEM;
+
+	fldconf.lsb = pdata->bit;
+	fldconf.msb = pdata->bit;
+	led->field = devm_regmap_field_alloc(&pdev->dev, up_fpga->regmap, fldconf);
+	if (IS_ERR(led->field))
+		return PTR_ERR(led->field);
+
+	led->cdev.brightness_get = upboard_led_brightness_get;
+	led->cdev.brightness_set = upboard_led_brightness_set;
+	led->cdev.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "upboard:%s:",
+					pdata->colour);
+	if (!led->cdev.name)
+		return -ENOMEM;
+
+	return devm_led_classdev_register(&pdev->dev, &led->cdev);
+};
+
+static struct platform_driver upboard_led_driver = {
+	.driver = {
+		.name = "upboard-led",
+	},
+};
+module_platform_driver_probe(upboard_led_driver, upboard_led_probe);
+
+MODULE_AUTHOR("Javier Arteaga <javier@emutex.com>");
+MODULE_DESCRIPTION("UP Board LED driver");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:upboard-led");
-- 
2.17.1